Skip to content

✨ Betty speaks ready answers shortest first and moves a long voice queue to chat - #18627

Closed
clubanderson wants to merge 2 commits into
v5from
betty-voice-queue
Closed

clubanderson wants to merge 2 commits into
v5from
betty-voice-queue

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Part 3 of the concurrent-requests work on #18590: ordering of parallel answers and the chat burst.

Voice. Quorum's say returns {queued:true} once a clip is accepted and plays clips in call order (quorum docs/contract.md), so she cannot talk over herself, but hive cannot see when she stops talking. The session now keeps an estimate of the queued speech (15 characters a second, at least 1 s a clip) and:

  • takes every persona reply that is ready in one loop turn (drainPersona, up to 16) and speaks the spoken answers among them back to back, shortest first;
  • posts an answer to chat instead when it would wait behind more than 20 s of queued speech (voiceBacklogMax), and says "I've put the rest in chat." once (at most every 30 s, localized for en/es/fr/de/pt/it);
  • skips an acknowledgement that would only play after more than 8 s of earlier speech (ack_no_voice drop, as before for an unspoken ack).

Chat burst. New meetings.chat_answer_burst (default 3, HIVE_MEETINGS_CHAT_ANSWER_BURST): once meetings.chat_posts_per_minute (6) is spent, answers to addressed requests (and voice answers falling back to chat) may take that many extra posts a minute. Spek's posts, room-question answers and queue notes keep the plain rate.

Combined with #18623 (parallel model calls) and #18625 (attribution), answers post as soon as each is ready and their prefix makes the order unambiguous.

The run-loop change is one added line after s.onPersonaReply(ctx, rep); #18592 adds a case just above it, so whichever merges second rebases trivially.

Tests (live/voicequeue_test.go): three ready answers spoken shortest first with the long one moved to chat and the note spoken, an ack skipped behind 12 s and spoken behind 2 s, burst past the rate for answers but not for Spek and none when unset, speech-time estimate and back-to-back backlog.

🤖 Generated with Claude Code

…eue to chat

Quorum's say queues clips and plays them in order, so hive keeps an
estimate of the queued speech. Spoken answers ready in the same loop turn
are said back to back, shortest first; one that would wait behind more
than 20 s goes to chat with one spoken "I've put the rest in chat"; an
ack behind more than 8 s of speech is skipped. Answers to addressed
requests may take meetings.chat_answer_burst (3) extra chat posts a
minute past the chat rate.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18633 🐛 Meetings: don't restart-loop the Spektacular stream child when live mode isn't available CONFLICT src/cmd/hive/meetingswire.go
src/pkg/meetings/live/session.go (conflict)
#18623 ✨ Betty runs several model calls per meeting at once same files src/cmd/hive/meetingswire.go
src/docs/meetings.md
src/pkg/config/meetings_config.go
src/pkg/dashboard/api_meetings.go
#18625 ✨ Betty names who and what each answer is for when requests overlap same files src/docs/meetings.md
src/pkg/meetings/live/session.go
#18615 ✨ Meetings: delete finished meetings and stale join requests same files src/docs/meetings.md
src/pkg/dashboard/api_meetings.go
#18631 ✨ Betty cites the sources of chat answers and says when she is not sure CONFLICT src/docs/meetings.md (conflict)
#18611 ✨ meetings: desktop companion meetings (/api/companion/*) same files src/docs/meetings.md
#18629 ✨ Betty times every answer stage and answers live-state questions without waiting for search CONFLICT src/docs/meetings.md (conflict)
src/pkg/meetings/live/session.go (conflict)
#18602 📖 docs: Betty on Zoom without a Zoom app, options and recommendation same files src/docs/meetings.md

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

5 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/meetings/live/session.go 739 CONDITIONALS_NEGATION
src/pkg/meetings/live/session.go 743 CONDITIONALS_NEGATION
src/pkg/meetings/live/voicequeue.go 33 ARITHMETIC_BASE
src/pkg/meetings/live/voicequeue.go 37 ARITHMETIC_BASE
src/pkg/meetings/live/voicequeue.go 39 ARITHMETIC_BASE

Verdict: uncovered (#17349).

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson

Copy link
Copy Markdown
Member Author

Combined into #18635 to get through CI and review together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant