Repository navigation
✨ Betty names who and what each answer is for when requests overlap - #18625
clubanderson wants to merge 1 commit into
Conversation
With more than one request in flight, other lines said since the request, or an answer later than 8 s, each answer opens with the asker's display name (first name when spoken, never an @mention) and a short topic phrase: the model's new "topic" label, else the request's own words. Two or more requests in hand post one queue note per minute (chat, rate limited, not charged), and spoken acks name their asker when others are waiting. Part of #18590. Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 11 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
3 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
Combined into #18635 to get through CI and review together. |
Part 2 of the concurrent-requests work on #18590: explicit attribution and queue awareness. Independent of #18623 (parallel model calls); together they let Betty answer in parallel without the room losing track.
Attribution. An answer opens with who asked and a short topic when the order could be unclear:
attributeAfter).Format, localized for en/es/fr/de/pt/it: chat
Andy Anderson (re: open PRs): ..., voiceAndy, about open PRs: ...(first name only). The topic is a newtopicfield in the model's JSON answer (2 to 5 words), else a heuristic over the request's own words with the person's casing restored (Restis lowercased). Names are written plain: no@name, mention marks stripped, so nothing pings (on Discord a literal@everyone-like name would). A single quick answer keeps no prefix. The prefix is added on top of the already clipped answer rather than cutting it (a dig-in sentence is never lost).Queue awareness. With two or more addressed requests in hand, one chat note
I have N questions; answering each as it's ready., at most once a minute, through the chat rate limit, never charged (newTriggerQueue, handled before the switch inonPersonaReplyto stay clear of #18592's hunks). A spoken ack names its asker (Bo, one moment.) when another request is already in flight, both for final-line and partial-transcript acks.Tests:
betty/attribution_test.go(two gated requests answered out of order are both attributed with the model topic, one queue note per minute, late single answer gets a prefix, spoken acks and answers name the asker, a line from someone else in between triggers attribution with the heuristic topic, topic/name/mention cleaning,topicparsed),live/attribution_test.go(overlapping chat requests: one note posted, both answers attributed, note not counted as a reply).🤖 Generated with Claude Code