Repository navigation
✨ Betty acknowledges a spoken request from the partial transcript - #18599
Conversation
The spoken ack waited for the final transcript, which on Google Meet comes after the turn closes and the speaker's drafts are reconfirmed, so it landed about 6 s after she was asked (#18590 finding 4). Partial segments now reach the persona (ObservePartial, filtered before the queue); once a partial names her with a request of at least two words and voice is wanted, she speaks the ack at once and the final line gets the answer without a second ack. An unaddressed final clears the mark; Spek and open asks still see only final lines. Part of #18590 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 3 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
4 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure logging and Discord wording, #18595, #18593, #18599, #18591) alongside meeting delete. Clears consentTries on delete, adds the delete helpers to the meetings/calendar role-race test harness (server-tests failed with meetingsFinished is not defined), and refreshes docs citations. Signed-off-by: Andy Anderson <andy@clubanderson.com>
Part of #18590 (finding 4, the hive half).
Problem
Betty's spoken acknowledgement waited for the final transcript. On Google Meet the final arrives after the turn closes and the speaker's drafts are reconfirmed, then the ack still needs TTS: in the live test the ack came about 6 s after the turn closed.
Change
live/session.go: partial (non-final) spoken segments go topersona.ObservePartial; Spek and open-ask matching still see only final lines.betty:ObservePartialdrops anything that does not address her before it reaches the queue (partials never crowd out final lines).onPartialspeaks the ack once a partial names her with a request of at leastearlyAckMinWords(2) words, voice is wanted and a model is configured; once per speaker. The speaker's final line then gets the answer and no second ack (earlyAckWindow30 s). An unaddressed final clears the mark. Intros and bare "Betty" still wait for the final line (hello / intro get no ack).The ack audio itself is cached and prewarmed in the bot by hivecommons/vexa#9 (
BOT_TTS_PREWARM, set to Betty's English acks:Let me check on that.|One moment.|Good question, let me look.|Let me see.), so with both the ack should start within about 2 s of the name being heard.Tests
betty/fastack_test.go: early ack once per utterance then the answer without a second ack; no early ack for a bare name, a one-word request, an unaddressed line, chat, an intro, or without a model; an unaddressed final clears the mark. CI is the verdict (no local go test per repo rules);gofmt -lclean.🤖 Generated with Claude Code