Skip to content

✨ Betty acknowledges a spoken request from the partial transcript - #18599

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
feat/18590-fast-ack
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
feat/18590-fast-ack

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Part of #18590 (finding 4, the hive half).

Problem

Betty's spoken acknowledgement waited for the final transcript. On Google Meet the final arrives after the turn closes and the speaker's drafts are reconfirmed, then the ack still needs TTS: in the live test the ack came about 6 s after the turn closed.

Change

  • live/session.go: partial (non-final) spoken segments go to persona.ObservePartial; Spek and open-ask matching still see only final lines.
  • betty: ObservePartial drops anything that does not address her before it reaches the queue (partials never crowd out final lines). onPartial speaks the ack once a partial names her with a request of at least earlyAckMinWords (2) words, voice is wanted and a model is configured; once per speaker. The speaker's final line then gets the answer and no second ack (earlyAckWindow 30 s). An unaddressed final clears the mark. Intros and bare "Betty" still wait for the final line (hello / intro get no ack).

The ack audio itself is cached and prewarmed in the bot by hivecommons/vexa#9 (BOT_TTS_PREWARM, set to Betty's English acks: Let me check on that.|One moment.|Good question, let me look.|Let me see.), so with both the ack should start within about 2 s of the name being heard.

Tests

betty/fastack_test.go: early ack once per utterance then the answer without a second ack; no early ack for a bare name, a one-word request, an unaddressed line, chat, an intro, or without a model; an unaddressed final clears the mark. CI is the verdict (no local go test per repo rules); gofmt -l clean.

🤖 Generated with Claude Code

The spoken ack waited for the final transcript, which on Google Meet comes
after the turn closes and the speaker's drafts are reconfirmed, so it landed
about 6 s after she was asked (#18590 finding 4). Partial
segments now reach the persona (ObservePartial, filtered before the queue);
once a partial names her with a request of at least two words and voice is
wanted, she speaks the ack at once and the final line gets the answer without
a second ack. An unaddressed final clears the mark; Spek and open asks still
see only final lines.

Part of #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18592 🐛 Betty closes the loop on deep dives; research agents survive config reloads same files src/pkg/meetings/betty/betty.go
src/pkg/meetings/live/session.go

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 3 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/meetings/betty/queue.go 191 CONDITIONALS_BOUNDARY
src/pkg/meetings/betty/queue.go 198 CONDITIONALS_BOUNDARY
src/pkg/meetings/betty/queue.go 211 CONDITIONALS_BOUNDARY

4 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/meetings/betty/betty.go 410 CONDITIONALS_NEGATION
src/pkg/meetings/betty/betty.go 412 CONDITIONALS_NEGATION
src/pkg/meetings/betty/queue.go 177 ARITHMETIC_BASE
src/pkg/meetings/live/session.go 229 CONDITIONALS_NEGATION

Verdict: lived (#17349).

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 5c95aac into v5 Nov 17, 2026
104 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/18590-fast-ack branch November 17, 2026 03:09
clubanderson added a commit that referenced this pull request Nov 17, 2026
Keeps v5's meetings changes (#18594 consent delivery, #18600 failure
logging and Discord wording, #18595, #18593, #18599, #18591) alongside
meeting delete. Clears consentTries on delete, adds the delete helpers
to the meetings/calendar role-race test harness (server-tests failed
with meetingsFinished is not defined), and refreshes docs citations.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant