Skip to content

πŸ› needs-sha keeps hive off an issue until the reporter adds a SHA - #18563

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
fix/needs-sha-gate
Nov 17, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
fix/needs-sha-gate

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Follow-up to #18542. needs-sha now keeps issues out of agent work lanes (enumeration and webhook classification) regardless of reporter-trust settings; configured name honoured; label created with description. Removal by the SHA sweep releases the issue. Issue gate only, not a PR merge gate. Tests and docs glossary updated.

πŸ€– Generated with Claude Code

After #18542 the SHA-hold sweep only applies needs-sha, which did not block agent work, so with reporter trust disabled those issues became workable. needs-sha (configured name or default) now sidelines the issue in enumeration and webhook classification until the sweep removes it.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18586 ✨ Sandboxed agents open issues and keep topic claims through the request spool same files src/pkg/github/client.go
#18583 ✨ Governor: opt-in advisory report in every repo (default off) same files src/docs/operator-reference/README.md
#18536 ✨ feature: choose remote repository write identity same files src/docs/operator-reference/README.md

@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • relative links and anchors resolve

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Evidence bundle `#185638b03d65` sha256:c49f2fc1ab9cba85b19a740c2063ecb7b58f07d9d75cac543db5a38aa91d7ca1 β€” download from the dashboard or `hivectl review evidence #18563`.

@hivecommons-hive
hivecommons-hive Bot merged commit 7f62225 into v5 Nov 17, 2026
85 of 86 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/needs-sha-gate branch November 17, 2026 01:40
@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 8b03d65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant