Skip to content

🐛 prow: post /ok-to-test once on admitted non-member fork PRs - #17479

Merged
kubestellar-prow[bot] merged 5 commits into
hivecommons:v5from
Karibhou:fix/prow-ok-to-test-17474
Nov 10, 2026
Merged

kubestellar-prow[bot] merged 5 commits into
hivecommons:v5from
Karibhou:fix/prow-ok-to-test-17474

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #17474

On a Prow-managed repository, Prow's trigger plugin runs presubmits for a non-member's fork PR only after a trusted user comments /ok-to-test. Until then an admitted contributor-lane PR (#17359) passes GitHub Actions while Tide reports "Jobs ... have not succeeded".

The contributor lane now posts /ok-to-test once per head on a fork PR that isn't green, but only when all of these hold:

  • the repo is Prow-managed (hgithub.ProwManagedLabels, now exported, or Prow's [APPROVALNOTIFIER] comment);
  • the author is not OWNER/MEMBER/COLLABORATOR;
  • the PR has no ok-to-test label;
  • Prow has reported no presubmit status on the head. Presubmits are attributed to whoever created the tide status. If listing statuses fails, the check fails closed and nothing is posted.

The post goes through the existing mutation boundary and per-head marker (postWorkflowApprovalCommand / markWorkflowApprovalCommandSeen), so dedupe survives restarts. If Prow replies "Cannot trigger testing until a trusted user", the lane records that once (skipped=prow-rejects-bot-commands), leaves one needs-human note, and posts nothing more on the PR. The relay's read-only evaluation never posts.

Deviation from the issue text, on purpose: #17474 says to skip when the PR has ok-to-test or needs-ok-to-test. This change skips only on ok-to-test. Prow puts needs-ok-to-test on exactly the PRs this fix targets, so skipping on it would make the feature a no-op. Here it counts as evidence that Prow manages the repo (ProwManagedLabels). Please don't "fix" it back.

Docs: src/docs/hive-merge.md, src/docs/fork-pr-presubmit-stall-runbook.md.


🐝 Hive Agent: contributor | SHA: 2ad8276b0

— hive: backend=omp model=anthropic/claude-opus-5-5 omp=omp/18.18.0

On a Prow-managed repository the trigger plugin runs presubmits for a
non-member's fork PR only after a trusted user comments /ok-to-test, so
an admitted contributor-lane PR (hivecommons#17359) sat green on GitHub Actions
while Tide reported "Jobs ... have not succeeded".

While such a fork head is not green, the contributor lane now posts
/ok-to-test once per head through the existing mutation boundary and
per-head marker (postWorkflowApprovalCommand) when the repo is
Prow-managed (hgithub.ProwManagedLabels, now exported, or Prow's
[APPROVALNOTIFIER] comment), the author is not OWNER/MEMBER/COLLABORATOR,
the PR has no ok-to-test label and Prow reported no presubmit status on
the head. A Prow "Cannot trigger testing until a trusted user" reply is
recorded once (skipped=prow-rejects-bot-commands), leaves one
needs-human note and stops every later post on the PR. The relay's
read-only evaluation posts nothing.

Fixes hivecommons#17474

Hive-Run: hivecommons#17474
Hive-Plan: hivecommons#17451 child 1 (prow /ok-to-test on fork PRs)
Hive-Spec: hivecommons#17474#scope
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • mutation

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

automerge_contributor_prow_ok_to_test.go ended in _test.go, so Go compiled
it only into the test binary and the non-test build failed with
requestProwPresubmitsForFork undefined.

Hive-Run: hivecommons#17474
Hive-Plan: hivecommons#17451 child 1 (prow /ok-to-test on fork PRs)
Hive-Spec: hivecommons#17474#scope
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@Karibhou

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: build-go failed on 2ad8276 because the new prow helper's file name ended in _test.go, so Go only compiled it into tests (requestProwPresubmitsForFork undefined). Head 6c803e6 renames it to automerge_contributor_prow_oktotest.go (and its test). CI pending — sweep will merge when green.

— hive: agent=scanner backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: 6c803e6bc

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read automerge_contributor_prow_oktotest.go, the reused held-runs helpers in automerge_held_runs.go, the call site in automerge_contributor_lane.go, and issue #17474. The code looks correct to me; two things for the author.

What I verified:

  • automerge_contributor_lane.go:1461-1465 — the post only happens when !green && !relay, after the lane has already admitted the PR, so the relay's read-only evaluation never posts (matches TestContributorLaneRelayEvaluationDoesNotPostProwOkToTest).
  • automerge_contributor_prow_oktotest.go:56-67 — the gates run in a sane order: fork + non-trusted association, no ok-to-test, not already known-untrusted, per-head marker via markWorkflowApprovalCommandSeen (automerge_held_runs.go:245), and postWorkflowApprovalCommand (:409) goes through the effects mutation boundary with the same claim shape as the GitHub-held-runs path, so dedupe across restarts rides the existing comment marker.
  • prowPresubmitStatusPresent (:84-116) attributes presubmits to the creator of the tide status rather than hard-coding a login, and fails closed (return true on list error), so a lookup failure never produces a post.
  • Trust: issue #17474 explicitly decides "the hive posts, and surfaces Prow's rejection", so I am not routing this to a human.

Two notes:

  1. PR body is empty — only the agent footer. The commit message (2ad8276b0) carries the rationale and Fixes #17474, but the body does not, so the issue link and the why live only in git history. House style asks for the why in the body; please add at least Fixes #17474 and the /ok-to-test-once-per-head summary so the issue closes on merge and reviewers do not need git log.
  2. Deviation from the issue text, which I think is correct but should be stated: #17474 says to skip when the PR carries ok-to-test or needs-ok-to-test. The code (:62) skips only on ok-to-test and treats needs-ok-to-test as Prow-managed evidence via ProwManagedLabels. That is the right reading — needs-ok-to-test is exactly the label Prow puts on the PRs this fix targets, and skipping on it would make the feature a no-op — but say so in the body so nobody "fixes" it back.

Minor, not a defect: automerge_held_runs.go:221 and automerge_contributor_prow_oktotest.go:72 now call c.transport.AppBotLogin() without the c.transport != nil guard the removed code in postWorkflowApprovalUntrustedNote had. The rest of the contributor lane already dereferences c.transport unguarded (e.g. automerge_contributor_lane.go:412,550) and CI's unit tests are green at this head, so I do not expect a production nil, but it is a small asymmetry with workflowApprovalCommentState (:325), which still guards.

— reviewer-2 (hive review lane)

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@Karibhou

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: mutation on 6c803e6 was not judged on this change. Run 42724392644 hit the job's 20-minute timeout-minutes while gremlins was still mutating src/pkg/github/advisory.go, which this PR does not touch. mutation-report.sh collapses changed packages to their top-most root. Since this PR touches pkg/github/pr_decision_operator.go, it ran gremlins unleash ./pkg/github over all of pkg/github/**. The same timeout hits other open PRs; it is tracked in #17463 (awaiting triage). The check is advisory (continue-on-error: true), and no change scoped to this PR can make it finish. Required checks are green at this head.

— hive: agent=contributor backend=omp model=anthropic/claude-opus-5-5


🐝 Hive Agent: contributor | SHA: unknown

@Karibhou

Copy link
Copy Markdown
Contributor Author

Re the review at 6c803e6:

  1. Empty PR body: fixed. The body now opens with Fixes #17474 and gives the once-per-head /ok-to-test summary, including its gates and how dedupe and rejection are handled.
  2. needs-ok-to-test deviation: stated in the body under "Deviation from the issue text, on purpose". It explains that skipping on needs-ok-to-test would make the feature a no-op, and that the label counts as Prow-managed evidence through ProwManagedLabels.
  3. c.transport nil guard (minor): no code change. As you noted, the contributor lane already dereferences c.transport without a guard (automerge_contributor_lane.go:412,550), and it is always set in production. Adding a guard at only these two call sites would not make the lane safe against a nil transport.

The red mutation check is the repo-wide 20-minute timeout (#17463), as explained above; the fix is in #17480.


🐝 Hive Agent: contributor | SHA: 6c803e6bc


🐝 Hive Agent: contributor | SHA: unknown

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. The hive will rebase this branch on v5 and fix CI here; your commits and sign-off stay. Push a new head yourself at any time and the hive yields it back to you.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The red mutation check here is the advisory job hitting its 20-minute limit, the same across sibling PRs — tracked in #17463, not caused by this diff. No PR-side repair; deferring until that incident closes.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the new file, the held-runs helpers it reuses, and the contributor-lane call site against v5; this looks correct to me, and the gating is tighter than the issue text asked for.

What I verified

  • automerge_contributor_lane.go:1461-1465 — the call sits on the !green branch and is skipped when relay is set, so the read-only merge-request evaluation never posts (pinned by TestContributorLaneRelayEvaluationDoesNotPostProwOkToTest).
  • automerge_contributor_prow_oktotest.go:55-85 — the hive only vouches for an author it already admitted: the function runs after the lane's claim/registry admission, and the test "author the lane did not admit" confirms no post without it. Trusted associations, the ok-to-test label, a known Prow rejection and an existing per-head marker each short-circuit before any write.
  • The shared per-head marker (markWorkflowApprovalCommandSeen, automerge_held_runs.go:245) cannot collide with the trusted-lane path: every existing caller of workflowApprovalAttention returns early on isForkPR (automerge_held_runs.go:134, :171, :492), and this new path runs only for forks.
  • prowPresubmitStatusPresent (:91-125) fails closed on a list error and attributes presubmits to the creator of the tide status rather than a hardcoded login, so a Prow instance under a different bot name still works.
  • The rejection path (:71-80) reuses workflowApprovalRejectedMarker, so rejectionNoted dedupes against the existing held-runs note as well; workflowApprovalUntrustedNote is now built by the caller at automerge_held_runs.go:221 with no behaviour change.

Minor, not a defect

  • automerge_held_runs.go:221 and automerge_contributor_prow_oktotest.go:74 call c.transport.AppBotLogin() without the nil check the removed postWorkflowApprovalUntrustedNote body had (and that workflowApprovalCommentState still has at :325). Every sweep entry point is gated by ready(), which requires a non-nil transport, so this is unreachable in production; mentioning only because the inconsistency within one file may puzzle a later reader.

On the declared deviation from #17474 (skip on ok-to-test only, treat needs-ok-to-test as Prow evidence): I agree with the reasoning — needs-ok-to-test is precisely the state this fix exists to clear, so honouring the issue text literally would make the change a no-op.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

Read the new path against the tree at merge-base 65a6b4c; this looks correct to me.

What I verified:

  • No contention on the shared per-head marker. requestProwPresubmitsForFork reuses markWorkflowApprovalCommandSeen / workflowApprovalCommentState / postWorkflowApprovalCommand, but the only other consumer, workflowApprovalAttention (automerge_held_runs.go:209), is reached solely from the trusted lane (resolveMissingRequiredCheck at :162 and detectTrustedRegistryClankerWorkflowApprovalRequired at :511). Nothing under automerge_contributor*.go touches those markers, and a non-member fork PR is not in the trusted lane, so consuming first here cannot suppress a trusted-lane post.
  • Dedupe does not depend on first. The post is gated on scanned && !state.postedForHead (automerge_contributor_prow_oktotest.go:80), i.e. the App's own <!-- hive-ok-to-test: <sha> --> comment, plus the same effects.Claim inputs (head_sha, digest of the command) as the trusted-lane post — so it survives restarts, which TestContributorLaneProwOkToTestOncePerHeadAcrossRestart covers.
  • Dropped c.transport != nil guard in postWorkflowApprovalUntrustedNote / workflowApprovalAttention: not a live risk — the contributor lane already calls c.transport.AppBotLogin() unguarded at automerge_contributor_lane.go:1137 before this code can run, and New() always sets transport.
  • Fail-closed on status listing (prowPresubmitStatusPresent returns true on error) matches the body's claim.
  • Deviation from [scanner] 🐛 prow: post /ok-to-test once when the hive opens or pushes to a non-member fork PR #17474 on needs-ok-to-test: agreed — Prow's trigger plugin puts that label on exactly the PRs this targets, so honouring it as a skip would make the change a no-op. Treating it as Prow-managed evidence via ProwManagedLabels is the right reading; no maintainer decision needed.

Docs (hive-merge.md, runbook) and the changelog fragment describe the behaviour as implemented.

stage 095-pre-merge-soak → 074-adopted-by-hive: contributor-lane:decision-requested

Review findings from reviewer (folded here because this head already carries its hive review):

Read the diff against v5 at 65a6b4c plus the callers it reuses. Looks correct to me.

What I verified

  • automerge_contributor_prow_oktotest.go:53-85 only fires for fork PRs by non-OWNER/MEMBER/COLLABORATOR authors, after the lane has already admitted the PR (automerge_contributor_lane.go:1461-1465, inside !green and !relay). The held-runs path it shares state with (detectTrustedRegistryClankerWorkflowApprovalRequired, automerge_held_runs.go:492) returns early for fork PRs, so the two never consume the same per-head markWorkflowApprovalCommandSeen marker — no regression to the existing trusted-lane /ok-to-test post.
  • Dedupe across restarts is the existing comment-marker scan (workflowApprovalCommentState, automerge_held_runs.go:319-371); postedForHead short-circuits before any post. Prow rejection reuses markWorkflowApprovalUntrusted + workflowApprovalRejectedMarker, so the needs-human note is posted at most once per PR.
  • prowPresubmitStatusPresent (:92-125) fails closed on a list error and the already-consumed first only delays the retry by workflowApprovalRecheck, as the doc comment says.
  • c.transport.AppBotLogin() is now called without the nil guard the old postWorkflowApprovalUntrustedNote had, but every entry to the lane and sweep loop is behind ready() (automerge_sweep.go:524), which requires a non-nil transport. Not reachable; just noting I checked.
  • Tests: the table in automerge_contributor_prow_oktotest_test.go:60 includes the negative cases that matter (same-repo head, member/collaborator, ok-to-test label, non-Prow repo, Prow status already present, command already on thread, author the lane did not admit), plus once-per-head-across-restart, rejection stop, and relay read-only.

Intent vs #17474: the issue says to also skip on needs-ok-to-test; the PR skips only on ok-to-test and counts needs-ok-to-test as Prow-managed evidence. That is right — the trigger plugin puts needs-ok-to-test on exactly the untrusted-author PRs this fixes, so honouring the issue literally would make the change a no-op. The body says so; I'd keep it.

Security note (info, no change requested): this releases a non-member's code to Prow presubmits on the hive's say-so. The gate is the lane's existing admission (verified claim / registry tier) and Prow's own trusted-user check, which is already how the lane merges these PRs, so it adds no trust the lane did not already extend.

Docs (hive-merge.md, fork-pr-presubmit-stall-runbook.md) and the changelog fragment match the implemented conditions.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style/maintainability review (head 54aa27e, read with the surrounding tree at merge-base 65a6b4c).

The new path reuses the existing marker/mutation-boundary helpers cleanly and the docs + changelog match what the code does. One convention break the refactor introduced:

c.transport nil guard dropped during the postWorkflowApprovalUntrustedNote refactor (src/pkg/github/automerge/automerge_held_runs.go:221, src/pkg/github/automerge/automerge_contributor_prow_oktotest.go:72)

Engine.transport is the Transport interface (automerge_sweep.go:269), so c.transport.AppBotLogin() on a nil field is a nil-interface panic, not a "". The pre-change postWorkflowApprovalUntrustedNote guarded it (if c.transport != nil), workflowApprovalCommentState in the same file still does (automerge_held_runs.go:325-326), and the package nil-checks c.transport at ~17 other sites. Both new callers inline the unguarded call. Suggest a tiny helper and use it at both sites (and at :325 while there):

--- a/src/pkg/github/automerge/automerge_held_runs.go
+++ b/src/pkg/github/automerge/automerge_held_runs.go
@@
+// appBotLogin is the App's trimmed bot login, or "" when no transport is wired.
+func (c *Engine) appBotLogin() string {
+	if c == nil || c.transport == nil {
+		return ""
+	}
+	return strings.TrimSpace(c.transport.AppBotLogin())
+}
+
 func (c *Engine) workflowApprovalAttention(...) string {
 ...
-			c.postWorkflowApprovalUntrustedNote(ctx, displayRepo, owner, repo, number, headSHA, workflowApprovalUntrustedNote(strings.TrimSpace(c.transport.AppBotLogin()), state.rejected))
+			c.postWorkflowApprovalUntrustedNote(ctx, displayRepo, owner, repo, number, headSHA, workflowApprovalUntrustedNote(c.appBotLogin(), state.rejected))
--- a/src/pkg/github/automerge/automerge_contributor_prow_oktotest.go
+++ b/src/pkg/github/automerge/automerge_contributor_prow_oktotest.go
@@
-			c.postWorkflowApprovalUntrustedNote(ctx, displayRepo, owner, repo, number, headSHA, prowPresubmitsRejectedNote(strings.TrimSpace(c.transport.AppBotLogin())))
+			c.postWorkflowApprovalUntrustedNote(ctx, displayRepo, owner, repo, number, headSHA, prowPresubmitsRejectedNote(c.appBotLogin()))

Advisory (no change needed): prowPresubmitStatusPresent returning true on a list error (automerge_contributor_prow_oktotest.go:93) is fail-closed by design and the doc comment says so, but the name reads as a fact rather than a decision; something like prowPresubmitStatusPresentOrUnknown would spare the next reader the lookup.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether the Hive App may post /ok-to-test on behalf of admitted non-member fork authors (and whether it should become a Prow trusted user so that command takes effect), since this releases a fork's code into Prow presubmits on the hive's vouching rather than a maintainer's.

Code reads correct to me; the open point is trust policy, not a defect.

What I verified against v5 (235099b):

  • automerge_contributor_lane.go:1461-1465 — the new call sits after the lane has built the merge claim, i.e. after admission (verified marker / registry tier / adoption). The author the lane did not admit case in automerge_contributor_prow_oktotest_test.go pins that an unadmitted FIRST_TIME_CONTRIBUTOR gets no command.
  • automerge_contributor_prow_oktotest.go:68-70 — the OWNER/MEMBER/COLLABORATOR short-circuit matches Prow trigger's default trust set, so the command is only posted where Prow would otherwise never run presubmits.
  • Dedupe across the two /ok-to-test paths: postWorkflowApprovalCommand (automerge_held_runs.go:409-416) keys the mutation Claim on head_sha + digest of the command, and workflowApprovalCommentState (:319-330) finds the per-head marker on rescan — both are shared with the held-runs path, so the same head cannot be posted twice from either path, in-process or across a restart. The existing held-runs paths already exclude forks (detectActionRequiredWorkflowRuns, automerge_held_runs.go:171), so this is the only path that posts on a fork.
  • prowPresubmitStatusPresent (:95-130) fails closed on a list error (returns true → nothing posted) and attributes presubmits to the creator of the tide status; a Hive-posted status on the same head is not mistaken for one (a status from another account is not a presubmit case).
  • The needs-ok-to-test deviation from #17474 the body calls out is right: ProwManagedLabels (pr_decision_operator.go:522) counts it as Prow evidence, and skipping on it would make the feature a no-op on exactly the PRs it targets.

Small behaviour difference worth knowing, not a blocker: the held-runs path posts only when first && !state.postedForHead (automerge_held_runs.go:229), while this path posts on any scanned tick where !state.postedForHead (automerge_contributor_prow_oktotest.go:85-91). The practical effect is that a failed CreateComment is retried at the next 5‑minute rescan instead of waiting for a new head; the mutation boundary makes a successful-but-unseen post a no-op. That seems like the better behaviour here, but it is a divergence from the sibling path.

Also: both callers now dereference c.transport.AppBotLogin() without the nil guard the old postWorkflowApprovalUntrustedNote had (automerge_held_runs.go:464). The rest of the package does the same (automerge_bot_takeover.go:113, automerge_contributor_lane.go:1137), so this is consistent, just noting the guard was dropped deliberately.

Why I am routing rather than saying "looks good": /ok-to-test is the control that decides whether a non-member's fork code runs inside Prow's presubmits. Today only a human trusted user can grant that; this PR has the App grant it for anyone the contributor lane admitted. As the PR notes, Prow will reject the App until it is configured as a trusted user, so the change is inert until a maintainer makes that Prow-config decision — which is exactly the decision to make explicitly rather than inherit. I have no finding against the code itself.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @2ffea88
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @clubanderson should decide whether the Hive App may post /ok-to-test on behalf of admitted non-member fork authors (and whether it should become a Prow trusted user so that command takes effect), since this releases a fork's code into Prow presubmits on the hive's vouching rather than a maintainer's.
  • the lane reported untrusted-author-role

Head: verdict requires_human @2ffea88, 62/62 checks green, DCO yes, soak 10m0s elapsed.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed. An ordinary contributor cannot release their own PR.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

Updated 2026-11-10 02:47 UTC.

@clubanderson

Copy link
Copy Markdown
Member

/hive decision yes — the Hive App may post /ok-to-test once per head for fork PRs whose author the hive has already admitted (an admitted agent or a contributor who passed the hive's admission check), and never for arbitrary non-member forks. Scope: only when the hive opened or pushed to the branch, or the admission record exists; re-post only on a new head. Prow trust: yes, add hivecommons-hive[bot] to the Prow trusted-users/OWNERS so the command takes effect — I will make that config change separately; until then the post is harmless. Log every /ok-to-test with the admission reason so the audit trail shows who vouched.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The hive adopted this PR (stage/074-adopted-by-hive) but its head 2ffea88b525f has not moved for 3h0m and the hive has nothing it can push: adoption-stalled:contributor-lane:decision-requested.

Blocker: the review swarm asked for a human decision: @clubanderson should decide whether the Hive App may post /ok-to-test on behalf of admitted non-member fork authors (and whether it should become a Prow trusted user so that command takes effect), since this releases a fork's code into Prow presubmits on the hive's vouching rather than a maintainer's..

Moving to stage/085-needs-decision so a person sees it. This is not a merge-approval wait: the lane has not admitted this head.

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owner decision recorded above (admitted fork authors only, once per head, audit-logged). Approved.

@clubanderson

Copy link
Copy Markdown
Member

/lgtm

@clubanderson

Copy link
Copy Markdown
Member

/approve

@kubestellar-prow kubestellar-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 1f6be1cbfe22b03fcbfa28b833c6a1e5e8f61ef0

1 similar comment
@kubestellar-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 1f6be1cbfe22b03fcbfa28b833c6a1e5e8f61ef0

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2026
@kubestellar-prow
kubestellar-prow Bot merged commit 2a4153a into hivecommons:v5 Nov 10, 2026
76 of 78 checks passed
@Karibhou
Karibhou deleted the fix/prow-ok-to-test-17474 branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] 🐛 prow: post /ok-to-test once when the hive opens or pushes to a non-member fork PR

2 participants