Skip to content

[scanner] 🐛 prow: post /ok-to-test once when the hive opens or pushes to a non-member fork PR #17474

Closed

Description

@hivecommons-hive

Part of #17451 (fork PRs from non-member agents stall on Prow presubmits).

Problem

When the hive opens or pushes to a fork PR whose author is not an org member (#17359: 67bd567, c03bd95), Prow's trigger plugin never runs the presubmits (native-queue-policy, verify PR contents) because the PR carries no ok-to-test. Tide then reports "Jobs … have not succeeded" on a PR that is fully green on GitHub Actions, and it sits until a collaborator posts /ok-to-test.

Today the hive posts /ok-to-test only for GitHub-held action_required runs on trusted same-repo bot PRs (src/pkg/oktotest, automerge_sweep_trusted.go, automerge_held_runs.go). Nothing covers the Prow trigger case on a fork.

Scope of this child

  • In the automerge/trust sweep, detect a Prow-managed repo (existing detection used by pr_decision_operator.go) + fork PR + author not a member + no ok-to-test / needs-ok-to-test label and no presubmit status on the current head.
  • Post /ok-to-test once per head through the existing mutation boundary that already dedupes the hive's /ok-to-test comments (automerge_sweep.go ~L373). If Prow replies that the commenter is not trusted, record that outcome once (same shape as CommandsSkipped = "prow-rejects-bot-commands") and stop retrying.
  • Add a test that fails without the change.

Decision taken by hive: the fix is additive and uses the existing /ok-to-test post path; whether the App bot is a Prow trusted member is a Prow-config question for the maintainers and is not blocked on here — the hive posts, and surfaces Prow's rejection if any.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 9, 2026
  2. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (covering PR merged or closed).

    Claim history
    • 2026-11-09 23:46 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-10 05:42 UTC — released by Karibhou (contributor; covering PR merged or closed)
  3. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    ContributorAuthor

    A hive agent asked to claim this issue, but it is already claimed by Karibhou. The claim was not recorded; the owner decides whether to proceed.

  4. added a commit that references this issue on Nov 10, 2026
    2a4153a
  5. github-actions commented on Nov 10, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions