Skip to content

🌱 Fork PRs from non-member agents stall: Prow presubmits need /ok-to-test and bot-relayed /lgtm /approve are rejected #17451

Closed
3 of 3 issues completed

Description

@clubanderson

Observed on #17359 (stuck ~4h, otherwise fully green)

Fork PR by contributor agent @Karibhou (not an org member). All GitHub Actions checks passed, but Tide reported:

Not mergeable. Jobs native-queue-policy, verify PR contents have not succeeded.

Two independent gaps kept it from merging without a human:

  1. Prow presubmits never ran on the post-push heads. After the hive pushed 67bd567 (style follow-up) and c03bd95 (merge of v5), no native-queue-policy / verify PR contents status appeared on either commit. The PR had no ok-to-test label, so Prow's trigger plugin would not run presubmits for a non-member author. Posting /ok-to-test + /test all cleared Tide within ~90s. The dashboard surfaced this as "CI 10/11 · 'verify PR…'" with no link, because the check doesn't exist on GitHub until Prow runs it.

  2. Dashboard-relayed approvals are ineffective. The hive relayed /lgtm and /approve as hivecommons-hive[bot]; Prow replied "changing LGTM is restricted to collaborators" and "NOT APPROVED … please assign danathar" (the App is not in OWNERS). So the "approve from the dashboard" action silently failed to produce labels, and the PR sat with reviewDecision="".

Suggested fixes

  • When the hive opens or pushes to a fork PR for a non-member agent, have it (or a collaborator-token step) post /ok-to-test once, or add contributor agents to the Prow trusted org/team.
  • When the dashboard relays /lgtm//approve, post with the approving human's token (or add hivecommons-hive[bot] to OWNERS/collaborators), and surface Prow's rejection reply back to the board instead of showing "approved".
  • Have the board link the Tide status description (Jobs X, Y have not succeeded) so the missing-presubmit case is distinguishable from a failing check.

Refs: #17359, #17357

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 9, 2026
  2. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    Contributor

    PR #17455 covers this issue: #17455

    The PR body says this is partial/non-closing work (Refs/Part of or leave-open wording), so Hive will not add a closing keyword. GitHub will not show its issue-list PR icon without a closing keyword; the stage comment is the link.

  3. added
    hive/partially-addressedA merged PR addressed only part of this issue; remainder still actionable
    stage/010-actionableTriaged; eligible for the hive to pick up
    hive/verified-openHive verified that a likely/already-done claim did not finish this issue; keep open for more work
    and removed on Nov 9, 2026
  4. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    Contributor

    Verified after #17455 merged (scanner): #17455 is the runbook only; all three code fixes from the body remain open, so this is labelled hive/verified-open and split into one child per concern (each is a real GitHub sub-issue of this one):

    Adding the App to OWNERS / Prow trusted membership and posting with the approving human's token are maintainer actions and are not assigned to an agent. This issue closes when the three children do.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  5. hivecommons-hive commented on Nov 9, 2026

    @hivecommons-hive
    Contributor

    PR #17478 covers this issue: #17478

    The PR body says this is partial/non-closing work (Refs/Part of or leave-open wording), so Hive will not add a closing keyword. GitHub will not show its issue-list PR icon without a closing keyword; the stage comment is the link.

  6. hivecommons-hive commented on Nov 10, 2026

    @hivecommons-hive
    Contributor

    All children delivered: #17474 → PR #17479, #17475 → PR #17478, #17476 → PR #17480.

    Every tracked child of this issue is closed, so the hive is closing it as completed. Reopen it if something it asked for is still missing.

  7. github-actions commented on Nov 10, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/partially-addressedA merged PR addressed only part of this issue; remainder still actionablehive/verified-openHive verified that a likely/already-done claim did not finish this issue; keep open for more work

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions