Repository navigation
π± Top up v6 with v5 (durable hosted hive.yaml, shared-CI deferral naming and 118 more) - #17506
clubanderson wants to merge 121 commits into
Conversation
β¦17274) validateWorkspace cleaned workspace_path and compared it to workspace_roots as a string prefix, then os.Stat followed symlinks. A link under a root (<root>/x -> /), which a previous run can plant in its read-write workspace, passed the check and the backend mounted its target read-write. The path is now resolved with filepath.EvalSymlinks and the resolved form is checked against the resolved roots (so a root reached through a link still works); a path resolving outside is refused 403. The run mounts and records the resolved directory, so the backend never follows a link the check did not see. Fixes #17029 Hive-Run: #17029 Hive-Plan: review-backlog/security Hive-Spec: crux-runs#workspace-roots Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.205.0 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.205.0
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.206.0 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.206.0
* π crux: confine agentstep workspace file access with os.Root agentstep read and wrote step files on the host with plain os calls after only a lexical '..' check, so a symlink in the workspace (carried by a provisioned repo, or planted by the sandboxed agent for answer files) redirected host-side reads/writes as the serve uid. All prompt_path reads, prompt writes and answer reads now go through an os.Root opened on the workspace, as review_request_sandbox_spool.go and runs.validateWorkspace do. Closes #17293 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π crux: create .crux parent before symlinking steps dir in agentstep test TestSymlinkedCruxDirCannotRedirectThePromptWrite symlinked .crux/steps without creating .crux first, so os.Symlink failed with ENOENT before the assertion ran. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.206.1 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.206.1
) * π hold guard: log deferred base refresh at debug instead of WARN Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π hold guard: scope base-refresh deferral to behind so dirty held PRs keep their conflict notice Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦hs beside a conflict (#17304) Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.206.2 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.206.2
β¦7305) * π contribute: convert a PR-covered contributor claim instead of releasing it on lease revoke Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π api-reference: refresh claims_api.go citations after lease-revoke change Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π contribute: hold the claim from the verified task_complete PR, not the scan ledger Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.206.3 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.206.3
β¦uest (#17306) * β¨ hive-open-issue: --claim files and claims a self-filed issue in one request Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π± test: decode the bare label array go-github posts in the create-claim fake Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * fix: route the --claim help-wanted strip through the shared blocked-sweep helper TestDirectWriteRatchet failed on CI: the --claim path added an eighth wrapper write (RemoveLabel) to issue_request_watcher.go, whose baseline is 7 and may never be raised. Generalize the blocked sweep's stripBlockedHelpWanted into stripHelpWanted in issue_blocked.go (where that removal is already baselined) and call it from claimCreatedIssue, so the watcher file gains no new direct write and the single help-wanted removal the claim test asserts still happens. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π hive-open-issue: refuse the filer on hub dispatch, bind the marker to the filer, ledger the --claim Review findings on #17306 (#17299): - The hub's own scanner dispatch (installClaimAdmissionCheck) still called the agent-less IssueDispatchBlockReason, so an issue a lane filed without --claim was handed back to that lane β the #17243β#17250 shape. A KindAgent request now goes through IssueStartBlockReason with req.Holder (the agent name), and a test asserts the filer's dispatch is refused with ClaimBlockReasonFiledForHelpPrefix while another agent is admitted. - withFiledForHelpMarker left a body alone when it already carried any marker, so a filer could seed `<!-- hive:filed-for-help other -->` and never be bound. Any pre-existing marker is now dropped before the filer's own is appended; tested with a seeded foreign marker, and the agent name is validated against a named pattern instead of round-tripping through the marker regex. - claimCreatedIssue applied the labels and facts but never raised the agent start signal, so the hub's claim ledger was not written for a --claim create. It now fires AgentStartSignalClaim like a `claim` request; the create-claim test records the hook and asserts one call for #99. - Docs: the filed-for-help refusal sentence sits beside the other `claim` refusals; the filing section notes the dispatch refusal, marker replacement and ledger signal. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π hive-open-issue: ledger the --claim via a filed-claim start signal the hub lists A self-filed issue was never in a kick, so the plain `claim` start signal the create+claim path raised went through ClaimOnStart with started=false and the hub's ledger never recorded the claim: dispatch admission Lookup, the PR-request gate and the claim listing all saw it unclaimed. The create path now raises AgentStartSignalFiledClaim; recordAgentStart treats that signal as the issue's own listing (MarkListed, then ClaimOnStart through the normal admission check). Ledger-backed test in cmd/hive. Hive-Fix-Attempt: 2/6 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π± hive-open-issue: document the --claim allowlist exception, share the help-wanted strip, keep the marker off fold comments The write-surface catalogue said same-path side effects ride the parent operation's allowlist entry, but the claim performed on --claim is gated on its own claim allowlist and audited as agent_issue_claimed; the create_issue row and the side-effects paragraph now say so, and the hive-open-issue doc names the allowlist requirement. The --blocked-on-pr comment path removed help wanted directly, so stripHelpWanted's single-call-site claim was false; it now goes through the helper. The filed-for-help marker was appended before consolidation and so landed in file-set, component and subject fold comments on someone else's issue, where nothing reads it. The fold renderers strip it. Hive-Fix-Attempt: 3/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π hive-open-issue: exempt --parent children from the filed-for-help marker, collapse blank lines only on strip Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
β¦er author (#17303) * π pr-request: refuse Fixes/Closes targets claimed or covered by another author A PR request could close an issue a contributor had claimed and covered with their own open PR (#17243: #17250 superseded #17248). The watcher now checks each closing reference before booking a start: a live claim by another principal, or an open covering PR by an author outside the hive, rejects the request (gate claim) and posts one marker-deduplicated notice on the issue. A failed lookup fails closed. Closes #17298 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π pr-request: own-claim exemption checks claim kind and hive; scope claim notice to served repos Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π± test: cover the closed-covering-PR release and the forge-assignee claim read Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π issue-request: run the claim-target gate on the start path before notifyAgentStart Review of #17303 (intent-alignment): #17298's acceptance criteria require the kick/start path to run the claim/coverage check before a start is booked, but only the PR-open leg was gated. A claim or a start-announcing relay comment on an issue another principal has claimed, or covered with an open PR, now goes through the same prRequestTargetBlock before any write and before notifyAgentStart: refused with a policy reason and the deduplicated notice, retried on a lookup error (fail closed). The retry path is extracted into failIssueRequest so both callers share it. Hive-Fix-Attempt: 1/6 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π pr-request: name the refused action in the claim-target notice The notice posted on a refused target issue hard-coded "asked to open a pull request ... No PR was opened", so a refused `hive-open-issue claim` or start comment described an event that never happened. Thread the action (open-pr / claim / start) into the notice body, assert the start-path wording in TestIssueRequestStart_RefusesContributorClaimedTarget, and document the new refusal reason in the hive-open-issue `claim` section. Hive-Fix-Attempt: 2/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π± test: serve the comments list in the in-progress relay fixture With issue claims on, the start-path claim-target gate reads the forge marker from the issue's comments before applying the claim; the fixture 404'd that read, so the gate failed closed and TestIssueRequestWatcher_ClaimLeavesCommentToLedgerWhenClaimsOn lost its ownership label. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π pr-request: claim-target gate rejects a missing target and skips pull requests With issue claims on, a closing reference to a nonexistent issue 404ed in prRequestTargetClaim and came back as a plain error, so the request was failed and retried until the horizon quarantined it; before #17298 the same request was permanently rejected with the cross-repo hint. The 404 is now mapped to that policy error in validatePRRequestTargets. The start-comment gate also fetched PRs via Issues.Get and inferred a claim from assignees, refusing a hive start comment on a contributor- assigned PR. A target that is a pull request now passes the gate. Docs: name the dispatch-block gate explicitly where the inserted claim-target paragraph left 'the same gate' ambiguous. Hive-Fix-Attempt: 3/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.207.0 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.207.0
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.207.1 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.207.1
β¦17321) The scheduler's injection-cap WARN is the operator-side notice that a repository's AGENTS.md outgrew the cap (#12129): repo content, the cap working as designed, not a hive defect. Every kick re-logs it, so one oversized repo crossed the repeat threshold and was filed as an unclassified error (#17318). Exempt the exact message from the feed; 'agentsmd: parse failed, skipping injection' stays reportable. The warning also printed cap_bytes=0, the config 'use default' sentinel. Log the effective cap instead. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
β¦ash (#17323) * π watchdog: stop paging PaneShowsLogin on a relaunched CLI's login flash A Copilot CLI relaunched mid-life (kick restart, memory-drain recycle, watchdog restart) paints login chrome for ~0.5s while it re-validates its token. Classify dated boot grace from the agent's original StartedAt, so a 22h-old agent got no grace and a single sighting flipped Authenticated=False/PaneShowsLogin and paged the operator. - Observation.LastLaunchAt records the most recent CLI spawn (markCLILaunchedLocked); boot grace uses the later of StartedAt and it. - ApplyLoginStreak holds auth-required back until login chrome has been seen on Settings.LoginStreak consecutive polls (liveness.login_streak, default 3), mirroring the pane poller's loginStreak guard. Below the threshold the pane is unknown with reason 'login chrome seen 1/3 polls'. Fixes #17320 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * test: add Liveness.LoginStreak to the agent-runtime config golden Signed-off-by: Andrew Anderson <andy@clubanderson.com> * dashboard: reference governor.watchdog.liveness.login_streak in the Watchdog settings help Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦7326) The popover opened from the Merged pill was capped at 34rem, so every PR title ellipsised at ~40 characters. Set it to 52rem, capped to the viewport and to the sticky bar that clips it (it is right-anchored under the pill and grows leftward). The title column is the grid's only flexible track, so the width goes to titles; the by/lane/time meta column keeps its natural nowrap width. The merge-queue popover keeps its old 22β34rem sizing and the β€720px phone sheet is a separate dialog and is unchanged. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
#17325) A PR closing two issues is drawn once, under the lower issue; the other issue chips to it. Its row fell back to the issue's own 030/040 stage for the lane while the merge-gate word still came from the PR, so #17302 read "Soaking Β· 47s left" in the PR in progress lane while #17292 soaked in the Merge queue. stageTrackerLinkedRiding picks the furthest covering PR drawn elsewhere and the row, column map and sort order ride its stage; the PR column stays empty and the "under #M" chip still names the PR. Fixes #17324 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.207.2 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.207.2
#17331) * π contributor nudge: per-PR CI-failure cooldown and failing-set dedupe CI-failure nudges are keyed on the failing-check set rather than the lane's reason prefix. The same set on a new head, or a check joining the set on the same head, edits the PR's one nudge comment (marker gains checks=<digest> attempt=<n>; no relay re-dispatch for the same head). A changed set on a new head within governor.labels.stage.contributor_nudge.ci_failure_cooldown (default 6h) is folded into the comment instead of counting as a fresh nudge. The ledger persists in the stage-label store across restarts. Fixes #17328 Signed-off-by: Andrew Anderson <andy@clubanderson.com> * test(config): golden gains contributor_nudge.ci_failure_cooldown Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>
β¦stage instead of forcing needs-decision (#17334) Sentinel alerts and hold-class labels are gates, not stages (owner decision 2026-11-08). The stage engine now routes a gated PR by its head's evidence like any other human hand-off β CI / 070 while checks run or fail, 071 on a reviewer question, 090-ready-for-human-merge when the head is otherwise clean β and keeps the gate reason on the route so the entry comment reads "Held: a sentinel alert is open on this PR. The hive never merges this head while the gate stands." and the dashboard popover still explains the stop. The gate remains a hard merge stop: the automerge lanes and the dashboard's delegated human-merge shortcuts refuse on the label itself, never on the stage number (tests pin a 090 PR with a sentinel alert or hold refused by the contributor, self-authored and trusted-author prefilters and by the dashboard's human-merge decision/outcome paths). Dashboard: a held 090 row's Merge queue cell reads "Held Β· sentinel Β· confirm intent" / "Held Β· hold" (amber ham-held, tooltip with the gate's reason, the route reason and the rule), never "Queued for merge"; the sentinel question's Approve / Let hive decide / direction / close actions stay available from that cell. needs-human keeps parking at 085. Fixes #17327 Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.207.3 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
* π fix(hub): make /etc/hive/hive.yaml durable on hosted spokes and report the persisted config path Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> * π docs(config): reconcile config-layering with the #17468 symlink and pin Save() in-place write Review follow-ups for #17471: - config-layering.md: the 'On Kubernetes' paragraph still said the entrypoint copies the runtime config over the config path; it now covers the linked steady state and the unlinked cases. The #17468 block moved below the 'Outside Kubernetes' paragraph so that paragraph keeps its subject, which is now also named explicitly. - config.go: comment at the Save() write site explaining that the in-place O_WRONLY|O_TRUNC write (not temp-file+rename) is what keeps the hosted-spoke symlink intact, and TestSaveThroughSymlinkKeepsLink pinning it. - config.go: refresh the pre-#2402 'recovery copy' / 're-seeds on every boot' comments on the runtime write and DashboardOverlayFile. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> * π docs(config): scope /etc/hive/hive.yaml durability to re-provisioned spokes and add the boot-line verification step Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> --------- Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com> # Conflicts: # .github/scripts/integration-governance.cjs # CHANGELOG.md # bin/hive-open-issue.sh # bin/test_hive_open_issue.sh # discord/package-lock.json # discord/package.json # src/cmd/hive/github_client_config.go # src/cmd/hive/main_helpers.go # src/crux/agent/manager_launch.go # src/docs/api-reference/auth.md # src/docs/api-reference/dashboard-misc.md # src/docs/api-reference/health-status-events.md # src/docs/api-reference/hub-server.md # src/docs/api-reference/snapshots-and-style.md # src/docs/dashboard-sections/activity-monitor.md # src/docs/github-app-setup.md # src/docs/github-write-surface.md # src/docs/hive-open-issue.md # src/docs/labels-and-control-signals/glossary-and-operations.md # src/docs/labels-and-control-signals/reference.md # src/docs/labels-and-control-signals/stage-labels.md # src/docs/scale-envelope.md # src/pkg/config/config.go # src/pkg/dashboard/contribute_ws.go # src/pkg/dashboard/static-src/js/config-state.js # src/pkg/dashboard/static-src/js/tracker-actions.js # src/pkg/dashboard/static-src/js/tracker-row-render.js # src/pkg/dashboard/static/index.html # src/pkg/fleetreport/runtime.go # src/pkg/fleetreport/runtime_test.go # src/pkg/github/app.go # src/pkg/github/automerge/automerge_contributor_lane.go # src/pkg/github/automerge/automerge_stage_human.go # src/pkg/github/automerge/automerge_sweep_loop.go # src/pkg/github/issue_blocked.go # src/pkg/stageengine/derive_pr_classify.go
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. hive/awaiting-ci: CI red at
Reminder from the body: land with π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Merge resolution verified; one fix needed before this is green: the api-reference citation guard. What I checked. Re-ran
The red that is this PR's to fix β and commit the result on this branch. Expected reds, not findings. I have not approved or changed anything; the merge is a maintainer's call ( Review findings from Security perspective, read at head
Review findings from Correctness review @ 6c03b7b β the merge is mechanically clean but it regresses three Go test packages that are green on the 1.
|
6c03b7b
βΉοΈ Sentinel notice β informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @clubanderson, head
Hive did not add the |
There was a problem hiding this comment.
Conclusion: the merge resolution is careful and the body documents it well, but the head is red for reasons the body does not cover: two semantic conflicts between v5 and v6 that no textual conflict surfaced, plus docs-citation drift. Both parents are green (v2 Tests on v6 19fdfa238 and v5 235099b00 both pass), so these are introduced by the merge, not pre-existing.
1. v6 tests expect hold/sentinel to park at 085; the carried v5 rule (#17334) routes them to 090/071
src/pkg/stageengine/derive_pr_classify.go:319 (stageHeldGateReasons) and the branch at :489 come from v5 #17334: label:hold, sentinel, and contributorLaneReasonSentinelBlocked are now gates riding the head's real stage as a pill, no longer stageNeedsHumanReasons. The body says this side was chosen deliberately ("v5 held-gate block + v6 linked-issue guard").
v6 has three tests that encode the old rule and exist only on v6 (never on v5, so #17334 never had to reconcile them):
src/pkg/github/automerge/automerge_stage_human_manual_merge_test.go:99TestManualMergeNamedWhileHoldLabelBlocksβ reasonlabel:holdβ helper assertsstagelabels.NeedsDecisionat:41-42; CI:stage=090-ready-for-human-merge want 085β¦manual_merge_test.go:112TestManualMergeNotClaimedWithoutWorkflowFence(both subtests) β reasonsentinel-blockedwith a clean/unreadable diff; CI:stage=071-needs-author want 085(therequires_humanverdict now wins viaVerdictBlocksatderive_pr_classify.go:502)src/pkg/github/automerge/automerge_workflow_fence_scope_test.go:260TestWorkflowFenceScopeStageNoteAgreesWithLane/unlisted_workflowβ same mechanism,:266
These came in via #14215 / #15026 / #17484 (v6-only manual-merge-note work). Since the PR body already adopts the #17334 semantics for v6, the consistent fix is to update these three tests to the new routing (090 with the gate as a pill, 071 when the verdict blocks) and to check that the "a maintainer must review and merge this PR manually" wording they assert still applies when the hold is a pill rather than the stage. If instead v6 should keep 085 for hold/sentinel, stageHeldGateReasons should not be carried β but that contradicts the owner rule cited in the comment at :310-318, so I would not pick that silently.
2. TestLanePoliciesParkOwnerOnlyHandOffs fails on the new v5 policy file
src/pkg/policies/defaults/redteam-holdgated.md is new from v5 #17421. The guard src/pkg/policies/needs_decision_filing_test.go:52 (TestLanePoliciesParkOwnerOnlyHandOffs) is v6-only and requires every relay-commenting policy to contain the **Park an existing issue when only the owner can finish it.** rule, the hive-open-issue comment β¦ --needs-decision command, the typed release flags, and -R <owner/repo> on owner gh commands (:60-63, :97-103). The file has none of them. quality-holdgated.md:332 carries the exact block to copy.
3. 94 drifted api-reference citations
changelog-fragment-guard and Docs Link Check both fail on api-reference citations: 94 drifted citation(s) (e.g. hub-server.md:49-66 β pkg/hub/server.go:1742-1799, snapshots-and-style.md:9). The body says the api-reference files were resolved to "v6 (current line numbers)", but the v5 hunks merged into pkg/hub/server.go / pkg/dashboard/server.go shifted them. python3 src/scripts/check-docs-citations.py --fix per AGENTS.md.
Verified clean
- All 90 non-merge carried commits and the merge commit
6c03b7bf7carrySigned-off-by; theDCO: action_requiredbehindnative-queue-policyis the app's state on a 120-commit push, as the body anticipates. .github/scripts/integration-governance.cjs:12TRUSTED_SCRIPTS_TREE=46dfc95aβ¦matchesgit rev-parse HEAD:src/scriptson this head..github/workflowschanges (10 files) are carried v5 commits, not new edits in this PR.
The body's "targeted tests β¦ green" covered stageengine but not pkg/github/automerge or pkg/policies, which is where both semantic conflicts live. Flagging for @clubanderson as author; I have not changed anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Addendum to the review above (same root cause as its Β§1, one more site it did not list, from
v6 π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Superseded by #17570, which rebuilds this top-up on today's |
Forward-merge of
origin/v5intov6(120 commits). Plain--no-ffmerge commit β merge with--merge, not squash, so the v5 history is carried.Commits carried
Conflict resolution (36 files)
discord/package.json,discord/package-lock.jsonsrc/cmd/hive/github_client_config.goSetAdvisoryDigestMinIntervalsrc/cmd/hive/main_helpers.goIsBaseRefreshAwaitingAdmissiondeferral ahead of v6ClassifyBranchUpdateErrorswitch; a dirty held PR on a deferral still routes toUpdateStopConflictso the conflict notice posts (v5TestMaintainHeldPRMergeabilityStillNotesConflictWhenBaseRefreshIsScheduledgreen)src/crux/agent/manager_launch.goclearStaleModelRejectionLocked+ v5markCLILaunchedLockedsrc/pkg/github/app.gospektacular-read(v6) +agentmode.SecCheckTier(v5)src/pkg/github/issue_blocked.gostripHelpWanted+ v6liftBlockedMarkerlessdocsrc/pkg/fleetreport/runtime.go,_test.goClassAgentGitHubCapReached+ClassCopilotCLIHung)src/pkg/dashboard/contribute_ws.gorecordCompletionPRClaimearly), v6completeImplementStage/releaseImplementStageUnverifiedinside the completion blockautomerge_contributor_lane.go,automerge_sweep_loop.goc.mergeTrainEvalContext(mergeDecisionPriority(ctx), train, number)β v5 helper wrapped with v6 priorityautomerge_stage_human.goreadyEntryCause+ v5 condition with v6&& !headBoundguardsrc/pkg/stageengine/derive_pr_classify.gostageNeedsHumanReasons= v5 set + v6contributorLaneReasonReviewOff; v5 held-gate block + v6 linked-issue guardsrc/pkg/config/config.goSaveSeqβconfig.go,DigestMinIntervalβadvisory_config.go,CIFailureCooldownβgovernor_config.go,ResolvedConfigPath/PersistedConfigPath/saveSeq.Addβsave.gostatic-src/js/config-state.js,tracker-actions.js,tracker-row-render.jsbin/hive-open-issue.sh,bin/test_hive_open_issue.sh--claim);CLAIM_ON_CREATEis python argv[24]src/docs/api-reference/*.md,scale-envelope.md/api/heartbeatdescription kept inhub-server.mdgithub-app-setup.md,github-write-surface.md,hive-open-issue.md,glossary-and-operations.md,reference.md,activity-monitor.md,stage-labels.mdCHANGELOG.mdsrc/pkg/dashboard/static/index.htmlmake dashboard-gen(dashboard-gen-checkpasses).github/scripts/integration-governance.cjsTRUSTED_SCRIPTS_TREEre-pinned to46dfc95a63a98448be26aceb92c8289c205776c2(=git rev-parse HEAD:src/scripts)Checks
go build ./...,go vet, targeted tests for config/github/stageengine/fleetreport/crux-agent/cmd-hive/webstatic: green except the pre-existing macOS/var-symlink memory-drain tests.bin/test_hive_open_issue.sh: 71 PASS then the pre-existingurlbotexit on macOS bash (same on clean v6).native-queue-policyreds expected on a top-up (carried v5 commits).