Repository navigation
π dashboard: settled-current stage chevron keeps its neutral fill while CI runs - #17462
Conversation
β¦le CI runs While a CI / Review track runs, the stage chevron renders settled-current (filled but still, icon only). The Open-column word tints (draft slate, blocked yellow, New blue, stale amber-red) and the held-gate amber were declared later in tracker.css at equal specificity, so they repainted the settled chevron and the row showed two coloured chevrons β hive's own #17329, a draft PR with no stage, read as slate Open + amber CI 51/64. One higher-specificity settled-current rule after the tints restores the neutral fill; the draft class stays for the tooltip. Node test covers the rendered classes and the CSS ordering/specificity. Fixes #17461 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
/lgtm |
|
@clubanderson: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clubanderson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at dd5d263. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Summary
Hive's own PR #17329 (draft, no stage yet, CI 51/64 running) showed two coloured chevrons in the Activity Monitor: amber CI 51/64 Β· 12 running and a slate-filled Open.
The JS is right β Open renders
active ham-settled-current ham-open-draft, icon only. But.ham-seg.active.ham-open-draft(and-blocked,-new,-stale,.ham-held) are declared after.ham-seg.active.ham-settled-currentat equal specificity, so their tint repainted the neutral settled fill. For a stale Open row that would be an amber-red second chevron next to running CI.Change
tracker.css: one higher-specificity.ham-seg.ham-seg.active.ham-settled-currentrule after the Open tints restoresvar(--surface-3); the draft class stays for the tooltip.stage_tracker_remediation_chevron.test.js: a draft Open PR with running CI renders settled-current Open, icon only, exactly one lit chevron; asserts every Open tint rule precedes the override and has lower specificity (fails onv5without the CSS change).activity-monitor.mdrule 2 names the invariant;index.htmlregenerated; changelog fragment.Row order (not changed)
The row's bottom placement is per the documented sort: the stage engine gives a draft PR no stage (
derive_pr_classify.go), so it sits in the Open column (last under furthest along) and draft/hold sink it to the last tier within that column β not the missing linked issue, the waiting-on login or the v6 base.Fixes #17461