Skip to content

πŸ› dashboard: settled-current stage chevron keeps its neutral fill while CI runs - #17462

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/settled-open-chevron-tint
Nov 9, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/settled-open-chevron-tint

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

Hive's own PR #17329 (draft, no stage yet, CI 51/64 running) showed two coloured chevrons in the Activity Monitor: amber CI 51/64 Β· 12 running and a slate-filled Open.

The JS is right β€” Open renders active ham-settled-current ham-open-draft, icon only. But .ham-seg.active.ham-open-draft (and -blocked, -new, -stale, .ham-held) are declared after .ham-seg.active.ham-settled-current at equal specificity, so their tint repainted the neutral settled fill. For a stale Open row that would be an amber-red second chevron next to running CI.

Change

  • tracker.css: one higher-specificity .ham-seg.ham-seg.active.ham-settled-current rule after the Open tints restores var(--surface-3); the draft class stays for the tooltip.
  • stage_tracker_remediation_chevron.test.js: a draft Open PR with running CI renders settled-current Open, icon only, exactly one lit chevron; asserts every Open tint rule precedes the override and has lower specificity (fails on v5 without the CSS change).
  • activity-monitor.md rule 2 names the invariant; index.html regenerated; changelog fragment.

Row order (not changed)

The row's bottom placement is per the documented sort: the stage engine gives a draft PR no stage (derive_pr_classify.go), so it sits in the Open column (last under furthest along) and draft/hold sink it to the last tier within that column β€” not the missing linked issue, the waiting-on login or the v6 base.

Fixes #17461

…le CI runs

While a CI / Review track runs, the stage chevron renders settled-current
(filled but still, icon only). The Open-column word tints (draft slate,
blocked yellow, New blue, stale amber-red) and the held-gate amber were
declared later in tracker.css at equal specificity, so they repainted the
settled chevron and the row showed two coloured chevrons β€” hive's own
#17329, a draft PR with no stage, read as slate Open + amber CI 51/64.

One higher-specificity settled-current rule after the tints restores the
neutral fill; the draft class stays for the tooltip. Node test covers the
rendered classes and the CSS ordering/specificity.

Fixes #17461

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 9, 2026
@clubanderson

Copy link
Copy Markdown
Member Author

/lgtm
/approve

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 9, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#17444 πŸ› fix(automerge): hold same-issue PRs only at the merge gate and keep the pick same files src/docs/dashboard-sections/activity-monitor.md
#17457 πŸ› activity monitor: light a needs-decision PR's real stage and carry the ask as a pill same files src/docs/dashboard-sections/activity-monitor.md
src/pkg/dashboard/static-src/css/tracker.css
src/pkg/dashboard/static/index.html

@hivecommons-hive
hivecommons-hive Bot merged commit 758e442 into v5 Nov 9, 2026
84 of 91 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/settled-open-chevron-tint branch November 9, 2026 22:31
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#17462dd5d263` sha256:965a8c0efc63100305a9a7112548fe1532e030ae62ee545454bcfd6ce158d778 β€” download from the dashboard or `hivectl review evidence #17462`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at dd5d263.

@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Activity Monitor: Open-column tint overrides the settled-current fill while CI runs

1 participant