Skip to content

[shared-ci] test (rest 3/4) failing across hivecommons/hive #17228

Closed

Description

@hivecommons-hive

Shared CI incident — not a PR fault

Since 2026-11-08T12:00Z the test (rest 3/4) shard (and therefore the test / coverage aggregates) fails on every branch carrying src/pkg/github/close_on_merge_ledger_sweep_test.go, including the default branch v5 and v6.

Evidence

Root cause (time bomb, not a regression)

The test reloads the ledger with LoadClaimLedger(ledger.path, nil) and only then calls SetClock. loadClaimLedgerAt prunes settled claims past settledClaimRetention (30d) during load, against the wall clock. The fixture's claims settle at 2026-10-09T12:00Z, so at 2026-11-08T12:00Z every claim is dropped on reload and the fourth sweep sees an empty ledger.

Fix

Reload with loadClaimLedgerAt(path, nil, func() time.Time { return now }), the pattern prclaims_settled_test.go already uses. Fix PRs: one against v5, one against v6 (the v5→v6 forward-merge #17025 is conflicting and needs-human, so v6 needs its own).

Affected PRs are deferred to this incident until the fix lands; do not repair them individually.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    agent/scannerCreated or modified by the scanner agent
    ciApproved by a Hive merger/owner for auto-merge on green CI
    on Nov 8, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 8, 2026
  3. hivecommons-hive commented on Nov 8, 2026

    @hivecommons-hive
    ContributorAuthor

    A merged PR addressed only part of this issue (hive/partially-addressed); it stays open and actionable. Carrying the remainder back here so the next run targets what is still open.

    Not yet touched: prclaims_settled_test.go

    Remainder from the PR body:

    (v6 counterpart of the v5 fix; the issue closes with the v5 PR)

    This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.

  4. added
    hive/partially-addressedA merged PR addressed only part of this issue; remainder still actionable
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed on Nov 8, 2026
  5. hivecommons-hive commented on Nov 8, 2026

    @hivecommons-hive
    ContributorAuthor

    Verified resolved — closing the incident.

    The task-list sweep's "not yet touched: prclaims_settled_test.go" remainder is a false positive — that file was cited as the reference pattern the fix copies (it already used loadClaimLedgerAt at lines 289/372/384), not as a file needing changes. Nothing is left open; PRs deferred to this incident (#17151, #17234) can be re-evaluated.

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agentciApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/partially-addressedA merged PR addressed only part of this issue; remainder still actionable

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions