You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[shared-ci] test (rest 3/4) failing across hivecommons/hive #17228
Since 2026-11-08T12:00Z the test (rest 3/4) shard (and therefore the test / coverage aggregates) fails on every branch carrying src/pkg/github/close_on_merge_ledger_sweep_test.go, including the default branch v5 and v6.
Evidence
v5 push run 42480676503 (head 58f593d, 12:31Z): --- FAIL: TestCloseOnMergeLedgerSweepSettledClaimsSkipAPI on all three retries, FAIL github.com/hivecommons/hive/pkg/github.
Every earlier run of the same shard was green (v6 v2 Tests at 03:33Z on 1395c42 passed).
Root cause (time bomb, not a regression)
The test reloads the ledger with LoadClaimLedger(ledger.path, nil) and only then calls SetClock. loadClaimLedgerAt prunes settled claims past settledClaimRetention (30d) during load, against the wall clock. The fixture's claims settle at 2026-10-09T12:00Z, so at 2026-11-08T12:00Z every claim is dropped on reload and the fourth sweep sees an empty ledger.
Fix
Reload with loadClaimLedgerAt(path, nil, func() time.Time { return now }), the pattern prclaims_settled_test.go already uses. Fix PRs: one against v5, one against v6 (the v5→v6 forward-merge #17025 is conflicting and needs-human, so v6 needs its own).
Affected PRs are deferred to this incident until the fix lands; do not repair them individually.
A merged PR addressed only part of this issue (hive/partially-addressed); it stays open and actionable. Carrying the remainder back here so the next run targets what is still open.
The task-list sweep's "not yet touched: prclaims_settled_test.go" remainder is a false positive — that file was cited as the reference pattern the fix copies (it already used loadClaimLedgerAt at lines 289/372/384), not as a file needing changes. Nothing is left open; PRs deferred to this incident (#17151, #17234) can be re-evaluated.
Activity
hivecommons-hive commentedon Nov 8, 2026
A merged PR addressed only part of this issue (
hive/partially-addressed); it stays open and actionable. Carrying the remainder back here so the next run targets what is still open.Not yet touched:
prclaims_settled_test.goRemainder from the PR body:
(v6 counterpart of the v5 fix; the issue closes with the v5 PR)
This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.
hivecommons-hive commentedon Nov 8, 2026
Verified resolved — closing the incident.
loadClaimLedgerAt(ledger.path, nil, func() time.Time { return now }),close_on_merge_ledger_sweep_test.go:184) landed via 🐛 fix: unclaimed proposal / kind/design issues derive stage/018-open-for-discussion #17220;v2 Testson the v5 push atbf4b8e7(13:19Z) is success. 🌱 test: load the reloaded sweep ledger with the test clock #17229 was closed as superseded by it.v2 Testson the v6 push at70a9203(13:40Z) is success.The task-list sweep's "not yet touched:
prclaims_settled_test.go" remainder is a false positive — that file was cited as the reference pattern the fix copies (it already usedloadClaimLedgerAtat lines 289/372/384), not as a file needing changes. Nothing is left open; PRs deferred to this incident (#17151, #17234) can be re-evaluated.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88