Repository navigation
✨ review backlog: min_severity floor, per-PR lifetime cap, collapse same-family findings - #17072
Conversation
…e-family findings Findings below review.backlog.min_severity (default P2) are no longer filed as backlog issues; they are appended to one upserted hive:review-followups comment on the PR. The issue cap is now review.backlog.max_per_pr (default 3) over the PR's lifetime, persisted in the review-backlog ledger, instead of per UTC day (max_per_pr_per_day is read as a retired alias). New findings from one pass that share a perspective and scope are filed as a single checklist item. Operators who want every finding filed as before set min_severity: P3. Fixes #17065 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. Another agent tried to open a PR from |
…nt notes Signed-off-by: Andrew Anderson <andy@clubanderson.com>
TestSettingsDialogReferencesEveryHiveYAMLLeaf requires every hive.yaml leaf to have a Settings control. Add a min_severity select and a lifetime max_per_pr input next to the retired per-day cap, accept both on PUT /api/config/review, and cover them in the 11088 settings test. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Fixes #17065
Why
Read-only audit (2026-11-07):
[reviewer] Review backlogissues run at ~160/week ≈ 40% of all issues in this repo (0.28 per PR), virtually all auto-closed within ~1h by a hive fix PR. Examples: #17027 and #17028 (two P3 docs-currency issues from one PR, #17025), #16944, #16961, #16857.What
review.backlog.min_severity(defaultP2). Findings below it are never filed. They are appended to one upserted<!-- hive:review-followups-comment v1 -->comment on the PR viaEditIssueMarkerComment, so nothing is lost: ticked task lines stay ticked, re-reported nits are not listed twice, new nits are appended. Docs-currency findings are P3 → follow-ups.min_severity: P3restores filing every finding.review.backlog.max_per_pr(default 3) replaces the per-UTC-day cap; the count is persisted in the review-backlog ledger (pr_item_countin/data/review-backlog-issues.json, the file that already holds claims/fingerprints).max_per_pr_per_dayis kept as a retired alias for the size (dashboard still references it; untouched). Still-present notes no longer spend the cap (they are already bounded once per head).[reviewer] Review backlog (<perspective>): <repo>#<pr> — N follow-upswith a checklist body; every fingerprint maps to that one item so cross-PR dedupe keeps working. A single new finding keeps the per-finding title.createIssueruns every title throughissueshape.AgentIssueTitle, which prepends[reviewer], so a literal[review-backlog]prefix would double-tag. Kept theReview backlog (<perspective>):lead that title canonicalisation / fold matching depend on.operator-reference/README.md,review-swarm.md(config block, table, Backlog routing bullets),work-sources.md; changelog fragment.Tests
Table-driven, no
time.Sleep:ReviewFindingBelowMinSeverity,groupReviewBacklogPending,renderReviewFollowUpsComment(fresh / merge keeps ticked / dedupe / truncation), end-to-end hold → one comment → edit-in-place on second head acrossmin_severityP2/P3/P1,TestReviewBacklogPRCap, configEffectiveMaxPerPR/EffectiveMinSeverity/Validate. Existing routing tests pinMinSeverity: "P3"to keep exercising the file-everything path.Expected reduction
~28/week docs-currency (all P3) → 0 issues; the remaining P3 nits move to the follow-ups comment; the lifetime cap + collapse bound the P2 remainder per PR. Estimate 160 → ~30–50 issues/week (−70–80%).