Repository navigation
π fix(automerge): upsert contributor-nudge comments once per PR + reason instead of reposting per head - #17088
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
β¦son instead of reposting per head Refs #17067 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
Why
Automerge marker comments were keyed per head SHA, so every push to a PR added another copy. On #16524 that produced 8Γ
hive:signoff-attributionand 5Γhive:unauthorized, and the stage-072 contributor nudge rebounded to 34 comments a day.#17066 (signoff-attribution and unauthorized upsert) already landed on v5 in #17071 (d6c63af). That PR added the shared
automerge_marker_upsert.gohelpers (findOwnMarkerComment/editMarkerComment). This PR reuses those helpers for the remaining emitter: the contributor nudge, section 1 of #17067.What changed
hive:contributor-nudgeonce per PR + reason.<!-- hive:contributor-nudge reason=<slug> head=β¦ n=β¦ mode=β¦ since=β¦ repeat=β¦ -->.reason=, are adopted and rewritten in place.auto_merge.nudge_repeat_after(duration, default72h).repeat=1), then only edits from then on.fix-prdispatchMarkNudgedconfig.go(field, default, andEffectiveNudgeRepeatAfter),StageLabelPolicy.NudgeRepeatAfter,merge_eligibility.gowiring.automerge_contributor_nudge_test.go(each fails without this change):nudge_repeat_afterchangelog.d/changed-upsert-signoff-unauthorized-nudge.md.The raw
CreateCommentcount inautomerge_contributor_nudge.gostays at the write-back baseline of 1, because edits go through the gatededitMarkerComment.Follow-ups (not converted here; per-head emitters still worth auditing)
hive:human-071-note(normal mode)contributor-held-runs-approvedReferences
#17066 is already closed: it was fixed by #17071.
Refs #17067 (partial: Β§1 nudge-once-per-PR+reason lands here; Β§2 origin-notes folding β #17084, Β§3 marker ratchet β #17085 filed as sub-issues)
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson