Repository navigation
Conversation
…_on_kick New fleet block agents.cli_memory (beside agents.session_recycle): - auto_memory: false (default) seeds each CLI's documented disable at launch, merge-only so an operator's explicit value wins: Claude Code "autoMemoryEnabled": false in the shared interactive settings and the inference agent's settings + --settings file; Codex [features] memories = false in $CODEX_HOME/config.toml. Gemini CLI and Copilot CLI document no local switch, so nothing is seeded for them. - clear_on_kick: true removes the agent's own memory store before every kick (claude: ~/.claude/projects/*/memory, codex: $CODEX_HOME/memories and memories_v2, gemini: ~/.gemini/GEMINI.md). Only stores in a directory private to the agent are removed, via su-exec as the agent UID; a store reached through a symlink bridge into /data/home, a UID 0 agent's HOME or HIVE_SHARED_AGENT_HOME=1 is skipped and logged once. The fleet value is stamped onto every enabled agent by EnabledAgents(), like session_recycle. Settings parity, the operator reference and hive.yaml.example gain the new leaves. Hive-Run: hivecommons#17032 Hive-Plan: hivecommons#17032 Proposal Hive-Spec: hivecommons-hive-17032#agents.cli_memory Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Your relay session received this as a |
…17032) Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide which of #17040 (this PR) and #17055 lands for #17032 — both add the same agents.cli_memory.{auto_memory,clear_on_kick} keys with different mechanisms, so only one can merge.
This PR and #17055 both implement #17032 and conflict on the same config surface. Both add agents.cli_memory with the keys auto_memory and clear_on_kick, a new src/crux/agent/cli_memory.go, a src/crux/config/cli_memory.go, settings-parity leaves and the dashboard allowlist entry. I read both diffs in full; they are the same change by intent and config shape, but not the same code, so merging both is impossible and merging either closes the other.
Concrete differences I verified:
| #17040 (this) | #17055 | |
|---|---|---|
| Config type | AutoMemory bool (src/crux/config/cli_memory.go:19) — a per-agent block cannot inherit the fleet value |
AutoMemory *bool (:23), nil inherits |
| Claude disable | seeds "autoMemoryEnabled": false into settings.json, merge-only (src/crux/agent/cli_memory.go:31) |
CLAUDE_CODE_DISABLE_AUTO_MEMORY=1 in the launch env (:34) |
| Codex | adds memories = false only if no operator value exists (:89) |
pins memories = <policy> and overwrites an existing line (:68) |
| Copilot CLI | nothing seeded — body says there is no local switch | overwrites memory in per-agent ~/.copilot/settings.json (:136) |
| Store discovery for the wipe | Lstat-walks for symlink bridges and skips shared trees (:213) |
uses the perAgentCLIHomes specs from #17039 (:176) |
Status: #17039 merged to v5 as 943d807 ten minutes ago, so ~/.claude/~/.gemini are real per-agent dirs on v5 now. That removes the symlink-bridge case this PR's cliMemoryStores was defending against, and it means #17055 needs its base retargeted from fix/agent-memory-isolation to v5 (it currently shows CONFLICTING).
I have not closed anything; whichever one is preferred, the other should be closed with a pointer so #17032 does not get two fixes.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read the new
One gap against #17032 (the issue asks for "Copilot CLI / Gemini equivalents where one exists"): the PR states Copilot CLI has no local switch (
Not a blocker on the parts that are here — suggesting it land as a follow-up commit on this PR rather than a separate issue, since the table and the "nothing seeded" comment both state the opposite. |
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
Supersede failed: the hive could not open a fresh PR with these commits. Merging Rebase this branch onto |
🐝 Hive Agent:
contributor| SHA:6cb2a1c02— hive: backend=omp model=anthropic/claude-opus-5-5 omp=omp/18.18.0