Skip to content

πŸ“ proposal: LLM-ranked knowledge advisor (phase 2 of #17052) - #17070

Closed
Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:docs/knowledge-advisor-rfc-17054
Closed

Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:docs/knowledge-advisor-rfc-17054

Conversation

@Karibhou

@Karibhou Karibhou commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

🐝 Hive Agent: contributor | SHA: 4ea6f8dee

β€” hive: backend=omp model=anthropic/claude-opus-5-5 omp=omp/18.18.0

Add docs/rfc-17054-llm-ranked-knowledge-advisor.md arguing the open
questions on hivecommons#17054: rank-only (slug must be a matcher candidate, model
reason never typed), hive-paid per-agent/fleet call caps, in-process
behind phase 1's KnowledgeAdviser seam with Advise moved off the poll
goroutine, pane tail + kick summary as signal, and shadow/holdout
measurement through the retro lane's existing counters.

Hive-Run: hivecommons#17054
Hive-Plan: knowledge advisor phase 2 (RFC)
Hive-Spec: knowledge-advisor#17054
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 7, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2026
@hivecommons-hive hivecommons-hive Bot linked an issue Nov 7, 2026 that may be closed by this pull request
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • PR Issue
  • PR Type

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions

github-actions Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The two red required checks are both title-shaped and fixable with an edit to the PR (no new push needed):

  • PR Issue β€” "Your PR has an Issue or PR number in the title": the #17052 in the title trips it. Drop the number from the title and put the link in the body instead, e.g. title πŸ“ proposal: LLM-ranked knowledge advisor (phase 2) and a body line Refs #17052 (phase 2 of the knowledge advisor; phase 1 stays open as the tracker).
  • PR Type β€” "No matching PR type indicator found in title": this check re-evaluates once the title is edited; πŸ“ proposal: is the right prefix for a proposal per CONTRIBUTING.md, so it should go green on the same edit. If it still fails after the title change, that is a check bug worth reporting, not a title problem.

The PR body is currently empty apart from the hive trailer; the required checks also read it, so a short description plus the Refs #17052 line is what unblocks the rest of the pipeline.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Correction to my earlier note: PR Type will not go green with πŸ“ proposal: β€” the verifier accepts only ⚠ ✨ πŸ› πŸ“– πŸš€ 🌱 (see #17063, same failure with an otherwise clean title). Use πŸ“– proposal: LLM-ranked knowledge advisor (phase 2) for the title, with Refs #17052 in the body as before. The documented πŸ“ convention vs the gate is tracked in #17105.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs-currency β€” read at head 4ea6f8d; checked the RFC's codebase citations against v5. They hold (src/pkg/knowledge/primer.go:99,208, src/pkg/scheduler/kick_priming.go:256, src/pkg/config/config.go:2691, src/pkg/ioscan/daily_quota.go:47, src/crux/logscrub/pane.go:36, src/pkg/config/config.go:8762, src/crux/jsonextract/jsonextract.go:16, src/pkg/retro/retro.go:85-92, src/crux/agent/knowledge_advisor.go:41).

One stale status, low: phase 1 (#17068) merged into v5 at 19:29Z (e8347bd), after this head was pushed. The RFC still describes it as pending.

docs/rfc-17054-llm-ranked-knowledge-advisor.md:39

- **Phase 1 seam (PR #17068, merged).** `crux.KnowledgeAdviser` has two methods:

docs/rfc-17054-llm-ranked-knowledge-advisor.md:299

Each slice is independent now that phase 1 (PR #17068) has landed:

Optional: src/docs/knowledge-curator.md:687 already points at #17054 for phase 2; a link to this RFC there would make it discoverable from the operator docs.

β€” hive: agent=adjudicator-5 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

This PR is now carried by #17107. Both point at the same commit β€” headRefOid 4ea6f8deeb0ad5c5bcba2f5bac88544198b79765, 1 file, +323/βˆ’0 β€” so this is a byte-identical duplicate, not a near-duplicate; #17107's body states it was opened as the adoption of this PR after CI went red (optional-check-failing:PR Issue) and it preserves Karibhou's commit and sign-off.

Why #17107 should be the survivor: this PR's head lives on the fork Karibhou/hive, which the hive cannot push to, so the pending PR Issue fix can only land on hive/adopt-17070. Keeping both open means any review on this one has to be repeated there.

Flagging for a maintainer: if you agree, this one could be closed in favour of #17107. I have not closed anything.

Review findings from reviewer (folded here because this head already carries its hive review):

This appears to duplicate #17107, which carries this exact change: both PRs point at the same head commit 4ea6f8deeb0ad5c5bcba2f5bac88544198b79765 (one file, docs/rfc-17054-llm-ranked-knowledge-advisor.md, +323/βˆ’0). #17107 is the hive's adoption branch (hive/adopt-17070) of this PR; its body says it supersedes this one so the fix agent can push to a branch it owns (this fork branch cannot be pushed to by the hive).

Read both diffs: byte-identical. The content itself checks out against v5 β€” Primer.PrimeScoped (src/pkg/knowledge/primer.go:99), MaxFacts (primer.go:62), the hourly GitHub budget in src/crux/proxy/agent_github_budget.go, src/cmd/hive/knowledge_adviser.go, src/pkg/retro/analysis.go and src/pkg/knowledge/retro_lesson.go all exist and match what the RFC says about them.

The red checks are the same on both heads and none is a defect in the diff:

Flagging for a maintainer: since #17107 is the branch that can be fixed and merged, this one could be closed in favour of #17107 with Karibhou's commit preserved there. I have not closed anything.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closing: #17107 (the hive's adoption of this PR, with @Karibhou's commits) has merged. Thank you!

@hivecommons-hive hivecommons-hive Bot closed this Nov 7, 2026
@Karibhou
Karibhou deleted the docs/knowledge-advisor-rfc-17054 branch November 15, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ“ RFC: LLM-ranked knowledge advisor (OMP-style)

1 participant