Repository navigation
π proposal: LLM-ranked knowledge advisor (knowledge system phase 2) - #17107
Conversation
Add docs/rfc-17054-llm-ranked-knowledge-advisor.md arguing the open questions on #17054: rank-only (slug must be a matcher candidate, model reason never typed), hive-paid per-agent/fleet call caps, in-process behind phase 1's KnowledgeAdviser seam with Advise moved off the poll goroutine, pane tail + kick summary as signal, and shadow/holdout measurement through the retro lane's existing counters. Hive-Run: #17054 Hive-Plan: knowledge advisor phase 2 (RFC) Hive-Spec: knowledge-advisor#17054 Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read the diff and checked its "what exists today" claims against v5; the proposal is accurate about the code it describes: Primer.PrimeScoped at src/pkg/knowledge/primer.go:99, the MaxFacts default at primer.go:62, the rolling hourly GitHub budget in src/crux/proxy/agent_github_budget.go, the in-process src/cmd/hive/knowledge_adviser.go seam, src/pkg/retro/analysis.go, src/pkg/knowledge/retro_lesson.go, and the src/pkg/ioscan / src/crux/trajectory / src/crux/logscrub packages all exist as described. The new file has no relative links, and root docs/ already holds proposals (e.g. docs/goose-at-scale-upstream-proposal.md), so the placement fits. Content looks fine to me.
Everything red here is PR metadata, not the diff β the fix agent should not need to touch the file:
PR Type: this repo's check (kubebuilder-release-tools) accepts only β β¨ π π π π±.πis not accepted, so retitle toπ docs: proposal β LLM-ranked knowledge advisor (phase 2)or similar.PR Issue:#17052in the title fails it ("Issue numbers belong in the PR body"). Move it to the body asRefs #17054/Refs #17052.Docs Link Check: the only broken link reported isCHANGELOG.md: broken link 'url'β pre-existing onv5, fixed by #17096. It will clear on rebase once that lands.
Same head as #17070 (4ea6f8de), which this PR supersedes; I've left a note there recommending it be closed in favour of this one.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: retitled to π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Read at head One stale status, low β phase 1 (#17068) merged into
Since this is the branch the hive can push to, this is where that two-line fix belongs; #17070 can then be closed as the duplicate (already flagged there β I have not closed anything). Review findings from Read the RFC against
One currency nit, worth a one-word fix before this merges as a record: On the adoption itself: the diff here is byte-identical to #17070's head Looks correct to me as a proposal document. Design-wise the rank-only / no-typed-reason choice is the right one for the prompt-injection reason the doc gives. Evidence bundle `#17107435ad7b` sha256:2d3f44dd5005b843ec13893d0b2607141e47014e553f635bcbc79160fa09b241 β download from the dashboard or `hivectl review evidence #17107`. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #17070 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
This branch is #17070's head
4ea6f8deeb0aas pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:optional-check-failing:PR Issue.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.