Repository navigation
π fix(dedupe): never fold a dedupe checklist; name the shared path in "Same file as" - #16834
Conversation
- A body carrying `<!-- hive:dedupe-checklist repo=β¦ -->` skips the path folds (file-set, component, canonical subject) like a DAG child (hivecommons#16065). projectbluefin/actions#543, a data-loss bug, received the repo's whole checklist as a "Folded finding" on 10-24. - The review backlog's "Same file as #N" cross-link names the path the two items share (CreateIssueResult.SameFilePath, the component path). On projectbluefin/utah-packages#868 it named the finding's own config/factory-build-backlog.toml, which hivecommons#852 never cites; the shared file was docs/skills/factory-build-backlog.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read the diff against the v6 tree and the callers; this looks correct to me.
createIssue(src/pkg/github/issue_request_watcher.go:1536) setsSkipSharedPathFoldbefore any gate that reads it (:1618,:1646, the claim key at:1776, andreconcileIssueCreateat:1799), so a checklist takes exactly the DAG-child path. Usingstrings.Containsrather than theHasPrefixthatdedupe_advisory_close.go:66uses is the right call here: the body arriving atcreateIssuehas already been throughissueOwnerStepBody(:948), which can prepend text.sameFilePathis only set on the component branch (:1728), andreviewBacklogSameFileCommentfalls back tof.Filefor the file-set case where every path is shared β matches the table in the body.TestDedupeChecklistIsNeverPathFoldedhas a control run without the marker that must fold, so the test fails without the change.
Optional: the doc comment on ReviewBacklogRef.SameFilePath (src/pkg/github/review_backlog_routing.go:79) is truncated mid-sentence ("when every cited path is (CreateIssueResult.SameFilePath)").
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Executive summary
This fixes two dedupe faults, both verified live:
reusable-sync-branches.yml. The checklist cited that workflow, and three open bot issues on it put the request over the same-component fold. A checklist should be its own issue, as [dedupe] triage: duplicate and overlapping open issues/PRs to consolidateΒ projectbluefin/utah#1085 is.config/factory-build-backlog.toml", which is feat: task assignment from actionable queue + profile CLI/model/avatarΒ #868's own evidence file. feat: add system resource gauges to dashboard sidebarΒ #852 never mentions it. The shared file wasdocs/skills/factory-build-backlog.md.What
<!-- hive:dedupe-checklist repo=β¦ -->filefileWhy
createIssueexempts only DAG children (--parent/--blocked-by, [scanner] issue relay: never component-fold a request that declares --parent/--blocked-by DAG placementΒ #16065) from the shared-path folds. A checklist cites many paths by design, so any of them can match a component stream.finding.File, while the refused fold matched oncomponentPath. When the two differ, the note names a file the other issue may not cite.How
createIssue(src/pkg/github/issue_request_watcher.go) setsSkipSharedPathFoldwhen the body carriesdedupeChecklistMarkerPrefix.CreateIssueResult.SameFilePathis the component path whenSameFileAscame from the component match. It is carried throughReviewBacklogRef.SameFilePathintoreviewBacklogSameFileComment, which falls back to the finding's file for an equal file set.Tests
TestDedupeChecklistIsNeverPathFoldedTestReviewBacklogSameFileNamesSharedPathdocs/skills/factory-build-backlog.mdTestReviewBacklogSameFileCommentFallsBackToFindingFileTestReviewBacklogGitHubSinkFilesSeparatelyForSameFileDifferentFindinggo test ./pkg/github/... ./pkg/writeback/check-docs-citations.py src/docsNotes
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1