Repository navigation
π fix(claims): ignore zero-width-space entities in issue refs; skip no-action review findings - #16827
Conversation
β¦no-action findings Renovate writes `[@&hivecommons#8203;user]` and `[#&hivecommons#8203;628]` so GitHub links nothing. The closing-keyword gap let "fixed and prefixed label handlers by [@&hivecommons#8203;" read as a claim on hivecommons#8203 (projectbluefin/gutenprint-printer-app#169), and the review filed projectbluefin/gutenprint-printer-app#170 about the artifact, a finding that said itself "No action needed on the PR". - prclaims: strip decimal character references before the claim and reference patterns run. - review backlog: an info-severity finding that says no action is needed is not filed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <Danathar@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
@Danathar this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (4 waiting): fixes are handed out before new work as soon as you have capacity. |
There was a problem hiding this comment.
Read at head 9c0339e against v6 (440f498). Looks correct to me.
- Every body/title parser routes through the patched points:
ParseClaimedIssuesandFindClosingKeywordReferenceboth callstripClosingFalsePositiveText(pkg/github/prclaims.go:514,:524), where the entity strip now runs first (:556);ParseReferencedIssuesgets the same replacement inline (:682). I checked the callers inclient.go:2259,close_on_merge.go:574,issue_inprogress.go:225,merge_credit.go:84,merged_pr_backfill.go:29,pr_issue_link.go:393,pr_reference_links.go:82,pr_reporter_trust.go:162-167β all go through one of those three, so no path still sees the raw​. - Replacing with a space (not deleting) is the right choice:
[#​628]becomes[# 628], and bothclaimRefPatternandreferenceRefPatternrequire digits immediately after#, so the628cannot be re-joined into a reference. fileOutOfScopeReviewBacklogis a thin wrapper overfileReviewBacklog(review_backlog.go:219-220), so the newfindingNeedsNoActioncheck at:272covers both the out-of-scope and the posted-review paths. TheSeverityInfo-only guard keeps a low/medium finding that happens to say "no action needed on the PR, butβ¦" filed, which the test pins.pkg/github/builds at this head; the test helpers (withReviewBacklogState,headsBacklogClient,routingReport,nit,fakeBacklogSink) all exist in the package's existing test files.
Nothing to change.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Check report (hive scanner, read-only β fork branch, nothing pushed) for head 9c0339e: The red Fix: retitle the PR so it has no
No code change needed; the check re-evaluates on the title edit. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. stage 080-awaiting-merge-admission β 072-returned-to-contributor: check-failure Evidence bundle `#168271b7378e` sha256:f3c2b36a80b9d4cc6ed1e4b5e3017b5fbcf7a5293e6dd5964709500512e3bc22 β download from the dashboard or `hivectl review evidence #16827`.Review findings from Read the parse paths at the head. The entity strip in |
Signed-off-by: Danathar <Danathar@users.noreply.github.com> # Conflicts: # src/docs/review-swarm.md
​ in issue refs; skip no-action review findingsThere was a problem hiding this comment.
Read the parsers this touches and the sibling #N regexes in the package; this looks correct to me.
stripClosingFalsePositiveText(src/pkg/github/prclaims.go:555) is the shared pre-pass forParseClaimedIssues(:514) and the keyword scan at:524, so oneReplaceAllStringcovers both closing paths;ParseReferencedIssues(:682) gets the same pre-pass explicitly.parseRefskeeps no byte offsets into the text, so replacing an entity with a single space shifts nothing that is used later.- Replacing
​with a space turns Renovate's[#​628]into[# 628], whichissueRefPattern(:672) does not match β so the deliberately de-linked upstream PR number is not read as a reference either, which is the right call. - This matches the idiom already in the package:
askFoldRefRE(issue_ask_fold.go:24) andparkRefRE(issue_park_recheck.go:370) already exclude&before#for the same reason. findingNeedsNoAction(review_backlog.go:590) is gated onSeverityInfo, so a higher-severity finding is filed regardless of wording.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against the tree at 1b7378e, then the callers. Looks correct to me.
Verified
src/pkg/github/prclaims.go:555-558β the entity strip runs first insidestripClosingFalsePositiveText, so the three callers that already go through it pick it up:ParseClaimedIssues(prclaims.go:514),FindClosingKeywordReference(prclaims.go:524), the GitHub-parity parser inpr_issue_link.go:440/467, and theRefstier inpr_reference_links.go:85.ParseReferencedIssues(prclaims.go:682) deliberately does not use the stripper and gets the same replacement inline β consistent.- Replacing
​with a space turns[#​628]into[# 628], whichissueRefPattern(#(\d+)) no longer matches, and leaves adjacent#12/#7intact β the test covers both directions. review_backlog.go:581-591βfindingNeedsNoActionis gated onSeverityInfoand its own wording; placed next tofindingHasEvidenceso it skips before the ledger/dedupe lookup, which means no key is persisted for a skipped finding (good: a later non-info rewording still files).- Test helpers (
withReviewBacklogState,headsBacklogClient,routingReport,nit) exist with the signatures used; CItest/coverage/patch-coverageare green at this head.
One note, not a defect: dedupeChecklistRefs (src/pkg/github/dedupe_advisory_close.go:96) still runs issueRefPattern over an unstripped body. Those bodies are hive-authored checklists rather than Renovate notes, so it is unlikely to see an entity; mentioning it only so the gap is known.
Body and diff agree. The PR body's "What" table matches what the tests assert.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Executive summary
Renovate writes
[@​user]and[#​628]in its release notes so GitHub links nothing. The hive's closing-keyword parser read the#8203inside that entity as an issue: "fixed and prefixed label handlers by [@ββ¦" in projectbluefin/gutenprint-printer-app#169 became a claim on #8203. The review then filed projectbluefin/gutenprint-printer-app#170 about the artifact, and that finding itself said "No action needed on the PR".This PR strips decimal character references before the claim and reference patterns run. The review backlog also stops filing an
infofinding that says no action is needed.What
ParseClaimedIssuesβ #8203ParseReferencedIssues)Why
claimRefPattern's prose gap ([^.\n#]{0,39}?) stops at#, so a keyword followed within 39 characters by​matches#8203.stripClosingFalsePositiveTextalready removed code spans and URLs, but not character references. A hex reference (​) never reads as#N, so only decimal ones are stripped.The backlog filer has no "no action" field to read, since a finding is title, severity, summary and location. The skip is narrow:
infoseverity and the finding's own words ("no action needed" / "no further action is required").How
src/pkg/github/prclaims.go:htmlNumericEntityPattern(&#[0-9]+;) is replaced with a space instripClosingFalsePositiveText. That coversParseClaimedIssuesandFindClosingKeywordReference, andParseReferencedIssuesgets the same replacement.src/pkg/github/review_backlog.go:findingNeedsNoActionis checked next tofindingHasEvidenceinfileReviewBacklog.Tests
TestClaimParsersSkipHTMLNumericEntities#12/#7keptTestFindingNeedsNoActionTestReviewBacklogSkipsNoActionFindinggo test ./pkg/github/... ./pkg/writeback/check-docs-citations.py src/docsNotes
π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1