Skip to content

πŸ› fix(park-recheck): a park with options waits on what the options name - #16840

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/park-recheck-option-refs
Nov 5, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/park-recheck-option-refs

Conversation

@Danathar

@Danathar Danathar commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Executive summary

On 11-03 the park re-check told maintainers that projectbluefin/server#614's park "may be out of date". It listed #588 and #584 as merged "(the park reason names it)". Both were collateral: the park was about #583, which both of its options merge and which is still open. #584 and #588 appear only in the evidence line "red on main (cron) and on PRs #583, #584, #588, #594, #613".

With this PR, when a park's lettered options name references, only those count as what the park waits on. The rest of the park text is evidence.

What

Park text Named refs the re-check watches server#614 after #584/#588 merge
Before every #N in the park text note: #588, #584 merged
After: options naming refs (#614: #583) refs in the option blocks no note while #583 is open
After: options naming no refs, or no options every #N (unchanged) n/a

PRs that refer to the issue ("Refs #614", closing keywords, …) and merge still produce the note as before.

How

  • parkOptionRefs (src/pkg/github/issue_park_recheck.go) collects each option line (unparkOptionLetter, the same parser the "What to reply" menu uses) and the lines under it, up to a blank line or the next option. It then runs parkNamedRefs over those blocks.
  • recheckParkedIssue uses that list for named when it is non-empty. That affects the lookups, parkChanges, the adopted-copy follow-up and markParkLandings.

Tests

Test Covers
TestParkRecheckOptionsNameWhatTheParkWaitsOn #614 shape: collateral merges β†’ no note; #583 merges β†’ note names #583 only
TestParkRecheckOptionsWithoutRefsKeepNamedRefs options naming nothing keep the body's #722
TestParkOptionRefs #614 β†’ #583; continuation lines count; a blank line ends a block; no options β†’ nil
Existing TestParkRecheck* unchanged
Mutants 3/3 caught (a fourth guard was equivalent and removed)
go test ./pkg/github/ ./pkg/writeback/ pass
check-docs-citations.py src/docs 2006 verified

Notes

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

projectbluefin/server#614 parked on hivecommons#583 (both options merge it) and listed
hivecommons#584 and hivecommons#588 among the PRs its red prow check touched. The re-check
reported those two merging as "the park reason names it" and called the
park out of date while hivecommons#583 was still open.

When a park's lettered options (each option line and the lines under it)
name references, only those count as named refs; the rest of the text is
evidence. Parks without options, or whose options name nothing, keep every
named reference. PRs that refer to the issue still count as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Signed-off-by: Danathar <Danathar@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2026
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read against v6 with the callers. Looks correct to me.

  • parkOptionRefs reuses unparkOptionLetter (src/pkg/github/issue_unpark_command.go:1580), which on v6 already accepts the Option A:, **A.** bold and plain A) forms, so the option-block boundaries match what the "What to reply" menu sees.
  • The substitution at src/pkg/github/issue_park_recheck.go:181-183 only narrows named; the "PR refers to the issue" branch in parkChanges (issue_park_recheck.go:493) is untouched, so a merged Refs #614 PR still produces the note. The new test's collateral case passes because #584/#588 are cross-refs whose bodies don't refer to #614, not because that path was disabled.
  • Falling back to every named ref when options name nothing (len(acted) > 0 guard) keeps the pre-existing behaviour for parks without options.

The trade-off the body names (prose waits on #X, options name #Y β†’ only #Y watched) is real but documented in maintainer-commands.md; fine by me as an engineering call.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 728cb82 into hivecommons:v6 Nov 5, 2026
71 of 74 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1684098cfdcf` sha256:cd87cc7220c54a56c6266195935d13b8717948eafc4e74b6557268029148b994 β€” download from the dashboard or `hivectl review evidence #16840`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant