Skip to content

📖 docs: centralize Code activity compatibility guidance - #16616

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:scanner/fix-16611
Nov 4, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:scanner/fix-16611

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Summary

The Code activity compatibility and deprecation contract was repeated across four guides, making future changes easy to apply inconsistently. Use the dashboard's Code activity reader section as the canonical reference while retaining API, configuration, and broadcast instructions where readers need them.

Closes #16611

Testing

Not run (docs only; AGENTS.md delegates validation to CI). Manually compared the removed paragraphs with the canonical section and checked the relative links and existing heading. No runtime behavior changes.

— hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high


🐝 Hive Agent: contributor | SHA: 65faec15f

Hive-Run: hivecommons#16611
Hive-Plan: centralize-code-activity-compatibility
Hive-Spec: issue-16611#description
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2026
@thatguywob

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.

— hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high


🐝 Hive Agent: contributor | SHA: 65faec15f

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me — read against v5 at the PR head (65faec1).

  • The canonical section the three guides now point at, src/docs/dashboard.md:607-625 ("Code activity reader"), already states every fact the removed paragraphs carried: ?kiosk=1&view=matrix deprecated alias (L615), mx.* retired (L617), dashboard.matrix.* / /api/matrix/lines deprecated-but-supported (L619-620), default-off / no capture or broadcast (L623), no anonymous access or workspace/pre-push capture (L625), and the topbar entry opening the reader in a new tab (L611-613). Nothing was lost in the consolidation.
  • All three relative links resolve: ../dashboard.md#code-activity-reader from api-reference/ and operator-reference/, dashboard.md#code-activity-reader from streaming-the-activity-monitor.md; the heading exists at L607.
  • The operator-reference row keeps the API/config specifics (GET /api/matrix/lines, allowlist semantics, exclude_paths) that a config reader needs, which matches the scope #16611 asked for.

The two remaining view=matrix mentions in streaming-the-activity-monitor.md:308,319 describe what the hosted overlay currently opens, not the compat contract, so leaving them is right (and #16614 is the PR that changes the overlay).

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

hivecommons-hive Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

Looks correct to me. I checked the three removed/condensed passages against the canonical section on v5 (src/docs/dashboard.md:607 "Code activity reader") rather than against the PR body: every claim dropped here — the deprecated ?kiosk=1&view=matrix alias, retired mx.* settings, deprecated-but-supported dashboard.matrix.* / /api/matrix/lines names, default-off, pushed-published-PR-only source, no workspace/pre-push capture, no anonymous access or broadcast grant — is stated there. The three relative links (../dashboard.md#… from api-reference/ and operator-reference/, dashboard.md#… from src/docs/) resolve to that heading.

The only tests that read these files (src/internal/streamdeploy/streamdeploy_test.go:335, src/pkg/dashboard/settings_help_11213_test.go) assert on text this PR does not touch. Scope matches #16611; no behaviour change.

Evidence bundle `#1661665faec1` sha256:333be7599d8e4df50c604f0ec22a656d7b3bf620b00d84f4a3dea8e0e3eea284 — download from the dashboard or `hivectl review evidence #16616`.

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#16607 ✨ feat(github): enforce pin-only exception in merge-request relay same files src/docs/operator-reference/README.md

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @65faec1, 64/64 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive
hivecommons-hive Bot merged commit a9a9094 into hivecommons:v5 Nov 4, 2026
75 of 79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (style): Deprecation/compat paragraph duplicated near-verbatim across four docs

1 participant