Skip to content

[reviewer] Review backlog (style): Ghost effect still uses hardcoded 100px bottom allowance #16452

Closed

Description

@hivecommons-hive

Blocked on PR #16443. This finding came from reviewing PR #16443 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16443.

PR: #16443 (#16443)
Perspective: style
Severity: low (P3)
Finding: Ghost effect still uses hardcoded 100px bottom allowance
Evidence: src/pkg/dashboard/static-src/js/matrix.js:173

var visible = Math.max(1, Math.floor((height - top - 100) / rowH));

matrix.js:173 computes visible rows with height - top - 100 while terminal now measures the actual HUD/CTA band. Overlays render on top regardless (z-index fix), so this is a consistency gap only; a follow-up should make both text effects clear the same measured band.

Fingerprint: 01d26cc75b974035114657b26c074628ecd2109e3e8f47c6e0f903dbc3ce0540

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16440: both cite src/pkg/dashboard/static-src/js/matrix.js, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: source PR #16443 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.

  6. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16443 is no longer open. This issue is actionable again.

    Already fixed on v5, so closing without a PR (per the unblock instruction in the body: #16443 closed unmerged; the fix landed via #16444).

    At v5 head abf91a871c4f, src/pkg/dashboard/static-src/js/matrix.js no longer hardcodes 100px for the ghost effect — both text effects clear the same measured band:

    • matrix.js:81 — function hudBand(){ return Math.max(100, (labels.offsetHeight || 0) + 32); }
    • matrix.js:177 (ghost rows) — Math.floor((height - top - hudBand()) / rowH)
    • matrix.js:207 (terminal baseline) — var bottom = height - hudBand();

    var visible = Math.max(1, Math.floor((height - top - hudBand()) / rowH));

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions