You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Merge-guard lock files are world-readable on shared /data volume (co-tenant can park merges) #16055
Blocked on PR #16052.src/pkg/github/destination_merge.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16052.
)
Finding: Merge-guard lock files are world-readable on shared /data volume (co-tenant can park merges)
AcquireDestinationMerge creates /data/destination-merges with 0o755 and <sha256(repo:base)>.lock with 0o644 (destination_merge.go:85-92) then flock(LOCK_EX|LOCK_NB) (line 97). /data is shared with agent pods (observed dir 0755 dev:node); flock needs only an open fd, so any co-tenant that can read the predictable lock path can hold it and every Hive merge to that base returns ErrDestinationMergeBusy and parks — now including relay human-merge requests (merge_request_watcher.go:418) and MergePRVia (pullrequest.go:445). Same pattern pre-exists in base_preparation_store.go:143-164, hence out-of-scope. Fix: use 0o700/0o600 for the new directory and lock files.
Unblocked: #16052 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 2, 2026
Unblocked: #16052 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 2, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16052 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 2, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Nov 2, 2026
Fixed by #16261 (merged 39e76e9). Closing. Reply /reopen if the problem persists.