Skip to content

[reviewer] Review backlog (security): Merge-guard lock files are world-readable on shared /data volume (co-tenant can park merges) #16055

Closed

Description

@hivecommons-hive

Blocked on PR #16052. src/pkg/github/destination_merge.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16052.

PR: #16052 (#16052)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/destination_merge.go:86 (

const fileMode = 0o644
)
Finding: Merge-guard lock files are world-readable on shared /data volume (co-tenant can park merges)

AcquireDestinationMerge creates /data/destination-merges with 0o755 and <sha256(repo:base)>.lock with 0o644 (destination_merge.go:85-92) then flock(LOCK_EX|LOCK_NB) (line 97). /data is shared with agent pods (observed dir 0755 dev:node); flock needs only an open fd, so any co-tenant that can read the predictable lock path can hold it and every Hive merge to that base returns ErrDestinationMergeBusy and parks — now including relay human-merge requests (merge_request_watcher.go:418) and MergePRVia (pullrequest.go:445). Same pattern pre-exists in base_preparation_store.go:143-164, hence out-of-scope. Fix: use 0o700/0o600 for the new directory and lock files.

Fingerprint: 53e839775af267acadeeaf609adbfcba747162b6efff6a5315c1555b1454640a

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16052 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16052 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 2, 2026
  7. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

  8. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16261 (merged 39e76e9). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthas-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions