You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (style): Destination-merge guard directory derived independently in boot and automerge; helper body duplicated inline #16053
Blocked on PR #16052.src/pkg/github/automerge/automerge_destination_merge.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16052.
)
Finding: Destination-merge guard directory derived independently in boot and automerge; helper body duplicated inline
boot_agents_deps.go:103 computes Join(DefaultStateDir, "destination-merges") while automerge_destination_merge.go:19 and :45 compute Join(Dir(preparationStore().dir), "destination-merges"); acquireDestinationMerge inlines the body of destinationDirectory instead of calling it. The two production paths agree only because sharedBasePreparation lives at DefaultStateDir/base-preparation (automerge_base_preparation.go). If either path moves, the sweep and the merge-request relay stop sharing a flock silently. Suggest one exported helper in pkg/github used by both, and have acquireDestinationMerge call destinationDirectory(c).
Hive lifted the blocked label it applied on 2026-10-31T15:00:22Z: #16052 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).
Unblocked: #16052 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Already addressed on v5: DestinationMergeDirectoryForPreparation in src/pkg/github/destination_merge.go is the single helper; both destinationDirectory and DefaultDestinationMergeDirectory (used by boot) call it, acquireDestinationMerge calls destinationDirectory(c), and automerge_preparation_readiness_test.go:151 asserts the agreement. Closing.
Activity
hivecommons-hive commentedon Nov 2, 2026
Hive lifted the
blockedlabel it applied on 2026-10-31T15:00:22Z: #16052 merged since, so the reason for the park no longer holds and the issue is back in the normal flow. Labels applied by a human are never lifted by this sweep (#12002).hivecommons-hive commentedon Nov 2, 2026
Unblocked: #16052 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 2, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Nov 2, 2026
Already addressed on v5:
DestinationMergeDirectoryForPreparationin src/pkg/github/destination_merge.go is the single helper; bothdestinationDirectoryandDefaultDestinationMergeDirectory(used by boot) call it,acquireDestinationMergecallsdestinationDirectory(c), and automerge_preparation_readiness_test.go:151 asserts the agreement. Closing.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:ae1ffdf19— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 2, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).