Skip to content

✨ feat: stage tracker shows push progress on CI / Review rows - #15800

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-15784
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-15784

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

A PR row waiting on its contributor to push reads the same before and after they push, until review / CI catches up, so the operator cannot tell whether anything is happening or how long the row has waited. The webhook re-read after a pull_request synchronize already carries the new head; the stage record just never kept it.

This is the backend core of #15784:

  • stagelabels.Record gains waiting_push_since (set on entry to 071 needs-author / 072 returned-to-contributor, kept across 071↔072, cleared on leaving), last_push_at and last_push_sha.
  • Store.NotePush records a head the record does not know; the dashboard calls it from applyWebhookItemSnapshots for every open PR re-read (only a synchronize moves a head). NoteActivity records the enumeration's head change as a fallback, but not the head a wait began on in that same pass.
  • A fresh wait resets the push: a new 071/072 entry, or a nudge for the head the contributor last pushed (MarkNudged).
  • Tracker PR rows expose waiting_push_since, last_push_at, last_push_sha and pushed_since_waiting (additive; no existing names changed).

Tests: stagelabels/push_progress_test.go covers the store rules, and dashboard/stage_tracker_push_test.go covers the webhook re-read → record → row JSON path.

Part of #15784 (remaining: #15794 pill age / stale tone / pushed state + chevron revert, #15797 push detail on every CI / Review row, #15796 hive caption line)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15793 🐛 stage tracker: 'Let hive decide' shows it is working and answers faster same files src/pkg/dashboard/stage_tracker.go
src/pkg/dashboard/stage_tracker_build.go
#15748 🐛 [reviewer] park PRs at 085 Needs decision when the fixer exhausted its attempts same files src/pkg/dashboard/stage_tracker_build.go
#15787 🐛 Run the reconcile pass when wakes outpace the eval interval; age unblocked rows from the lift same files src/pkg/dashboard/stage_tracker_build.go
src/pkg/stagelabels/store.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

Closing this hive-authored PR as superseded by #15801: every issue it closes is already closed and that merged PR closed #15784. Head 730de82 conflicts with v5, so there is nothing of its own left to rebase and measure. Reopen if that's wrong.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added the hive/superseded Closed by Hive: a different merged PR already landed this change label Oct 30, 2026
@hivecommons-hive hivecommons-hive Bot closed this Oct 30, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. hive/superseded Closed by Hive: a different merged PR already landed this change role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants