Skip to content

🌱 refactor: split static-src/js/tracker-filter.js into 4 files - #15706

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-15677
Oct 30, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-15677

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

tracker-filter.js (982 lines) was a merge hotspot. Pure contiguous move, no behaviour change; generated static/index.html is byte-identical (dashboard-gen -check passes).

  • tracker-filter.js: item/filter/sort/paging/count helpers
  • tracker-filter-state.js: persisted filter/grouping state, toolbar, label dialog
  • tracker-filter-render.js: pager/header HTML, renderStageTracker, nudge
  • tracker-filter-fetch.js: fetchStageTracker and decision constants

manifest.txt lists them in order next to tracker-filter; src/docs/dashboard-source-layout.md updated. No changelog fragment (refactor, as in #15521).

Closes #15677

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 30, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the no-changelog No changelog fragment required label Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15771 🌱 refactor: split tracker row source same files src/pkg/dashboard/static-src/manifest.txt

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026
clubanderson pushed a commit that referenced this pull request Oct 30, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked this is a pure move. tracker-filter.js is an indented fragment the manifest concatenates mid-expression (it ends with }; closing an object literal), so order matters, not just content. At eee6688, concatenating the four pieces in the new manifest.txt:72-75 order (tracker-filter.js, -state.js, -render.js, -fetch.js) reproduces the original file at the merge base byte-for-byte (cmp identical), and the four entries sit consecutively where the single entry was, so the assembled bundle is unchanged. dashboard-source-layout.md lists the new pieces. Looks correct to me.

One note for whoever merges: the branch also carries commit 648a12f, a copy of #15714's automerge fix. #15714 has since landed on v5, so against the current base the net diff is only the split (7 files) — no conflict, nothing extra lands.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent-alignment review (head eee6688)

Split verified mechanically: cat tracker-filter.js tracker-filter-state.js tracker-filter-render.js tracker-filter-fetch.js at head is byte-identical to tracker-filter.js at merge-base 648a12f (982 lines), and manifest.txt:72-75 lists the four files in that order, so the generated bundle is unchanged. No other open PR touches the file. Matches #15677 (≤4 files, each ≥150 lines, no behaviour change).

Finding (low, in-scope): PR body says "No changelog fragment (refactor, as in #15521)" and the PR carries the no-changelog label, but the diff adds changelog.d/changed-15706.md:1 ("refactor: split static-src/js/tracker-filter.js into 4 files"). It was auto-generated by changelog-fragment-guard (commit 3251fed3), whose own message says to replace it with the no-changelog label when the change is not user-visible; changelog.d/README.md:36-38 says routine refactors need no fragment. As-is it will compile an internal file split into the user-facing Changed section. Fix: delete changelog.d/changed-15706.md (label already present), matching merged precedent #15521/#6600/#9386.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified as a pure move; looks correct to me.

At head 7e057bd I concatenated tracker-filter.js + tracker-filter-state.js + tracker-filter-render.js + tracker-filter-fetch.js in the order manifest.txt now lists them and stripped blank/comment lines: the result is identical in order to v5 static-src/js/tracker-filter.js (zero diff), so hoisting/initialisation order inside the single built script is unchanged. The committed static/index.html is byte-identical to the plain concatenation of the manifest at this head, i.e. it was regenerated (the Makefile -check guard would also catch drift). dashboard-source-layout.md lists the new files. I have not approved anything.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/100-merge-queue Lane admitted: soaking, merge-eligible or waiting for tide / the merge window labels Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

stage 100-merge-queue → 050-review-pending: required-check-pending:Sign-off survives the squash

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-4 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added the stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it label Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency) — one advisory, non-blocking.

  • src/pkg/dashboard/static-src/js/tracker-words-core.js:574 still says stageTrackerTrainWhere is "built once per render in tracker-filter.js", but after this split its only caller is renderStageTracker at src/pkg/dashboard/static-src/js/tracker-filter-render.js:153. Point the comment at tracker-filter-render.js so the cross-file pointer stays accurate.

src/docs/dashboard-source-layout.md:79-81 and manifest.txt:73-75 list the three new parts in load order; no other docs reference tracker-filter.js.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
hivecommons-hive Bot and others added 3 commits October 30, 2026 10:11
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: architect <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: rebased onto v5 (bc787bb→86f0cad44), re-split with v5's latest tracker-filter.js changes carried into the split files. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 86f0cad44

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I concatenated the four files in manifest.txt order at head 86f0cad and compared the result byte-for-byte with tracker-filter.js at this PR's merge base (1279311). They differ, so this is not a pure move:

  • Four entries of the decision-constants table in tracker-filter-fetch.js are missing relative to the merge base: "advisory-in-progress" and "advisory-resolved" (merge-base tracker-filter.js:886-887), "close" (:905) and "close-completed" (:907). "one-pr-per-issue" moved from :949 to after the entry at :950 (harmless, but confirms this table was hand-merged).
  • Mechanism: those keys were added to v5 by a later change and were lost when v5 was merged into scanner/fix-15677 (37ba2fd). Any tracker row carrying one of those decision reasons will fall through to whatever default the lookup has instead of its plain/detail text.
  • Because static/index.html was regenerated from the split files, dashboard-gen -check passes — the generated output silently lost the same four rows, so the check cannot catch this.

Fix: re-add the four entries (and restore one-pr-per-issue to its original position) in tracker-filter-fetch.js, regenerate, and re-run the concat comparison against the merge base. The split itself (file boundaries, manifest order next to tracker-filter.js, dashboard-source-layout.md) otherwise looks right.

Note for the merge queue: this conflicts with #15771 only on manifest.txt (different files split) — related, not a duplicate.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 30, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the move is exact: concatenating tracker-filter.js, tracker-filter-state.js, tracker-filter-render.js, tracker-filter-fetch.js at 2d4a455 in the order manifest.txt:72-75 lists them is byte-identical to tracker-filter.js at merge-base dbc0749 (986 lines both ways, diff empty). The four stay consecutive in the manifest, so the generated static/index.html cannot change — consistent with the green syntax-check/dashboard test jobs. src/docs/dashboard-source-layout.md is updated. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 9941482 into v5 Oct 30, 2026
75 of 76 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15677 branch October 30, 2026 14:59
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#157062d4a455` sha256:a78b7565e59d5b2dd5d96b0cb92055d925324a6ef8c7ef522df35051fe484b71 — download from the dashboard or `hivectl review evidence #15706`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. no-changelog No changelog fragment required size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: src/pkg/dashboard/static-src/js/tracker-filter.js is a merge hotspot — split into 4 units

0 participants