Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f23175b
♻️ dashboard: split stage_tracker.go into 4 files
odttlnt Oct 29, 2026
0941f54
Merge f23175b2a529222ac600324600569d6717f30a9a into 25f02be0c988305a9…
hivecommons-hive[bot] Oct 29, 2026
8b96216
changelog: fragment for #15574
hivecommons-hive[bot] Oct 29, 2026
a236878
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
92c89c3
docs: point ADR-0025 stageStoreOrShared citation at stage_tracker_cap…
hivecommons-hive[bot] Oct 30, 2026
1586a48
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
a4bbef5
merge v5 into hive/adopt-15526: re-derive the stage_tracker split fro…
hivecommons-hive[bot] Oct 30, 2026
92d4cef
merge v5 into hive/adopt-15526: re-apply #15537/#15584/#15591 stage_t…
hivecommons-hive[bot] Oct 30, 2026
e9696c4
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
7d4ce63
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
f3b4fb2
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
174e219
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
b805bd9
Merge origin/v5 into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
e25851a
Merge origin/v5 into hive/adopt-15526: port #15616 caption constant i…
hivecommons-hive[bot] Oct 30, 2026
7d28ecc
Merge origin/v5 into hive/adopt-15526: port #15639 WaitingOnHuman wir…
hivecommons-hive[bot] Oct 30, 2026
e2f4fe8
Merge branch 'v5' into hive/adopt-15526
hivecommons-hive[bot] Oct 30, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/changed-15574.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- dashboard: split stage_tracker.go into 4 files (#15574)
2 changes: 1 addition & 1 deletion src/docs/adr/0025-central-stage-engine.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ records transitions, regressions and history hops
(`src/pkg/stagelabels/store.go:397`, `IsRegression` at
`src/pkg/stagelabels/store.go:540`). The dashboard activity tracker and the
hub read that store and nothing else (`stageStoreOrShared`,
`src/pkg/dashboard/stage_tracker.go:1927-1933`).
`src/pkg/dashboard/stage_tracker_caption.go:951-956`).

**What is not central — three gaps.**

Expand Down
2 changes: 1 addition & 1 deletion src/docs/dashboard-sections.md
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ The tooltip lists the PRs ahead and the overlapping files. Waiting siblings are

Before the merge gate, the tracker defers general `sentinel`, `needs human` and `unauthorized` pills so they do not distract from work still in motion. **Exception:** `unauthorized:approve-workflow-runs` appears immediately, because a person must approve the held run before CI can start.

The server splits markers by `ActionableNow` (`stageTrackerModifiers` in `stage_tracker.go`). The payload puts drawn pills in `modifiers` and held-back pills in `deferred_modifiers`.
The server splits markers by `ActionableNow` (`stageTrackerModifiers` in `stage_tracker_caption.go`). The payload puts drawn pills in `modifiers` and held-back pills in `deferred_modifiers`.

A deferred pill is simply absent — no chip, no breathing chevron, no **Needs attention** count — until the PR's stage reaches the merge-gate band (`stage/080` and later: 080, 085, 090, 095, 100, the same boundary adoption yields at), when it renders exactly as before and counts; the row tooltip alone says "Pending at merge gate: sentinel, needs-human". The merge-gate cell's own words ("Sentinel alert · needs human", "Awaiting human: …") are unchanged — they only appear at the gate anyway.

Expand Down
4 changes: 2 additions & 2 deletions src/pkg/dashboard/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ type Server struct {
// the tracker's "Merging" rows (stage_tracker_merge_gate.go); tests only.
mergeAttempts func() []github.MergeAttempt
// stageTrackerCache is the last /api/stage-tracker payload built from
// the status snapshot, served until its TTL lapses (stage_tracker.go).
// the status snapshot, served until its TTL lapses (stage_tracker_build.go).
stageTrackerCache stageTrackerCache
stageTrackerCacheMu sync.Mutex
// stageTrackerBuild is the one rebuild in flight, nil when none; it is
Expand All @@ -160,7 +160,7 @@ type Server struct {
// build they can hold open; nil in production.
stageTrackerBuildFn func(status *StatusPayload, store *stagelabels.Store, now time.Time) StageTrackerResponse
// stageTrackerLinks memoises the issue lookups that title the tracker's
// untitled links across rebuilds (stage_tracker.go).
// untitled links across rebuilds (stage_tracker_links.go).
stageTrackerLinks stageTrackerLinkMemo
// evidenceHB is the background-refreshed evidence aggregate the hub
// heartbeat reads (evidence_heartbeat.go); zero value is ready to use.
Expand Down
Loading
Loading