Skip to content

📖 docs: re-point ADR 0025 stage-store citation - #15534

Merged
clubanderson merged 1 commit into
hivecommons:v5from
odttlnt:docs/adr-0025-stage-store-citation-15531
Oct 29, 2026
Merged

clubanderson merged 1 commit into
hivecommons:v5from
odttlnt:docs/adr-0025-stage-store-citation-15531

Conversation

@odttlnt

@odttlnt odttlnt commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #15531

ADR 0025 cited src/pkg/dashboard/stage_tracker.go:957-962 as where the tracker reads the stage store, but those lines are the stageTrackerSentinel doc comment. The citation now names stageStoreOrShared and points at stage_tracker.go:1927-1933, which is the accessor that returns the injected or shared stage store. The docs-only change needs no changelog fragment, and check-docs-citations.py passes locally.

Note: #15526 moves stageStoreOrShared into stage_tracker_caption.go. Whichever PR merges second needs to re-anchor this citation (check-docs-citations.py --fix handles it).

— hive: backend=bob model=premium

Fixes #15533

The citation stage_tracker.go:957-962 pointed at the stageTrackerSentinel doc comment, not at where the tracker reads the stage store. Cite stageStoreOrShared (1927-1933) instead.

Hive-Run: hivecommons#15531
Hive-Plan: docs-currency backlog fix
Hive-Spec: adr-0025#stage-store-citation
Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @b2d3d73, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (below require_tiers).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@clubanderson
clubanderson merged commit 3fedd0f into hivecommons:v5 Oct 29, 2026
66 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

2 participants