Repository navigation
📖 docs: re-point ADR 0025 stage-store citation - #15534
clubanderson merged 1 commit into
Conversation
The citation stage_tracker.go:957-962 pointed at the stageTrackerSentinel doc comment, not at where the tracker reads the stage store. Cite stageStoreOrShared (1927-1933) instead. Hive-Run: hivecommons#15531 Hive-Plan: docs-currency backlog fix Hive-Spec: adr-0025#stage-store-citation Signed-off-by: SACHIN NAIK <sachin.naik@ibm.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
|
Ready for a human merge: verdict approved @b2d3d73, 57/57 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
Fixes #15531
ADR 0025 cited
src/pkg/dashboard/stage_tracker.go:957-962as where the tracker reads the stage store, but those lines are thestageTrackerSentineldoc comment. The citation now namesstageStoreOrSharedand points atstage_tracker.go:1927-1933, which is the accessor that returns the injected or shared stage store. The docs-only change needs no changelog fragment, andcheck-docs-citations.pypasses locally.Note: #15526 moves
stageStoreOrSharedintostage_tracker_caption.go. Whichever PR merges second needs to re-anchor this citation (check-docs-citations.py --fixhandles it).— hive: backend=bob model=premium
Fixes #15533