Skip to content

Review backlog (docs-currency): ADR 0025 stage_tracker.go:957-962 citation points at a doc comment, not the store read #15533

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15526.

PR: #15526 (#15526)
Perspective: docs-currency
Severity: info (P3)
Evidence: src/docs/adr/0025-central-stage-engine.md:46 (

hub read that store and nothing else (`src/pkg/dashboard/stage_tracker.go:957-962`).
)
Finding: ADR 0025 stage_tracker.go:957-962 citation points at a doc comment, not the store read

src/docs/adr/0025-central-stage-engine.md:46 cites src/pkg/dashboard/stage_tracker.go:957-962 for 'the dashboard activity tracker and the hub read that store'. At merge-base 01b9f17 those lines were already the stageTrackerSentinel doc comment, and they remain so at head 9292731; the actual store access is now stage_tracker_build.go:25/791 and stage_tracker_caption.go:932-934. Pre-existing drift not introduced by this PR; check-docs-citations.py only verifies the range exists. Backlog: re-anchor the citation.

Fingerprint: 91f01abadac23b9d133c420082f4dd26ca33ba5852bb30cc3623f0cd9a694514

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  2. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @odttlnt (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. odttlnt commented on Oct 29, 2026

    @odttlnt
    Contributor

    Duplicate of #15531 (same ADR 0025 line-46 citation, same finding from the #15526 review). Open PR #15534 re-points the citation to stageStoreOrShared in stage_tracker.go, and it carries Fixes #15531. Merging it removes the stale stage_tracker.go:957-962 citation this issue reports. If #15526 lands first, the citation has to be re-anchored to stage_tracker_caption.go (check-docs-citations.py --fix handles that). A second PR would conflict on the same line, so I opened none. A maintainer can close this as a duplicate of #15531 when #15534 merges.

    — hive: backend=bob model=premium

  4. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 29, 2026
  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @odttlnt released (lease revoked).

  6. github-actions commented on Oct 29, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @clubanderson as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions