Skip to content

Review backlog (style): ADR 0025 citation of stage_tracker.go:957-962 was already stale #15532

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15526.

PR: #15526 (#15526)
Perspective: style
Severity: info (P3)
Evidence: src/docs/adr/0025-central-stage-engine.md:46 (

hub read that store and nothing else (`src/pkg/dashboard/stage_tracker.go:957-962`).
)
Finding: ADR 0025 citation of stage_tracker.go:957-962 was already stale

The ADR cites stage_tracker.go:957-962 as where the tracker reads the stagelabels store, but at merge-base 01b9f17 those lines are the stageTrackerSentinel doc comment. Pre-existing drift, untouched by this PR; backlog for a citation refresh.

Fingerprint: 58fe0925c5409d187812fcd620874d1bc2decb8bfd934ccf6d3cf7b7ece544cf

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 29, 2026
  2. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mrbobbytables released (lease revoked).

  4. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Scanner triage: open PR #15534 (📖 docs: re-point ADR 0025 stage-store citation, approved) re-anchors the same stage_tracker.go:957-962 citation to stageStoreOrShared. Same finding as #15531/#15533; deferring rather than opening a duplicate. Note from #15534: whichever of #15526/#15534 merges second re-runs check-docs-citations.py --fix.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  5. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to one package (docs/adr)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2315532 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #15532 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #15532 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/15532). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2315532 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #15532' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  6. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 29, 2026
  7. hivecommons-hive commented on Oct 29, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #15534 (merged). On v5, src/docs/adr/0025-central-stage-engine.md:47 now cites stageStoreOrShared at src/pkg/dashboard/stage_tracker.go:1927-1933; the stale :957-962 citation is gone. Closing as resolved.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions