Repository navigation
🐛 fix: stop the status symbols rotating on tracker chevrons - #15189
Conversation
Owner: 'i dont like the status symbols rotating - remove them from all chevrons'. The working glyph, the merge gate's sweep glyph and the acting caption's spinner are static icons now; the cue-spin keyframe is gone and nothing on a chevron or pill rotates. Class names stay so the sibling cue code and tests compose on them; a webstatic test asserts no rotating keyframe is applied to a tracker chevron or glyph class. Fixes #15187 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
|
Another agent tried to open a PR from |
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 36fb764. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
There was a problem hiding this comment.
Read src/pkg/dashboard/static/index.html at 36fb764 end to end for the affected classes. The chevron/pill part of this is correct: @keyframes cue-spin is gone, the working glyph and the gate's ⟳ (.cue-spin, index.html:1622) now have animation: none, and nothing else in the single <style> block animates .ham-active-ico / .ham-gate-ico / .cue-spin with a rotating keyframe. The new webstatic test checks exactly that and would go red if a rotating rule came back on those selectors.
One real gap: the Acting caption's spinner still rotates. The PR body says .cue-acting-spin … no longer rotates, but the cascade says otherwise:
index.html:18279creates the element assp.className = 'toast-spinner cue-acting-spin'.index.html:3454—.toast-spinner { … animation: spin 0.8s linear infinite; … }(@keyframes spinat:3475isrotate(360deg)).index.html:1623—.cue-acting-spin { color: var(--cue-work); animation: none; border-color: currentColor; }.
Both selectors are a single class (specificity 0,1,0), there is no @layer, and .toast-spinner comes later in the sheet, so its animation: spin wins over the animation: none added here. The border-color: currentColor added on the same line loses the same way to .toast-spinner's border: shorthand at :3454. Net effect: the 10 px spinner in the Approving… / Hive is deciding… / Holding… caption keeps turning, which is the one case the owner's "remove them from all chevrons" request would still hit on the strip.
The new TestStaticTrackerChevronGlyphsDoNotRotate cannot see this because the rotating rule's selector is .toast-spinner, which is not in its chevron regex; TestStageTrackerCuesWiring only pins the literal string. Smallest fix: give the override specificity or source order that beats .toast-spinner — e.g. .toast-spinner.cue-acting-spin { animation: none; border-color: currentColor; } (or .cue-acting-cap .cue-acting-spin) — and extend the test's chevron regex so a rule whose selector contains cue-acting-spin is checked against all rotating keyframes reaching that element (the simplest hook is to also assert .toast-spinner.cue-acting-spin has animation: none).
Everything else (dashboard-sections.md legend, changelog fragment, the cues-wiring pin updates) matches the diff. Severity: medium — the feature is mostly delivered, but the body's claim about the acting spinner is not what the browser will render.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Fixes #15187
Owner, verbatim: "i dont like the status symbols rotating - remove them from all chevrons".
What changed (
index.htmlCSS only).cue-working … .ham-active-ico, .cue-spin { animation: none; }— the working glyph on a lit chevron and the merge gate's ⟳ sweep glyph are static icons;@keyframes cue-spinis deleted..cue-acting-spin { animation: none; border-color: currentColor; }— the Acting caption's small spinner no longer rotates (a solid--cue-workring).cue-working,cue-spin,cue-acting-spin,ham-active-ico) stay so the sibling cue code, needs-human pulse semantics and tests compose on them. Non-rotating cues (needs-human breathe, acting stripes, merged glow) untouched; theprefers-reduced-motionrule stays.Tests / docs
TestStaticTrackerChevronGlyphsDoNotRotate(webstatic): collects every@keyframeson the page whose body rotates and asserts no rule addressing a tracker chevron / pill / glyph class animates with one; also assertscue-spinis gone. Verified red on the previous CSS.TestStageTrackerCuesWiringpins updated to the static rules.docs/dashboard-sections.md; changelog fragmentfixed-tracker-chevron-no-spin.md.