Skip to content

🐛 fix: stop the status symbols rotating on tracker chevrons - #15189

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-no-spin
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/tracker-no-spin

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #15187

Owner, verbatim: "i dont like the status symbols rotating - remove them from all chevrons".

What changed (index.html CSS only)

  • .cue-working … .ham-active-ico, .cue-spin { animation: none; } — the working glyph on a lit chevron and the merge gate's ⟳ sweep glyph are static icons; @keyframes cue-spin is deleted.
  • .cue-acting-spin { animation: none; border-color: currentColor; } — the Acting caption's small spinner no longer rotates (a solid --cue-work ring).
  • Tooltips / captions are unchanged and still say what the hive is doing ("hive's merge sweep is running on this PR now", "Working now: reviewer …").
  • Class names (cue-working, cue-spin, cue-acting-spin, ham-active-ico) stay so the sibling cue code, needs-human pulse semantics and tests compose on them. Non-rotating cues (needs-human breathe, acting stripes, merged glow) untouched; the prefers-reduced-motion rule stays.

Tests / docs

  • New TestStaticTrackerChevronGlyphsDoNotRotate (webstatic): collects every @keyframes on the page whose body rotates and asserts no rule addressing a tracker chevron / pill / glyph class animates with one; also asserts cue-spin is gone. Verified red on the previous CSS.
  • TestStageTrackerCuesWiring pins updated to the static rules.
  • Legend in docs/dashboard-sections.md; changelog fragment fixed-tracker-chevron-no-spin.md.

Owner: 'i dont like the status symbols rotating - remove them from all
chevrons'. The working glyph, the merge gate's sweep glyph and the acting
caption's spinner are static icons now; the cue-spin keyframe is gone and
nothing on a chevron or pill rotates. Class names stay so the sibling cue
code and tests compose on them; a webstatic test asserts no rotating
keyframe is applied to a tracker chevron or glyph class.

Fixes #15187

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15104 🐛 Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/docs/dashboard-sections.md
src/pkg/dashboard/stage_tracker_cues_test.go
src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15134 🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15122 🐛 Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15192 ✨ Conflict-aware merge train in the automerge lanes same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15186 🐛 Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15191 🐛 Let hive decide on a ready-for-human-merge PR approves and lets the sweep merge it same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html
#15157 ✨ Conflict-aware merge train in the automerge lanes same files src/docs/dashboard-sections.md
src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Another agent tried to open a PR from scanner/fix-15187, but this PR already closes #15187. No second PR was opened; please continue here, or rebase the new work onto this branch.

@hivecommons-hive
hivecommons-hive Bot merged commit 8e703c0 into v5 Oct 29, 2026
83 of 87 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/tracker-no-spin branch October 29, 2026 00:31
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1518936fb764` sha256:e4386b82f01925438f7811df508ea25b311d9434bf46801489564298b667790a — download from the dashboard or `hivectl review evidence #15189`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 36fb764.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read src/pkg/dashboard/static/index.html at 36fb764 end to end for the affected classes. The chevron/pill part of this is correct: @keyframes cue-spin is gone, the working glyph and the gate's ⟳ (.cue-spin, index.html:1622) now have animation: none, and nothing else in the single <style> block animates .ham-active-ico / .ham-gate-ico / .cue-spin with a rotating keyframe. The new webstatic test checks exactly that and would go red if a rotating rule came back on those selectors.

One real gap: the Acting caption's spinner still rotates. The PR body says .cue-acting-spin … no longer rotates, but the cascade says otherwise:

  • index.html:18279 creates the element as sp.className = 'toast-spinner cue-acting-spin'.
  • index.html:3454 — .toast-spinner { … animation: spin 0.8s linear infinite; … } (@keyframes spin at :3475 is rotate(360deg)).
  • index.html:1623 — .cue-acting-spin { color: var(--cue-work); animation: none; border-color: currentColor; }.

Both selectors are a single class (specificity 0,1,0), there is no @layer, and .toast-spinner comes later in the sheet, so its animation: spin wins over the animation: none added here. The border-color: currentColor added on the same line loses the same way to .toast-spinner's border: shorthand at :3454. Net effect: the 10 px spinner in the Approving… / Hive is deciding… / Holding… caption keeps turning, which is the one case the owner's "remove them from all chevrons" request would still hit on the strip.

The new TestStaticTrackerChevronGlyphsDoNotRotate cannot see this because the rotating rule's selector is .toast-spinner, which is not in its chevron regex; TestStageTrackerCuesWiring only pins the literal string. Smallest fix: give the override specificity or source order that beats .toast-spinner — e.g. .toast-spinner.cue-acting-spin { animation: none; border-color: currentColor; } (or .cue-acting-cap .cue-acting-spin) — and extend the test's chevron regex so a rule whose selector contains cue-acting-spin is checked against all rotating keyframes reaching that element (the simplest hook is to also assert .toast-spinner.cue-acting-spin has animation: none).

Everything else (dashboard-sections.md legend, changelog fragment, the cues-wiring pin updates) matches the diff. Severity: medium — the feature is mostly delivered, but the body's claim about the acting spinner is not what the browser will render.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Activity Monitor: stop the status symbols rotating on chevrons

1 participant