Skip to content

Activity Monitor: soak countdown missing on 'merge sweep running' and pre-admission soak rows; hover should show the live timer #15218

Closed

Description

@clubanderson

What's wrong

The Activity Monitor shows a soak countdown only on some 095 rows ("🕒 Soaking · 5m left"). Other soak-related rows read "Soaking · merge sweep running" or "Awaiting merge gate · merge sweep running" with no countdown at all:

  • the sweep_running branch of stageTrackerMergeGateInfoFor wins over the soak clock, so the countdown vanishes every time the sweep is on the PR;
  • the pre-admission soak (RouteHuman's soak Nm remaining at 060/080 in pkg/stagelabels/human.go) never reaches the tracker payload — only the 095 soak_remaining_seconds does — so a trust-blocked head sitting through the same window shows no clock.

Hovering the soak chevron shows a static sentence captured at render time, not the live time left.

What I want

  1. Every soak-related pill (060/080/095) carries soak: {started_at, until, window_s, head_sha} and shows the same countdown, ticking client-side; past until it reads "Soaking · ready — next sweep in Nm"; when the row's head is not the soaked head it reads "Soak restarted · new head".
  2. Hovering any soak pill / its chevron shows the live remaining time, e.g. "Head abc1234 must sit 30 minutes without new commits before the hive merges it · 12m 30s left · soak ends 8:42 PM", refreshed by the tick.
  3. No rotating glyphs (🐛 fix: stop the status symbols rotating on tracker chevrons #15189 removed them; keep them out).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions