Skip to content

✨ feat(contribute): record the blocker a relay's blocked verdict names - #15123

Merged
hivecommons-hive[bot] merged 1 commit into
v6from
hive/adopt-15029
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v6from
hive/adopt-15029

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15029 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).

Closes #15023

This branch is #15029's head af22bf0d5dc5 as pushed by @Karibhou (fork Karibhou/hive), unchanged. Last lane reason on the original: contributor-lane:claim-tier-untrusted.

Hive fix agent: rebase this branch on v6, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

When a contributor's blocked verdict names its blocker (owner/repo#N, #N,
or an issue/PR URL), the hub now records it on the task issue so the hive
lifts `blocked` itself once the blocker closes:

- an open issue becomes a native GitHub "blocked by" link, lifted by
  ReconcileHiveHardSuppress when every native blocker is closed;
- an open PR gets the existing `hive:blocked-on pr=` marker comment,
  lifted by the blocked sweep on merge or close;
- a closed or unreadable blocker records nothing (behaviour as before).

The write runs off the websocket read loop, checks the existing link or
marker first, and dedupes re-delivered verdicts per task. Tooling-failure
verdicts are reclassified idle before the hook and write nothing.

Hive-Run: #15023
Hive-Plan: issue-15023
Hive-Spec: issue-15023#change
Co-authored-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kiVsrUdeNxHpQC8bdZ
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15029 ✨ feat(contribute): record the blocker a relay's blocked verdict names same files changelog.d/added-15023-relay-blocked-blocker.md
src/docs/labels-and-control-signals.md
src/pkg/dashboard/contribute_verdict_blocker.go
src/pkg/dashboard/contribute_verdict_blocker_test.go
src/pkg/dashboard/contribute_ws.go
src/pkg/dashboard/contribute_ws_blocked_verdict_test.go
src/pkg/github/verdict_blocker.go
src/pkg/github/verdict_blocker_test.go
#15131 🐛 fix: pause the 074 stall clock while an adopted PR waits in the fixer queue same files src/docs/labels-and-control-signals.md

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit ea6e470 into v6 Oct 28, 2026
163 of 174 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15029 branch October 28, 2026 22:20
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15123af22bf0` sha256:584307e77022db2d34857c1caa29c198c4c04f3fa8fb5105a6af508461b5ec66 — download from the dashboard or `hivectl review evidence #15123`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant