Skip to content

✨ [v6] contribute: record the blocker a relay's blocked verdict names, so the hive lifts blocked when it closes #15023

Closed

Description

@Danathar

Target: v6.

Target branch: v6 only. Open the PR with --base v6. hive-open-pr defaults to the repo's default branch (v5) when --base is omitted.
Citations: path:line against v6 @ 7f89f9d01, paths relative to src/.

When a contributor's agent reports "blocked on #N", record that dependency so the hive lifts blocked itself once #N closes.

Background

A contributor relay applies blocked on a blocked verdict (markIssueBlocked → markIssueLabel, bin/contributor-relay.js ~8068-8134). It writes no marker and names no blocker the hive can read, so the only ways off blocked today are human: the #12376 park and /hive approve, per the #7924 decision. Meanwhile the dependency the agent found is lost. projectbluefin/testsuite#975 is blocked on the open issue server#450. Eight agents re-discovered that and re-posted it between 10-11 and 10-27.

A companion PR stops the hive lifting such relay-applied blocks every few minutes: #15022. This issue is the second half. When the verdict names its blocker, record it in a form the hive already lifts on close.

What exists

Change

  1. Parse the blocker. After the tooling reclassification at contribute_ws.go:4479, when the verdict is still blocked, parse verdictReason for one blocker reference: owner/repo#N, #N (the task's repo) or a GitHub issue or PR URL. If there are several, take the first.
  2. Resolve it with one Issues.Get (the App token, the hub's normal REST caller):
    • An open issue: call AddBlockedBy(taskRepo, taskIssue, blocker.GetID()). The existing ReconcileHiveHardSuppress path then lifts blocked when it closes, and the dashboard shows the dependency.
    • An open PR: post the existing BlockedOnMarker(repo, pr) comment on the blocked issue. It is lifted on merge or close.
    • Already closed, or the read fails: record nothing and log it. The block stays human-lifted, as today.
  3. Idempotence: do not add a native link or marker that already exists. Check fetchBlockedBy / the marker first, and dedupe per task.
  4. Do this off the websocket handler goroutine, as releaseToolingBlockedIssue is.
  5. Optional: let the sweep read <!-- hive:recheck-after … --> from comments as well as the issue body (blockedRecheck, issue_blocked.go:129). A relay could then set a deadline for an external blocker (a hosted run, an upstream release) without editing the issue body.

Acceptance criteria

  • A blocked verdict whose reason names an open issue in the same or another repo leaves a native "blocked by" link on the task issue. blocked stays until that issue closes and is then lifted by the existing reconcile, with no re-offer and no new agent comment in between.
  • A reason that names an open PR leaves a hive:blocked-on pr= marker, which is lifted on merge or close.
  • A reason with no resolvable reference behaves exactly as today.
  • No duplicate links or markers are created on a re-delivered verdict.

Test plan

  • Parsing: a table test for the blocker-reference parser: owner/repo#N, #N, an issue URL, a PR URL, prose with no reference, and two references (the first wins).
  • Hub tests next to pkg/dashboard/contribute_ws_blocked_verdict_test.go and contribute_blocked_tooling_test.go:
    • with a fake GitHub returning an open issue, AddBlockedBy is called once with the blocker's id;
    • with an open PR, the marker comment is posted;
    • with a closed target or a 404, nothing is written;
    • on re-delivery, nothing is written twice;
    • a tooling-reclassified verdict writes nothing.
  • End-to-end: an existing ReconcileHiveHardSuppress test, or a new one, shows a native blocker closing lifts the relay's blocked.
  • Unknown, check before shipping: whether AddBlockedBy accepts a blocker in another repo (testsuite#975 is blocked on server#450). If GitHub refuses, fall back to a marker form for issues, issue=owner/repo#N in the issue_blocked.go grammar, lifted on close.

Out of scope

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  2. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @Karibhou released (lease revoked).

  4. hivecommons-hive commented on Oct 28, 2026

    @hivecommons-hive
    Contributor

    Fixed by #15123 (merged ea6e470). Closing. Reply /reopen if the problem persists.

  5. github-actions commented on Oct 28, 2026

    @github-actions
    Contributor

    @Danathar this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions