Skip to content

πŸ› fix: open the needs-human popover on issue rows with a parked PR - #15118

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/15096-activity-monitor-decision-popover
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
Karibhou:fix/15096-activity-monitor-decision-popover

Conversation

@Karibhou

Copy link
Copy Markdown
Contributor

What

Fixes N1 from #15096: clicking or hovering the Needs human decision πŸ‘€ chevron on a stage-085 row (e.g. #14816, #14633, #15009, #14938) did nothing. aria-expanded stayed false, no .ham-decision-pop appeared and no JS error was logged. The same popover worked on Open Β· hold and 045 rows.

Root cause

An issue row with exactly one covering PR is drawn through an overlay in stageTrackerRowHtml (shown = Object.assign({}, item, { via_pr: true, …, decision_needed: lp.decision_needed })). The overlay keeps the issue's kind/number but carries the PR's decision_needed. stageTrackerDecisionOf took that borrowed decision as the row's own and keyed the trigger on the issue. When the popover opened, stageTrackerOpenDecisionPop looked up the real issue by that key, found no decision_needed and returned silently.

Hold and 045 rows were unaffected because their decision belongs to the issue itself.

Fix

stageTrackerDecisionOf now ignores the decision an overlay (via_pr) borrowed from its PR. It falls through to the existing nested-PR branch, which keys the trigger on …/pr#N. That is the target the row β‹― menu already uses (stageTrackerDecisionTarget), so the popover's actions now act on the PR rather than the issue.

Tests

TestStageTrackerDecisionPopoverContent gains two checks:

  • the via_pr overlay β†’ o/r/pr#7 with the PR item. This fails on the parent commit, which returns o/r/issue#3.
  • an issue asking its own question (045) still β†’ o/r/issue#3.

Per AGENTS.md, tests were not run locally; CI is the verdict.

Refs #15096: this PR covers only N1. G1–G12 and N2–N8 (working cue, age tooltips, decision trail, menu consequences, end states, untrusted-author label on hive PRs, …) are still open.

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01HRH6knCVwWzeZvA7u2ac3f

β€” hive: backend=claude model=claude-opus-5-5

An issue row with exactly one covering PR is drawn through an overlay
that keeps the issue's kind and number but carries the PR's
decision_needed. stageTrackerDecisionOf keyed that overlay on the issue,
so opening the popover looked up the real issue, found no decision and
returned silently: on every stage-085 row the "Needs human decision"
chevron stayed aria-expanded=false with no error (N1 in hivecommons#15096).

Skip the overlay's borrowed decision so the nested-PR branch keys the
trigger on the PR, as stageTrackerDecisionTarget already does for the
row menu.

Refs hivecommons#15096

Hive-Run: hivecommons#15096
Hive-Plan: issue-15096 N1 (decision popover on stage-085 rows)
Hive-Spec: activity-monitor-readability#N1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6knCVwWzeZvA7u2ac3f
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15134 πŸ› Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/pkg/dashboard/static/index.html
#15122 πŸ› Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/pkg/dashboard/static/index.html
#15150 πŸ› Activity Monitor: persist the merged count in a server ledger, pin the Merged chip, banner and bee flight on merge same files src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15104 πŸ› Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/pkg/dashboard/static/index.html
#15157 ✨ Conflict-aware merge train in the automerge lanes same files src/pkg/dashboard/static/index.html
#15156 πŸ› Activity Monitor: an owner's Approve admits the untrusted-author PR head β€” no adoption, merge as-is; DCO warned before acting same files src/pkg/dashboard/static/index.html

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed β€” no findings from this perspective.

β€” hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed (docs-currency) β€” one advisory, non-blocking.

changelog.d/fixed-activity-monitor-decision-popover-nested-pr.md:1 has no issue link. changelog.d/README.md ("Content: … what changed, why an operator cares, issue links"; example fragment at the bottom of the Format section) and the neighbouring fixed-* fragments (fixed-12846-kick-delivery.md, fixed-12969-decision-policy-fail-closed.md, fixed-13005.md) all close with the issue reference. Since this fixes only N1 of #15096 and the rest stays open, the link is what lets a reader of the release notes find the remaining items:

- Activity Monitor: the "Needs human decision" popover now opens on an issue row whose one covering PR is parked for a decision (stage 085); the trigger was keyed on the issue instead of the PR, so clicking or hovering did nothing (N1 of [#15096](https://github.com/hivecommons/hive/issues/15096)).

Otherwise current: the in-code comment at src/pkg/dashboard/static/index.html:17175-17179 was updated with the new via_pr rule, and no src/docs/ page describes the popover's trigger keying, so nothing else needs to move with this behavior.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ready for a human merge: verdict approved @ab0245a, 60/60 checks green, DCO yes, soak 30m0s elapsed. Blocked only by role/contributor (below require_tiers).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing labels Oct 28, 2026
@hivecommons-hive hivecommons-hive Bot added stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing and removed stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 28, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

Approved by @clubanderson for Hive auto-merge on green CI.

Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive hivecommons-hive Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#15118ab0245a` sha256:f6d9bc44f8c4a6458ad3a2a2f99c4d700d8fbbb6f0d305dab878c4b933a0475b β€” download from the dashboard or `hivectl review evidence #15118`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. role/contributor Author holds the contributor tier in this hive's registry; a human must lgtm/approve size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/090-ready-for-human-merge Hive would merge this but trust/role blocks it; a maintainer's /lgtm /approve is all that is missing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activity Monitor: operator-readability findings from a live walkthrough (12:11–16:59 ET, 0470256 β†’ aa9b530)

1 participant