Repository navigation
π fix: open the needs-human popover on issue rows with a parked PR - #15118
Conversation
An issue row with exactly one covering PR is drawn through an overlay that keeps the issue's kind and number but carries the PR's decision_needed. stageTrackerDecisionOf keyed that overlay on the issue, so opening the popover looked up the real issue, found no decision and returned silently: on every stage-085 row the "Needs human decision" chevron stayed aria-expanded=false with no error (N1 in hivecommons#15096). Skip the overlay's borrowed decision so the nested-PR branch keys the trigger on the PR, as stageTrackerDecisionTarget already does for the row menu. Refs hivecommons#15096 Hive-Run: hivecommons#15096 Hive-Plan: issue-15096 N1 (decision popover on stage-085 rows) Hive-Spec: activity-monitor-readability#N1 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRH6knCVwWzeZvA7u2ac3f Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Reviewed (docs-currency) β one advisory, non-blocking.
changelog.d/fixed-activity-monitor-decision-popover-nested-pr.md:1 has no issue link. changelog.d/README.md ("Content: β¦ what changed, why an operator cares, issue links"; example fragment at the bottom of the Format section) and the neighbouring fixed-* fragments (fixed-12846-kick-delivery.md, fixed-12969-decision-policy-fail-closed.md, fixed-13005.md) all close with the issue reference. Since this fixes only N1 of #15096 and the rest stays open, the link is what lets a reader of the release notes find the remaining items:
- Activity Monitor: the "Needs human decision" popover now opens on an issue row whose one covering PR is parked for a decision (stage 085); the trigger was keyed on the issue instead of the PR, so clicking or hovering did nothing (N1 of [#15096](https://github.com/hivecommons/hive/issues/15096)).
Otherwise current: the in-code comment at src/pkg/dashboard/static/index.html:17175-17179 was updated with the new via_pr rule, and no src/docs/ page describes the popover's trigger keying, so nothing else needs to move with this behavior.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Ready for a human merge: verdict approved @ab0245a, 60/60 checks green, DCO yes, soak 30m0s elapsed. Blocked only by The hive never approves on your behalf: |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Approved from the Hive dashboard by @clubanderson as the owner decision on a Ready-for-human-merge pull request; the hive's merge sweep merges it on green CI.
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hive queued this PR but could not set the |
What
Fixes N1 from #15096: clicking or hovering the
Needs human decision π€chevron on a stage-085 row (e.g. #14816, #14633, #15009, #14938) did nothing.aria-expandedstayedfalse, no.ham-decision-popappeared and no JS error was logged. The same popover worked onOpen Β· holdand 045 rows.Root cause
An issue row with exactly one covering PR is drawn through an overlay in
stageTrackerRowHtml(shown = Object.assign({}, item, { via_pr: true, β¦, decision_needed: lp.decision_needed })). The overlay keeps the issue'skind/numberbut carries the PR'sdecision_needed.stageTrackerDecisionOftook that borrowed decision as the row's own and keyed the trigger on the issue. When the popover opened,stageTrackerOpenDecisionPoplooked up the real issue by that key, found nodecision_neededand returned silently.Hold and 045 rows were unaffected because their decision belongs to the issue itself.
Fix
stageTrackerDecisionOfnow ignores the decision an overlay (via_pr) borrowed from its PR. It falls through to the existing nested-PR branch, which keys the trigger onβ¦/pr#N. That is the target the row β― menu already uses (stageTrackerDecisionTarget), so the popover's actions now act on the PR rather than the issue.Tests
TestStageTrackerDecisionPopoverContentgains two checks:o/r/pr#7with the PR item. This fails on the parent commit, which returnso/r/issue#3.o/r/issue#3.Per AGENTS.md, tests were not run locally; CI is the verdict.
Refs #15096: this PR covers only N1. G1βG12 and N2βN8 (working cue, age tooltips, decision trail, menu consequences, end states, untrusted-author label on hive PRs, β¦) are still open.
π€ Generated with Claude Code
https://claude.ai/code/session_01HRH6knCVwWzeZvA7u2ac3f
β hive: backend=claude model=claude-opus-5-5