Skip to content

🐛 fix(dashboard): keep PR rows visible when their drawn_under parent is filtered out - #15140

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15116
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15116

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

A PR covering several issues is drawn only under its drawn_under issue; other issues show an 'under #M' chip. When that issue is filtered out or paged away, the PR was drawn nowhere. The tracker now has the first listed covering issue draw it (later ones chip to that row).

Closes #15116
Closes #15119

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…is filtered out

A PR that closes several issues is drawn only under the issue named in drawn_under; the other issues show an 'under #M' chip. When that issue was filtered out or paged away, the PR had no strip anywhere. Rows now adopt such PRs: the first listed issue covering one draws it and later ones chip to that row.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15070 ✨ Activity Monitor: presence indicator (clanker online / offline / none) on the waiting-on pill same files src/pkg/dashboard/static/index.html
#15104 🐛 Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/pkg/dashboard/static/index.html
#15134 🐛 Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/pkg/dashboard/static/index.html
#15085 ✨ Activity Monitor: Adopt now and Reroute to another clanker for PRs waiting on a contributor's clanker same files src/pkg/dashboard/static/index.html
#14807 ✨ dashboard: stream Job pod logs in the terminal pane for sandbox.runtime: job agents same files src/pkg/dashboard/static/index.html
#15122 🐛 Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/pkg/dashboard/static/index.html
#15150 🐛 Activity Monitor: persist the merged count in a server ledger, pin the Merged chip, banner and bee flight on merge same files src/pkg/dashboard/static/index.html
#15118 🐛 fix: open the needs-human popover on issue rows with a parked PR same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stageTrackerAdoptOrphanPRs against the consumers at the PR head. Looks correct to me.

  • stageTrackerLinkedDrawnHere (index.html:15217-15220) treats drawn_under of 0 or the row's own number as "draw here" and anything else as the under #M chip, so rewriting the first covering issue's entry to 0 and later ones to the adopter's number produces exactly one strip plus chips pointing at a row that is actually on the page.
  • stageTrackerItemKey (index.html:18307) keys on repo/kind#number only, so copying the item with a new linked_prs does not disturb row reconciliation or the pinned-row logic.
  • The function is applied to the same page.rows projection the render loop uses (index.html:16651-16655), group-header entries map to null and are passed through untouched, and the owner/other identity assertions in the test pin that unchanged rows are not copied.

One consequence worth knowing, not a defect: adoption runs after sort and pagination, so a PR whose owner issue is on page 2 is now drawn on page 1 (under the adopter) and again on page 2 (under its owner). The PR body says "paged away" is in scope, so I read that as intended.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit fe748c9 into v5 Oct 28, 2026
84 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15116 branch October 28, 2026 22:44
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15140a244919` sha256:efac00430c7c601a9af6201c95695d8ceaa114bc9e323e0f8bfdd6a053dac809 — download from the dashboard or `hivectl review evidence #15140`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

0 participants