Repository navigation
🐛 fix(dashboard): keep PR rows visible when their drawn_under parent is filtered out - #15140
Conversation
…is filtered out A PR that closes several issues is drawn only under the issue named in drawn_under; the other issues show an 'under #M' chip. When that issue was filtered out or paged away, the PR had no strip anywhere. Rows now adopt such PRs: the first listed issue covering one draws it and later ones chip to that row. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read stageTrackerAdoptOrphanPRs against the consumers at the PR head. Looks correct to me.
stageTrackerLinkedDrawnHere(index.html:15217-15220) treatsdrawn_underof0or the row's own number as "draw here" and anything else as theunder #Mchip, so rewriting the first covering issue's entry to0and later ones to the adopter's number produces exactly one strip plus chips pointing at a row that is actually on the page.stageTrackerItemKey(index.html:18307) keys onrepo/kind#numberonly, so copying the item with a newlinked_prsdoes not disturb row reconciliation or the pinned-row logic.- The function is applied to the same
page.rowsprojection the render loop uses (index.html:16651-16655), group-header entries map tonulland are passed through untouched, and theowner/otheridentity assertions in the test pin that unchanged rows are not copied.
One consequence worth knowing, not a defect: adoption runs after sort and pagination, so a PR whose owner issue is on page 2 is now drawn on page 1 (under the adopter) and again on page 2 (under its owner). The PR body says "paged away" is in scope, so I read that as intended.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
A PR covering several issues is drawn only under its drawn_under issue; other issues show an 'under #M' chip. When that issue is filtered out or paged away, the PR was drawn nowhere. The tracker now has the first listed covering issue draw it (later ones chip to that row).
Closes #15116
Closes #15119
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88