Skip to content

πŸ› fix(sandbox): take PR title/body from the workspace or HEAD commit - #14700

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
feat/sandbox-pr-title-body
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
feat/sandbox-pr-title-body

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Why

Every PR opened by the sandbox executor is titled [<agent>] sandbox changes with body Sandboxed credential-free execution result for agent ... Part of #2804. β€” a fixed placeholder that also drops hive's own tracker number into the target repo. Live example: torch-spyre/spyre-inference#1402, where the agent had written a full description (PR_torch_spyre_bump.md) that never reached the PR because the Job holds no GitHub credential and only the executor can open it.

What

sandboxPRText resolves, in order:

  1. .hive/pr-title.txt (first line) and .hive/pr-body.md written by the agent in the workspace;
  2. the HEAD commit's subject / body;
  3. a neutral placeholder naming the agent (no #2804).

Title bounded to 200 runes, body to 60k. Doc line added to sandbox-isolation.md step 5 so kick templates know to write the two files. Tests cover all three tiers and the bound.

Follow-up from #14662 / #14691 (a1-vllm-spyre spoke).

Test

cd src/crux && go test ./agent/ β€” ok.

Every sandbox-opened PR was titled "[<agent>] sandbox changes" with the
body "Sandboxed credential-free execution result ... Part of #2804" β€” a
placeholder that also cross-referenced hive's own issue number in the
target repo (torch-spyre/spyre-inference#1402 is a live example). The
agent inside the Job cannot open the PR itself, so its description had
no path to the PR.

Resolve title/body in order: .hive/pr-title.txt (first line) and
.hive/pr-body.md written by the agent, then the HEAD commit subject/body,
then a neutral placeholder. Bounded to 200 / 60000 runes.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

@clubanderson is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot added author/human A person pushed this PR themselves dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 881313a into v5 Oct 27, 2026
78 of 83 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/sandbox-pr-title-body branch October 27, 2026 20:34
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1470078b8a11` sha256:92dd6d2ecf8a01a7f9eb9ec0684a65e4ff256715b7a8d026fe29f5538606e328 β€” download from the dashboard or `hivectl review evidence #14700`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at 78b8a11.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/human A person pushed this PR themselves dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant