Skip to content

πŸ› dashboard: GitHub API budget tile too narrow for caller table - #12205

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
fix/12203-api-budget-tile-width
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
fix/12203-api-budget-tile-width

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #12203

Root cause

#debug-grid is repeat(auto-fit, minmax(280px, 1fr)) and .gh-api-budget-card was a plain one-cell item. The six-column per-caller table (full endpoint paths) has a min-content width far wider than 280px; with the default min-width: auto the grid item grew to that width and the overflow was clipped by the section card β€” Endpoint truncated, Charged/Req/304/429 invisible, and Caller abutting Endpoint because cells had no padding.

Change

  • .gh-api-budget-card: grid-column: span 2 (back to span 1 at ≀640px where tiles are full width anyway) and min-width: 0.
  • Table: table-layout: fixed, per-column width classes, cell padding, white-space: nowrap; text-overflow: ellipsis, title tooltips with the full caller/endpoint, right-aligned tabular numerics, header tooltips for Charged/Req/304/429.
  • Wrapper keeps overflow-x: auto as a last-resort fallback so columns are never silently cut.
  • CSS classes only (no new inline style=, per TestStyleRatchet).
  • TestDashboardRateLimitUIUsesRemainingSemantics extended to assert the wide span / fixed-layout / tooltip snippets.
  • Changelog fragment changelog.d/fixed-12203-api-budget-tile-width.md.

Verification

Rendered renderGitHubAPIBudgetPanel with mocked top_consumers in headless Chrome at 1440px inside a replica of the debug grid: tile spans two cells, all six columns visible, long endpoint ellipsised.

The Diagnostics GitHub API budget tile sat in one 280px cell of the
auto-fit debug grid. Its six-column per-caller table forced the grid
item past its cell (min-width:auto) and the overflow was clipped, so
Endpoint was truncated and Charged/Req/304/429 were never visible.

Span the card across two grid cells (one on <=640px), set min-width:0,
use table-layout:fixed with ellipsised cells and full-path tooltips,
add cell padding, and keep horizontal scroll as a last-resort fallback.

Closes #12203

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12193 πŸ› dashboard: profile menu does not open on mobile navbar same files src/pkg/dashboard/static/index.html
#12158 ✨ review: add review.shadow to record would_have_held for the review gate same files src/pkg/dashboard/static/index.html
#12170 πŸ› Settings modal: sticky-section gap, height, and section navigation same files src/pkg/dashboard/static/index.html
#12182 ✨ intent: add intent.shadow to record would_have_blocked same files src/pkg/dashboard/static/index.html
#12187 ✨ dashboard settings: agent_sandbox scalar settings same files src/pkg/dashboard/static/index.html
#12186 ✨ Hive-curated good first issues to attract contributors with their own coding agents same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor

merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at e1fc661.

@kubestellar-prow
kubestellar-prow Bot deleted the fix/12203-api-budget-tile-width branch October 15, 2026 20:57
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: GitHub API budget tile too narrow for caller table

1 participant