Repository navigation
π dashboard: GitHub API budget tile too narrow for caller table - #12205
Conversation
The Diagnostics GitHub API budget tile sat in one 280px cell of the auto-fit debug grid. Its six-column per-caller table forced the grid item past its cell (min-width:auto) and the overflow was clipped, so Endpoint was truncated and Charged/Req/304/429 were never visible. Span the card across two grid cells (one on <=640px), set min-width:0, use table-layout:fixed with ellipsised cells and full-path tooltips, add cell padding, and keep horizontal scroll as a last-resort fallback. Closes #12203 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
merged by Hive trusted-author auto-merge: author @clubanderson holds role owner and GitHub permission admin on repo; CI green at e1fc661. |
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #12203
Root cause
#debug-gridisrepeat(auto-fit, minmax(280px, 1fr))and.gh-api-budget-cardwas a plain one-cell item. The six-column per-caller table (full endpoint paths) has a min-content width far wider than 280px; with the defaultmin-width: autothe grid item grew to that width and the overflow was clipped by the section card β Endpoint truncated, Charged/Req/304/429 invisible, and Caller abutting Endpoint because cells had no padding.Change
.gh-api-budget-card:grid-column: span 2(back tospan 1at β€640px where tiles are full width anyway) andmin-width: 0.table-layout: fixed, per-column width classes, cell padding,white-space: nowrap; text-overflow: ellipsis,titletooltips with the full caller/endpoint, right-aligned tabular numerics, header tooltips for Charged/Req/304/429.overflow-x: autoas a last-resort fallback so columns are never silently cut.style=, perTestStyleRatchet).TestDashboardRateLimitUIUsesRemainingSemanticsextended to assert the wide span / fixed-layout / tooltip snippets.changelog.d/fixed-12203-api-budget-tile-width.md.Verification
Rendered
renderGitHubAPIBudgetPanelwith mockedtop_consumersin headless Chrome at 1440px inside a replica of the debug grid: tile spans two cells, all six columns visible, long endpoint ellipsised.