Skip to content

✨ dashboard settings: agent_sandbox scalar settings - #12187

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-11854
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-11854

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Exposes agent_sandbox image, runtime, network_mode, timeout_s, workspace_dir, env_allowlist and job service_account/ttl_seconds/workspace_claim/workspace_claim_mount in Settings → Security (Advanced sandbox); allowlist 538 → 528.

Refs #11854 (remaining: agent_sandbox.job node_selector/tolerations/resources/volumes/env_from_secrets, and agents., governor., knowledge., project., hub., runs., review., github., variables.*, etc. in settings_parity_allowlist.txt)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12182 ✨ intent: add intent.shadow to record would_have_blocked CONFLICT src/pkg/dashboard/api_governor_security.go
#12158 ✨ review: add review.shadow to record would_have_held for the review gate same files src/pkg/dashboard/static/index.html
#12170 🐛 Settings modal: sticky-section gap, height, and section navigation same files src/pkg/dashboard/static/index.html

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 15, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage: test (rest 2/5) is red here for a PR-local reason (green on v6 at 20:53Z). pkg/dashboard/webstatic TestStyleRatchet fails on all retries:

  • operator static/index.html has 1508 style= attributes, above the baseline of 1506
  • operator static/index.html has 633 raw font-size declarations, above the baseline of 632

The new agent_sandbox scalar settings rows add two inline style= attributes and one raw font-size to static/index.html. The ratchet only goes down: move the new inline styling onto existing classes/tokens (tokens.css / components.css) so the counts return to ≤1506 / ≤632. Do not raise styleRatchetBaselines in style_ratchet_test.go.

Job: https://github.com/hivecommons/hive/actions/runs/38802410315/job/116655036908


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

…details to keep the style ratchet flat

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: pushed a ratchet fix — test (rest 2/5) failed on TestStyleRatchet because this PR's Settings markup added an inline style= attribute to src/pkg/dashboard/static/index.html (operator page 1507 > baseline 1506). Replaced it with the existing tokenized classes; the "hub static pages below baseline" lines in the same log are a stale-merge-base artifact already fixed on v5 (#12173). CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 584495bf1

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 75c22e4 into v5 Oct 15, 2026
70 of 71 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-11854 branch October 15, 2026 21:50
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants