Skip to content

✨ intent: add intent.shadow to record would_have_blocked - #12182

Merged
hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-12105
Oct 15, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
v5from
scanner/fix-12105

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Adds intent.shadow (default false). While intent.enforce is off, both merge lanes sharing intent.Verdict.BlocksMerge — writeMergeEligible (merge-eligible.json) and the App self-merge sweep (automerge.IntentGate) — evaluate BlocksMerge(true) and record shadow.intent.would_have_blocked (+ reason, tier, alignment confidence) on the PR head evidence bundle and audit log, never withholding the PR. enforce: true is unchanged; shadow is ignored then.

  • Config: IntentConfig.Shadow; dashboard Security tab toggle + intentShadow on the governor security API (openapi updated).
  • Mirrors the shape of ✨ review: add review.shadow to record would_have_held for the review gate #12158 (review.shadow); helpers live in a new cmd/hive/intent_shadow.go to avoid conflicts.
  • Shared helpers Verdict.BlockReason / Verdict.ShadowConfidence in pkg/intent.
  • Tests: shadow on -> eligible/merged + record in both lanes; enforce on -> still blocked, no record.
  • Docs: src/docs/intent-verification.md; changelog fragment.

Closes #12105
Refs #12068 (parent tracker; other children remain open)

— hive: agent=scanner backend=copilot model=claude-fable-5.1 requested_by=@clubanderson

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 15, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#12158 ✨ review: add review.shadow to record would_have_held for the review gate same files src/cmd/hive/merge_eligibility.go
src/pkg/config/config.go
src/pkg/dashboard/static/index.html
#12170 🐛 Settings modal: sticky-section gap, height, and section navigation same files src/pkg/dashboard/static/index.html

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

CI triage: test (rest 2/5) is red here for a PR-local reason (green on v6 at 20:53Z). pkg/dashboard/webstatic TestStyleRatchet fails on all retries:

  • operator static/index.html has 1507 style= attributes, above the baseline of 1506 — the new intent.shadow settings markup adds one inline style=; move it onto an existing class/token so the count returns to ≤1506. Do not raise the baseline.
  • hub static pages is reported below its baselines (945/426/448 vs 946/427/450) — that means this branch's style_ratchet_test.go baselines predate a cleanup already on v6; rebasing onto current v6 picks up the lowered baselines.

Job: https://github.com/hivecommons/hive/actions/runs/38799200092/job/116643940945


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: pushed a ratchet fix — test (rest 2/5) failed on TestStyleRatchet because this PR's Settings markup added an inline style= attribute to src/pkg/dashboard/static/index.html (operator page 1507 > baseline 1506). Replaced it with the existing tokenized classes; the "hub static pages below baseline" lines in the same log are a stale-merge-base artifact already fixed on v5 (#12173). CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 584495bf1

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 15, 2026
scanner added 2 commits October 15, 2026 17:59
Signed-off-by: scanner <scanner@hive.kubestellar.io>
… style ratchet flat

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: rebased onto v5 (resolved api_governor_security.go conflict with the sandbox-job fields); CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 77b44cb2a

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 5dee401 into v5 Oct 15, 2026
70 of 71 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-12105 branch October 15, 2026 22:08
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] ✨ review: intent.shadow — record would_have_blocked for intent verification

0 participants