Skip to content

πŸ› close verified already-done PR verdicts - #10717

Merged
clubanderson merged 1 commit into
v5from
fix/already-done-close-merged-pr
Oct 5, 2026
Merged

clubanderson merged 1 commit into
v5from
fix/already-done-close-merged-pr

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • close verified hive/already-done contributor verdicts when the cited PR is API-verified as merged on the default branch
  • run closure through the existing issue close path with state_reason: completed, so human-filed bugs still wait for reporter confirmation unless opted in
  • restore hive/already-done to its contributor hard-skip/display role by removing the claim/agent-kick suppression added in πŸ› suppress claims on already-done issuesΒ #10706
  • update contributor/label docs and add a changelog fragment

Validation

  • gofmt -l on touched Go files
  • git diff --check
  • local test suites not run per AGENTS.md; CI is authoritative

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 5, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2026
clubanderson added a commit that referenced this pull request Oct 5, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Apply the already-done label and run the completed issue close path when a contributor verdict cites a PR that GitHub verifies as merged on the default branch.

Restore already-done to its contributor hard-skip role instead of blocking claim creation; reporter-confirmation gates still leave human-filed bugs open for confirmation.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson force-pushed the fix/already-done-close-merged-pr branch from 281849b to 872c448 Compare October 5, 2026 21:22
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10716 πŸ› fix: Most effective models filters, run rates and local-registry labels same files src/docs/contributor-relay.md
#10533 πŸ› fix: refuse automated claims on needs-human issues same files src/cmd/hive/claimswire.go
src/cmd/hive/main.go
src/pkg/dashboard/contribute_ws.go

@clubanderson
clubanderson merged commit 6eebdab into v5 Oct 5, 2026
44 of 45 checks passed
@clubanderson
clubanderson deleted the fix/already-done-close-merged-pr branch October 5, 2026 21:42
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant