Skip to content

πŸ› suppress claims on already-done issues - #10706

Merged
clubanderson merged 5 commits into
v5from
fix/already-done-claim-suppress
Oct 5, 2026
Merged

clubanderson merged 5 commits into
v5from
fix/already-done-claim-suppress

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Summary

  • soft-suppress hive/already-done issues from agent kick prompts and contributor offers without turning the label into a hard hold
  • refuse new issue claims on already-done issues and leave a short comment pointing to the merged fixing PR when the claim ledger has one
  • document the hive/already-done rule and add a changelog fragment

Validation

  • gofmt -l on touched Go files
  • git diff --check
  • local go test not run per AGENTS.md; CI is the test verdict

clubanderson and others added 2 commits October 5, 2026 16:18
Treat hive/already-done as a soft suppression for contributor offers and agent kick claims, and refuse new issue claims with a short pointer to the merged fix.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2026
clubanderson and others added 3 commits October 5, 2026 20:19
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Use the repository-level changelog fragment added for PR #10706.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Update generated API reference source line citations after claims route imports shifted.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson
clubanderson merged commit bc97448 into v5 Oct 5, 2026
38 of 46 checks passed
@clubanderson
clubanderson deleted the fix/already-done-claim-suppress branch October 5, 2026 20:54
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#10533 πŸ› fix: refuse automated claims on needs-human issues same files src/cmd/hive/claimswire.go
src/cmd/hive/main.go
#10717 πŸ› close verified already-done PR verdicts same files src/cmd/hive/claimswire.go
src/cmd/hive/main.go
src/docs/api-reference.md
src/docs/labels-and-control-signals.md
src/pkg/dashboard/claims_api.go
src/pkg/dashboard/claims_api_test.go
src/pkg/github/issue_claims.go
src/pkg/github/issue_claims_test.go

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant