Repository navigation
π fix: preserve PR attribution before Hive identity footer - #10705
hivecommons-hive[bot] merged 1 commit into
Conversation
Recognize only the terminal identity block emitted by gh-wrapper, then keep the existing final-attribution-line rule. Cover production footer variants, rejected prose and quoted examples, open/closed PR collection, and effective-model ranking eligibility. Hive-Run: hivecommons#10686 Hive-Plan: identity-footer-attribution Hive-Spec: issue-10686#expected-behavior Co-authored-by: arteeh <35239587+arteeh@users.noreply.github.com> Signed-off-by: mendezr <mendezr@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Read the parser and the emitter it has to match. This looks correct to me.
bin/gh-wrapper.sh:1061-1067β_identity_footeremits exactly---\nπ **Hive Agent**:+ optional`name`+ optional| **Instance:** `id`+| **SHA:** `sha`. The newattributionIdentityFooterregex insrc/pkg/github/attribution.go:301mirrors that shape token-for-token, including both optional groups, and is anchored to end-of-body so a footer followed by prose is still rejected (covered byTestParseAttributionTrailerDoesNotScanPastOrdinaryContent).HIVE_SHAis${HIVE_SHA:-$(git rev-parse --short HEAD) || unknown}(gh-wrapper.sh:1058), so the`[^`\n]+`SHA group can't fail on an empty value.- Stripping happens before the existing last-non-blank-line scan at
attribution.go:305-313, so the rest of the parser β including the "earlier mentions are ignored" rule β is unchanged.HasAttributionTraileris untouched. - The
\r\nnormalisation now happens before the regex runs, so CRLF bodies (tested) work.
Minor: the diff fully fixes #10686 β Closes #10686 rather than Refs would close it on merge; "reporter confirmation after rescan" isn't a reason to keep the issue open.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Summary
gh-wrapper.shbefore applying the existing final-attribution-line rule.Refs #10686. Not deployed yet; reporter confirmation should follow deployment and rescan.
Validation
gofmt -lon all changed Go files: clean.AGENTS.md; CI is the test verdict.β hive: backend=pi model=openai-codex/gpt-6.1-sol
π Hive Agent:
contributor| SHA:89e7ca3a6