Repository navigation
🐛 Hive/ClankeR PRs omit or suppress Closes/Fixes keywords so issues stay open after merge #10825
Description
Evidence
Checked with gh pr view N --repo hivecommons/hive --json body,closingIssuesReferences,author,baseRefName,mergedAt on 2026-10-06.
| PR | Author | Base | Body reference | closingIssuesReferences |
|---|---|---|---|---|
| #10823 | mendezr | v5 | Refs #10816 (human-reported bug; reporter confirmation required after deployment) |
empty |
| #10822 | mendezr | v5 | Refs #10773 (human-filed bug; reporter confirmation required before closure) |
empty |
| #10815 | mendezr | v5 | Refs #10771. Reporter confirmation remains required before closing this human-filed bug. |
empty |
| #10705 | mendezr | v5 | Refs #10686. Not deployed yet; reporter confirmation should follow deployment and rescan. |
empty |
| #10642 | mendezr | v5 | Fixes #10626 |
[10626] |
| #10636 | mendezr | v5 | Fixes #10627. |
[10627] |
| #10778 | hivecommons-hive[bot] | v5 | watcher-rewritten Refs #10774 — closing keyword withheld ... human-filed bug: reporter must confirm ... |
empty |
| #10819 | hivecommons-hive[bot] | v5 | agent-authored Refs #10773 (remaining: #10817, #10818 ...) |
empty |
| #10798 | hivecommons-hive[bot] | v5 | Closes #10753 ... Closes #10758 |
[10753,10754,10755,10756,10757,10758] |
| #10779 | hivecommons-hive[bot] | v5 | Closes #10599 plus Part of #10552 |
[10599] |
| #10810 | hivecommons-hive[bot] | v5 | Closes #10682 |
[10682] |
All sampled PRs target v5, the repository default branch, so GitHub populates closingIssuesReferences only when the body uses a closing keyword.
User-visible consequence: non-closing Refs #N leaves GitHub's issue list and issue sidebar without a linked-PR indicator. The maintainer's is:issue state:open label:hive/likely-done screenshot shows #10820, #10795, #10774, and #10773 with no PR link icon even though merged PRs exist. Fixes/Closes/Resolves against the default branch are the relationship GitHub exposes as closingIssuesReferences and as the linked PR icon/sidebar entry.
Additional issue evidence for #10774 after #10778 merged:
2026-10-06T05:05:12Zgithub-actionsposted<!-- hive-post-merge-refs-sweep: issue=10774 -->asking whether the issue could now be closed because PR 🐛 fix(rotation): race-free stale-lock takeover in codex_reset_redeem #10778 merged with non-closingRefs #10774.2026-10-06T05:10:44Zhivecommons-hivepostedReporter-confirmation gate: ... leaving it open until the reporter confirms the symptom is gone.
Root cause
There are two affected paths:
- Hosted/scanner bot path:
src/pkg/policies/defaults/scanner-automerge.md:133tells agents to useCloses #N, butsrc/pkg/github/pr_request_claims.gothen callshumanFiledBugReasonfromvalidatePRRequestClaimsand rewrites a human-filed bug'sCloses/Fixes/Resolves #Nto non-closingRefs #N. The rewrite is visible in 🐛 fix(rotation): race-free stale-lock takeover in codex_reset_redeem #10778 and was documented insrc/docs/hive-open-pr.md/src/docs/labels-and-control-signals.mdas deliberate reporter-confirmation behavior. - Contributor/ClankeR lane:
src/pkg/dashboard/contribute_task_prompt.go(artifact trailer prompt from8b267ad2f9) carried issue references/trailers but had no equivalent closing-keyword instruction. Contributor PRs are opened directly withgh pr create, so they also had no deterministic body post-check before submission.
Maintainer policy now desired: PR bodies should keep Fixes/Closes #N; if Hive wants reporter confirmation, that should be handled in Hive's close/verify path after merge, not by suppressing GitHub's PR closing relationship in the PR body.
Expected
For issue-backed Hive/ClankeR PRs targeting the default branch, the PR body should include a GitHub closing keyword (Closes #N, or Fixes #N for bugs) unless the PR is truly partial/tracker work and says why the issue remains open. That restores GitHub linked-PR sidebar/list linkage for every agent lane (hosted scanner/App-bot lanes and ClankeR/contributor lane). Human-filed bug reporter confirmation should be enforced by the issue close gate.
Activity
[-]🐛 clanker PRs omit Closes/Fixes keywords so issues stay open after merge[/-][+]🐛 Hive/ClankeR PRs omit or suppress Closes/Fixes keywords so issues stay open after merge[/+]