You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[scanner] 🐛 dashboard: surface Prow's rejection of relayed /lgtm /approve instead of showing approved #17475
Part of #17451 (fork PRs from non-member agents stall on Prow presubmits).
Problem
On #17359 the dashboard relayed /lgtm and /approve as hivecommons-hive[bot]; Prow replied "changing LGTM is restricted to collaborators" and "NOT APPROVED … please assign danathar". The board showed the action as approved while no lgtm/approved label ever appeared and reviewDecision stayed empty.
dibs#510 added repoItemApproveFacts.Prow and CommandsSkipped = "prow-rejects-bot-commands" in src/pkg/dashboard/api_repo_item_decision.go, so the toast no longer claims Prow approval on a repo already known to reject the bot.
Scope of this child
Verify what dibs#510 left open on a Prow repo where the rejection has not yet been observed, and close the gap:
After the relayed /lgtm / /approve post, read Prow's reply comment on the PR (the "restricted to collaborators" / "NOT APPROVED" reply) and surface it in the row action result / stage tracker instead of a plain "approved" outcome.
Persist the rejection so later approvals on the same repo take the CommandsSkipped path without re-posting.
Activity