Skip to content

[scanner] 🐛 dashboard: surface Prow's rejection of relayed /lgtm /approve instead of showing approved #17475

Closed

Description

@hivecommons-hive

Part of #17451 (fork PRs from non-member agents stall on Prow presubmits).

Problem

On #17359 the dashboard relayed /lgtm and /approve as hivecommons-hive[bot]; Prow replied "changing LGTM is restricted to collaborators" and "NOT APPROVED … please assign danathar". The board showed the action as approved while no lgtm/approved label ever appeared and reviewDecision stayed empty.

dibs#510 added repoItemApproveFacts.Prow and CommandsSkipped = "prow-rejects-bot-commands" in src/pkg/dashboard/api_repo_item_decision.go, so the toast no longer claims Prow approval on a repo already known to reject the bot.

Scope of this child

Verify what dibs#510 left open on a Prow repo where the rejection has not yet been observed, and close the gap:

Posting with the approving human's token or adding the App to OWNERS is a maintainer action and is out of scope here.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthas-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions