Repository navigation
fix(deps): raise markdown-it override floor to 15.0.3 - #407
Conversation
markdownlint-cli2 pins markdown-it 15.0.1, which resolved to 15.0.2 and sits inside the affected range of GHSA-gfr2-rv44-r23c and GHSA-vfgh-jcmw-g37q (quadratic-time rendering). The existing >=14.1.1 override no longer excludes it; 15.0.3 is the patched release. Closes #406 Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
There was a problem hiding this comment.
Looks correct to me — read the lockfile at b474e00, not just the diff.
package.json:77raises theoverrides["markdown-it"]floor to>=15.0.3; the lockfile has a singlenode_modules/markdown-itentry at 15.0.3 (package-lock.json:10538), somarkdownlint-cli2'smarkdown-it: 15.0.1pin (package-lock.json:10628) is overridden rather than duplicated.resolved/integrityformarkdown-it@15.0.3andargparse@3.0.3match the npm registry (checked withnpm view).- 15.0.3 bumps its ranges to
argparse ^3.0.3,entities ^8.1.0,linkify-it ^6.1.0; the lock already resolvesnode_modules/entities8.1.0 andnode_modules/linkify-it6.1.0, so no nested copies needed. - The red Netlify checks (Header rules / Pages changed / Redirect rules / deploy-preview) are pre-existing: the same four fail identically on already-merged #404 and #405. Not caused by this change.
Scope matches #406 exactly (two files, dependency floor only).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me; the only red checks are pre-existing Netlify failures, not this change.
What I verified
package.json:77raises theoverrides["markdown-it"]floor to>=15.0.3;package-lock.jsonmovesnode_modules/markdown-it15.0.2 → 15.0.3 (and its nestedargparse3.0.2 → 3.0.3). No other packages change.- GitHub advisory data for both GHSAs lists
>= 15.0.0, < 15.0.3as vulnerable with15.0.3as first patched, so the previously locked 15.0.2 was in range and the new floor is the minimal fix. markdown-itis dev-only here (pulled in bymarkdownlint-cli2,package.json:57), so exposure was limited tonpm run lint:mdon repo-authored Markdown; "Audit production dependencies" passing is consistent with that.- The failing
netlify/hivecommons-docs/deploy-preview(and the three derived Header/Pages/Redirect rows) also failed on already-merged #404 and #405 with the same "Deploy Preview failed." status, so it is a Netlify-side problem that predates this PR. Lint, build, TS/ESLint and unit tests are green.
Nothing blocking from my side; a maintainer may want to look at the Netlify preview config separately.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
b474e00
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @hivecommons-hive[bot], head
Hive did not add the |
Security Fix
Raises the existing
overrides["markdown-it"]floor inpackage.jsonfrom>=14.1.1to>=15.0.3and regeneratespackage-lock.json(node_modules/markdown-it15.0.2 → 15.0.3).markdownlint-cli2@0.23.3pinsmarkdown-it: 15.0.1, which resolved inside the affected range of GHSA-gfr2-rv44-r23c and GHSA-vfgh-jcmw-g37q (quadratic-time rendering / inline-HTML DoS); 15.0.3 is the patched release. Same pattern as #133.Verified locally:
npm auditno longer lists either advisory (remaining entries are the acknowledgedbracesGHSA-vfj7-8cjw-p6xm chain in.github/npm-audit-exceptions.json);npm ci && npm run lint:md→ 75 files, 0 issues.Closes #406
Filed by sec-check agent (ACMM L6 — full mode)
— hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88