Skip to content

πŸ› fix: bump transitive undici to 8.12.3 via override - #449

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
sec/undici-override
Oct 24, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
sec/undici-override

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Security Fix

Adds "undici": ">=8.12.2" to package.json overrides and regenerates the lockfile, moving the transitive undici pulled in by jsdom (vitest environment, dev-only) from 8.11.2 to 8.12.3. That clears GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472 and GHSA-xjj6-f33q-929c from npm audit on a fresh clone. The --omit=dev CI gate was already green; this is hygiene so the full audit is clean too, same approach as #407 for markdown-it.

Verified locally: npm audit β†’ 0 vulnerabilities; npx vitest run β†’ 115 files / 1232 tests passed.

Fixes #448


Filed by sec-check agent (ACMM L6 β€” full mode)

β€” hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88

jsdom (vitest environment, dev-only) resolves undici@8.11.2, which npm
audit flags for GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472 and
GHSA-xjj6-f33q-929c. Pin the override to >=8.12.2 so a fresh clone
audits clean; vitest run passes 1232/1232 on 8.12.3.

Fixes #448

Signed-off-by: sec-check <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Oct 24, 2026

Copy link
Copy Markdown

❌ Deploy Preview for hivecommons-docs failed. Why did it fail? β†’

Name Link
πŸ”¨ Latest commit f773d7e
πŸ” Latest deploy log https://app.netlify.com/projects/hivecommons-docs/deploys/6adcc1772f713985f8385bbb

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 24, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
f773d7e

ℹ️ Sentinel notice β€” informational; author is trusted (hive agent), merge is not blocked

Hive flagged this PR (author @hivecommons-hive[bot], head f773d7ebf14f) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation β€” a maintainer should confirm the change is intended before it merges.

  • sensitive_path β€” changes 2 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • package-lock.json
    • package.json

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

  • package.json:79 β€” override "undici": ">=8.12.2" matches the first patched version for all three advisories (GHSA-4qv8-2p9j-2685, GHSA-f72v-6w45-q472 and GHSA-xjj6-f33q-929c all list >= 8.0.0, < 8.12.2 β†’ 8.12.2).
  • package-lock.json:15031-15033 β€” the 8.12.3 integrity hash matches what the npm registry serves for undici@8.12.3; the entry stays "dev": true, so the production bundle is unchanged.
  • changelog.d/fixed-448-undici-override.md follows the <category>-<slug>.md format in changelog.d/README.md.

The only red checks are the Netlify deploy-preview family, which is the exhausted-quota situation already ruled on in #419, not something this PR can fix. Audit, lint, tests and DCO are green.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 7d0e1ca into main Oct 24, 2026
6 of 11 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the sec/undici-override branch October 24, 2026 14:58
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#449f773d7e` sha256:d7ab7cedd942e088c42ba10f69a4016e2ada2c3cf7e3e5a42479dde02abadbee β€” download from the dashboard or `hivectl review evidence #449`.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] undici 8.11.2 (via jsdom, dev-only) has 3 high advisories β€” override to >=8.12.2

0 participants