Skip to content

chore(scripts): remove unwired netlify-ignore.sh leftover - #409

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-408
Oct 21, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-408

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #408

The script was never referenced by netlify.toml (no ignore = directive since the initial import commit 8faecb3), no workflow or npm script calls it, and the chore/hive-snapshot* branch pattern it guards does not exist in this repository; removal is deploy-safe even if a Netlify UI ignore setting still names it because a missing ignore command exits non-zero, which Netlify treats as "build".

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

The script was never referenced by netlify.toml (no `ignore =` directive since
the initial import commit 8faecb3), no workflow or npm script calls it, and the
`chore/hive-snapshot*` branch pattern it guards does not exist in this
repository. Removal is deploy-safe even if a Netlify UI ignore setting still
names it, because a missing ignore command exits non-zero, which Netlify treats
as "build".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@netlify

netlify Bot commented Oct 21, 2026

Copy link
Copy Markdown

❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 32daaff
🔍 Latest deploy log https://app.netlify.com/projects/hivecommons-docs/deploys/6ad87632731477b1c1538fcd

@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 21, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive filed review findings that do not block this PR as backlog items:

Cap: 10 backlog item(s) per PR per day.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified against the tree at 32daaff:

  • netlify.toml has no ignore = directive in [build] or [context.branch-deploy]; the only matches for netlify-ignore/hive-snapshot in the repo are the script's own echo lines (scripts/netlify-ignore.sh:5,10,11,17). No workflow or package.json script calls it.
  • The red netlify/hivecommons-docs/deploy-preview / header / redirect / pages checks are not caused by this deletion — the same four fail on #407 (a deps-only change) against the same site, so that is a pre-existing site-side condition.

One thing I cannot verify from the repo: whether a Netlify UI "ignore builds" setting names this script. Per #408 that case is still deploy-safe (a missing command exits non-zero → Netlify builds), so it does not block the removal.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified against the tree at main:

  • grep -rn netlify-ignore (excluding node_modules/.git) matches only the script's own echo lines; netlify.toml has no ignore = in [build] or [context.branch-deploy], and nothing under .github/ or package.json calls it.
  • The red Netlify checks (deploy-preview, Header rules, Redirect rules, Pages changed) are not caused by this PR — the same four fail identically on #407, which only bumps a dependency override. They are pre-existing site-side failures.

Open question for whoever owns the Netlify site settings: if an "ignore builds" command was ever set in the Netlify UI (not in netlify.toml) pointing at this script, it should be cleared after merge. Not a blocker — a missing ignore command exits non-zero, which Netlify treats as "build", so the worst case is an extra log line.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit e4273ae into main Oct 21, 2026
6 of 11 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-408 branch October 21, 2026 08:39
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#40932daaff` sha256:359799c11670b2f5b4c546aba2119590a73a84859d29f7cdf38afa2789914827 — download from the dashboard or `hivectl review evidence #409`.

@hivecommons-hive hivecommons-hive Bot removed the stage/050-review-pending Review swarm requested; awaiting a verdict for the current head label Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] chore: remove unwired scripts/netlify-ignore.sh leftover

0 participants