Repository navigation
chore(scripts): remove unwired netlify-ignore.sh leftover - #409
Conversation
The script was never referenced by netlify.toml (no `ignore =` directive since the initial import commit 8faecb3), no workflow or npm script calls it, and the `chore/hive-snapshot*` branch pattern it guards does not exist in this repository. Removal is deploy-safe even if a Netlify UI ignore setting still names it, because a missing ignore command exits non-zero, which Netlify treats as "build". Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Looks correct to me. Verified against the tree at 32daaff:
netlify.tomlhas noignore =directive in[build]or[context.branch-deploy]; the only matches fornetlify-ignore/hive-snapshotin the repo are the script's own echo lines (scripts/netlify-ignore.sh:5,10,11,17). No workflow orpackage.jsonscript calls it.- The red
netlify/hivecommons-docs/deploy-preview/ header / redirect / pages checks are not caused by this deletion — the same four fail on #407 (a deps-only change) against the same site, so that is a pre-existing site-side condition.
One thing I cannot verify from the repo: whether a Netlify UI "ignore builds" setting names this script. Per #408 that case is still deploy-safe (a missing command exits non-zero → Netlify builds), so it does not block the removal.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me. Verified against the tree at main:
grep -rn netlify-ignore(excludingnode_modules/.git) matches only the script's ownecholines;netlify.tomlhas noignore =in[build]or[context.branch-deploy], and nothing under.github/orpackage.jsoncalls it.- The red Netlify checks (
deploy-preview,Header rules,Redirect rules,Pages changed) are not caused by this PR — the same four fail identically on #407, which only bumps a dependency override. They are pre-existing site-side failures.
Open question for whoever owns the Netlify site settings: if an "ignore builds" command was ever set in the Netlify UI (not in netlify.toml) pointing at this script, it should be cleared after merge. Not a blocker — a missing ignore command exits non-zero, which Netlify treats as "build", so the worst case is an extra log line.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #408
The script was never referenced by netlify.toml (no
ignore =directive since the initial import commit 8faecb3), no workflow or npm script calls it, and thechore/hive-snapshot*branch pattern it guards does not exist in this repository; removal is deploy-safe even if a Netlify UI ignore setting still names it because a missing ignore command exits non-zero, which Netlify treats as "build".— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88