Skip to content

Port Playwright's click, click-scroll and elementhandle-scroll-into-view tests - #1084

Merged
kblok merged 11 commits into
mainfrom
issue-1060-input-pages-2
Nov 5, 2026
Merged

kblok merged 11 commits into
mainfrom
issue-1060-input-pages-2

Conversation

@kblok

@kblok kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member

Ports the click tests of Playwright's page tests (group B of #1060): the pointer, scrolling, and actionability cases that run against Playwright's input assets. The testbed also listens on localhost now, the second origin of the cross-origin click cases.

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b.

Ported (playwright category, one directory per upstream file, one class per describe):

  • click.e2e.ts: 47 it (Click/PageClickTests). Two loops (the six 1x1 divs, button/input enabled) are [TestCase]s. Not ported, as upstream: the 37 tests listed in the class summary (no force, trial, clickCount, steps, element handles, Frame objects, events, abort signals, and some upstream left undone).
  • click-scroll.e2e.ts: 6 it (ClickScroll/PageClickScrollTests). Not ported, as upstream: one force test, four scroll: "none" tests, and one Chromium-skipped test.
  • elementhandle-scroll-into-view.e2e.ts: 8 it (ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests). Not ported, as upstream: should throw for detached element.

Known differences. Three tests fail because the port lacks what upstream has. Each keeps its upstream assertions inside ExpectedToFailAsync, which passes while the body fails and fails once it passes: should click the button if window.Node is removed (#1079), should click zero-sized input by label (#1080), should work for visibility:hidden element (#1081).

.NET-only: Helpers.CROSS (upstream's CROSS) and the localhost prefix of the testbed listener. COMPATIBILITY.md lists the ported files. No change to src/, so no SKILL.md or docs change.

Refs #1060. Stacked on #1064: retarget to main after it merges.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

kblok and others added 5 commits November 4, 2026 18:40
…t tests (Refs #1060)

The testbed gets the /content route and Playwright's test assets (with its LICENSE and NOTICE), and the first four of upstream's Playwright page test files run against them.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…nce of expected failures (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…r tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…B chunks (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…iew tests (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between 85e973c and 9c938d6.

Files selected for processing: 10
  • COMPATIBILITY.md
  • tests/E2E.NUnit.Tests/Click/PageClickTests.cs
  • tests/E2E.NUnit.Tests/ClickScroll/PageClickScrollTests.cs
  • tests/E2E.NUnit.Tests/ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests.cs
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/button.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/checkbox.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/mouse-helper.js
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/rotatedButton.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/input/scrollable.html
  • tests/E2E.NUnit.Tests/Testbed/playwright/assets/wrappedlink.html
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

Fixed: copied input/mouse-helper.js, which three input pages load. Declined: the Task.Run flag pattern, the GetByText('Click target') target, the first clicked assertion of the hit-target test, the timeout test's any Error check, and the unit-level localhost prefix and CROSS derivation. They follow upstream's tests as written (same assertions and same targets), or the loopback prefix risk is the same as for 127.0.0.1.

@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Base automatically changed from issue-1060-playwright-page-tests to main November 4, 2026 22:24
kblok and others added 4 commits November 4, 2026 19:28
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
…is fixed on main (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@kblok

kblok commented Nov 4, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit 205af78 into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-input-pages-2 branch November 5, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant