You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Drop the known-difference markers of five Playwright tests - #1091
Five tests ported earlier kept a known-difference marker (ExpectedToFailAsync) because the port failed where upstream passes. The fixes are merged (#1079, #1080, #1081, #1086, #1090), so the five tests now run as upstream writes them, without the marker. COMPATIBILITY.md no longer lists the three click differences.
Upstream change ported: e2e-inc/e2e#1505, commit bdf769b. Tests (same names and assertions as upstream, no new tests):
click.e2e.ts: should click the button if window.Node is removed; should click zero-sized input by label (Click/PageClickTests).
elementhandle-scroll-into-view.e2e.ts: should work for visibility:hidden element (ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests).
The two nested-frame role tests: GetBy_coverage_role_text_test_id_label_placeholder (LocatorFrame/LocatorFrameTests) and Should_work_for_DollarEval (SelectorsFrame/SelectorsFrameTests).
The whole playwright category passes (287 passed, 3 skipped, 0 failed). No change to src/, no .NET-only symbols, no SKILL.md or docs change.
Click, scrolling, and frame-scoped locator tests now assert their results directly instead of treating these cases as expected failures.
Documentation
Updated compatibility notes to remove several known-difference references and clarify that missing-file errors use .NET’s message rather than Node’s ENOENT.
No actionable comments were generated in the recent review.
Walkthrough
Several end-to-end tests now run directly instead of using expected-failure wrappers. The compatibility note removes three known-difference references and retains notes about expected-failure handling and .NET missing-file errors.
Changes: Expected-failure test updates
Layer / File(s)
Summary
Click and scroll assertions COMPATIBILITY.md, tests/E2E.NUnit.Tests/Click/PageClickTests.cs, tests/E2E.NUnit.Tests/ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests.cs
Click tests assert their results directly. The hidden-element test calls ScrollIntoViewAsync directly. The compatibility note removes three known-difference references.
hardkoded/e2e-dotnet#710 — Adds frame-scoped locators and the LocatorFrame and SelectorsFrame test coverage updated here.
hardkoded/e2e-dotnet#1086 — Fixes frame-scoped queries across nested frames, which the updated role and $eval tests exercise.
Merge Risk: Minimal · up to 5a35e
The affected tests now enforce successful behavior directly, and the compatibility notes reflect those promotions. No actionable merge-blocking risk is identified.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title says the PR removes known-difference markers from five Playwright tests. The raw summary shows the PR removes expected-failure wrappers from five tests across four files: two Click tests, on…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Upstream Parity
The check applies because the PR names tester-army/e2e commit bdf769b (#1505). The upstream source was readable and matches the changed tests: the two Click tests, the visibility-hidden scroll test, t…
Full details: Title check
Explanation
The title says the PR removes known-difference markers from five Playwright tests. The raw summary shows the PR removes expected-failure wrappers from five tests across four files: two Click tests, one ElementhandleScrollIntoView test, one LocatorFrame test, and one SelectorsFrame test. The PR objectives describe the same removal, but they mention three tests. The title matches the main change, and the count of five matches the summary. The objectives' count of three conflicts with that. Also, the COMPATIBILITY.md edit is supporting documentation. The title does not mention it, which is acceptable.
Full details: Upstream Parity
Explanation
The check applies because the PR names tester-army/e2e commit bdf769b (#1505). The upstream source was readable and matches the changed tests: the two Click tests, the visibility-hidden scroll test, the LocatorFrame getBy-coverage test, and the SelectorsFrame $eval test have the same steps and assertions in the corresponding C# methods. The diff changes only test wrappers/markers and the matching COMPATIBILITY.md entry. It adds no src symbol, public API, or behavior not present upstream.
Finishing Touches
Generate docstrings
Commit to this branch
Create a new PR
Generate unit tests (beta)
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped tester-army/e2e.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five tests ported earlier kept a known-difference marker (
ExpectedToFailAsync) because the port failed where upstream passes. The fixes are merged (#1079, #1080, #1081, #1086, #1090), so the five tests now run as upstream writes them, without the marker. COMPATIBILITY.md no longer lists the three click differences.Upstream change ported: e2e-inc/e2e#1505, commit
bdf769b. Tests (same names and assertions as upstream, no new tests):click.e2e.ts: should click the button if window.Node is removed; should click zero-sized input by label (Click/PageClickTests).elementhandle-scroll-into-view.e2e.ts: should work for visibility:hidden element (ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests).GetBy_coverage_role_text_test_id_label_placeholder(LocatorFrame/LocatorFrameTests) andShould_work_for_DollarEval(SelectorsFrame/SelectorsFrameTests).The whole
playwrightcategory passes (287 passed, 3 skipped, 0 failed). No change tosrc/, no .NET-only symbols, no SKILL.md or docs change.Refs #1060
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Summary by CodeRabbit
ENOENT.