Skip to content

Drop the known-difference markers of five Playwright tests - #1091

Merged
kblok merged 2 commits into
mainfrom
issue-1060-drop-click-markers
Nov 5, 2026
Merged

kblok merged 2 commits into
mainfrom
issue-1060-drop-click-markers

Conversation

@kblok

@kblok kblok commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

Five tests ported earlier kept a known-difference marker (ExpectedToFailAsync) because the port failed where upstream passes. The fixes are merged (#1079, #1080, #1081, #1086, #1090), so the five tests now run as upstream writes them, without the marker. COMPATIBILITY.md no longer lists the three click differences.

Upstream change ported: e2e-inc/e2e#1505, commit bdf769b. Tests (same names and assertions as upstream, no new tests):

  • click.e2e.ts: should click the button if window.Node is removed; should click zero-sized input by label (Click/PageClickTests).
  • elementhandle-scroll-into-view.e2e.ts: should work for visibility:hidden element (ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests).
  • The two nested-frame role tests: GetBy_coverage_role_text_test_id_label_placeholder (LocatorFrame/LocatorFrameTests) and Should_work_for_DollarEval (SelectorsFrame/SelectorsFrameTests).

The whole playwright category passes (287 passed, 3 skipped, 0 failed). No change to src/, no .NET-only symbols, no SKILL.md or docs change.

Refs #1060

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK

Summary by CodeRabbit

  • Tests
    • Click, scrolling, and frame-scoped locator tests now assert their results directly instead of treating these cases as expected failures.
  • Documentation
    • Updated compatibility notes to remove several known-difference references and clarify that missing-file errors use .NET’s message rather than Node’s ENOENT.

…and #1081 are fixed (Refs #1060)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Several end-to-end tests now run directly instead of using expected-failure wrappers. The compatibility note removes three known-difference references and retains notes about expected-failure handling and .NET missing-file errors.

Changes: Expected-failure test updates

Layer / File(s) Summary
Click and scroll assertions
COMPATIBILITY.md, tests/E2E.NUnit.Tests/Click/PageClickTests.cs, tests/E2E.NUnit.Tests/ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests.cs
Click tests assert their results directly. The hidden-element test calls ScrollIntoViewAsync directly. The compatibility note removes three known-difference references.
Frame locator assertions
tests/E2E.NUnit.Tests/LocatorFrame/LocatorFrameTests.cs, tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs
Frame-scoped locator and selector tests run their assertions without expected-failure wrappers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related issues

Possibly related PRs

  • hardkoded/e2e-dotnet#710 — Adds frame-scoped locators and the LocatorFrame and SelectorsFrame test coverage updated here.
  • hardkoded/e2e-dotnet#1086 — Fixes frame-scoped queries across nested frames, which the updated role and $eval tests exercise.
Merge Risk: Minimal · up to 5a35e

The affected tests now enforce successful behavior directly, and the compatibility notes reflect those promotions. No actionable merge-blocking risk is identified.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title says the PR removes known-difference markers from five Playwright tests. The raw summary shows the PR removes expected-failure wrappers from five tests across four files: two Click tests, on…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Upstream Parity Passed The check applies because the PR names tester-army/e2e commit bdf769b (#1505). The upstream source was readable and matches the changed tests: the two Click tests, the visibility-hidden scroll test, t…
Full details: Title check

Explanation

The title says the PR removes known-difference markers from five Playwright tests. The raw summary shows the PR removes expected-failure wrappers from five tests across four files: two Click tests, one ElementhandleScrollIntoView test, one LocatorFrame test, and one SelectorsFrame test. The PR objectives describe the same removal, but they mention three tests. The title matches the main change, and the count of five matches the summary. The objectives' count of three conflicts with that. Also, the COMPATIBILITY.md edit is supporting documentation. The title does not mention it, which is acceptable.

Full details: Upstream Parity

Explanation

The check applies because the PR names tester-army/e2e commit bdf769b (#1505). The upstream source was readable and matches the changed tests: the two Click tests, the visibility-hidden scroll test, the LocatorFrame getBy-coverage test, and the SelectorsFrame $eval test have the same steps and assertions in the corresponding C# methods. The diff changes only test wrappers/markers and the matching COMPATIBILITY.md entry. It adds no src symbol, public API, or behavior not present upstream.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped tester-army/e2e.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 332c5a4 and 5a35eee.

Files selected for processing: 5

  • COMPATIBILITY.md
  • tests/E2E.NUnit.Tests/Click/PageClickTests.cs
  • tests/E2E.NUnit.Tests/ElementhandleScrollIntoView/ElementhandleScrollIntoViewTests.cs
  • tests/E2E.NUnit.Tests/LocatorFrame/LocatorFrameTests.cs
  • tests/E2E.NUnit.Tests/SelectorsFrame/SelectorsFrameTests.cs

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok kblok changed the title Drop the known-difference markers of three click tests Drop the known-difference markers of five Playwright tests Nov 5, 2026
@kblok

kblok commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor
Action not completed

Already reviewed the last commit. Use @coderabbitai full review to rerun a review of the entire changeset.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@kblok
kblok merged commit ee824be into main Nov 5, 2026
4 checks passed
@kblok
kblok deleted the issue-1060-drop-click-markers branch November 5, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant