Repository navigation
Fix window.Node, zero-sized label controls and scrollIntoView on hidden nodes - #1090
Conversation
…m's do (Closes #1079, #1080, #1081) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK
|
@coderabbitai review |
Action not completed
|
|
@coderabbitai review |
Action not completed
|
Three small page-script and locator defects found while porting Playwright's click and scroll tests (#1084).
window.Nodebroke every observation, because the page script read that global. It now comparesnodeTypewith the numbers, as upstream'sread-semantics.tsdoes.getByTextlands on the label. This tree lists the input, and it won the innermost pick. A text or label query now leaves box-less matches out when a boxed one exists. A label's text is also listed now when its control has no box (before, only the control carried it), so the label is there to pick.ScrollIntoViewAsyncrefused avisibility:hiddenelement. Upstream'sperformUntilreads no state, and scrolling needs no visibility, so a scroll into view now acts on a hidden or disabled match. Other actions still wait for an enabled match (the document engine has no actionability of its own).Once this merges, #1084 should drop
ExpectedToFailAsyncfromShould_click_the_button_if_window_Node_is_removed,Should_click_zero_sized_input_by_label(both inPageClickTests) andShould_work_for_visibility_hidden_element(ElementhandleScrollIntoViewTests). All three report UNEXPECTED_PASS with this change.Upstream: tester-army/e2e
bdf769b(click.e2e.ts,elementhandle-scroll-into-view.e2e.ts,packages/web/src/in-page/read-semantics.ts,packages/e2e/src/locator/engine.ts)..NET-only tests (no upstream
itcovers the behavior):PageScriptGlobalsTests.NET_only_observes_a_page_that_deleted_window_NodeandNET_only_lists_the_text_of_a_label_whose_control_has_no_box,LocatorEngineVisibleQueriesTests.NET_only_a_text_query_resolves_a_shown_label_over_the_zero_sized_control_inside_it,LocatorEnginePerformContractTests.NET_only_sends_the_action_to_a_hidden_node_and_leaves_its_actionability_to_the_engine. No new symbols insrc/, except the privateBoxedFirsthelper (.NET-only: this tree lists box-less nodes, upstream's does not).Closes #1079
Closes #1080
Closes #1081
🤖 Generated with Claude Code
https://claude.ai/code/session_01Ls2e1yaZFgZ3FEJkYScfkK