Repository navigation
Cover the two cases the status-bar activity work deferred - #45
Merged
Merged
Conversation
Both were deferred for want of a TUI integration harness. One exists now (`TestAppBuilder` with `TestEventSource`), so there is no reason to keep leaning on "covered indirectly by unit tests". Seeding: `ActivityState::seed_from_db` takes the first row from `find_by_status(InProgress)`, which orders by `full_id`. The fixture lists `zulu` above `alpha` in the file, so row order and `full_id` order disagree and the test fails if seeding ever stops being deterministic. Plus the empty case, where nothing is in progress. Toggling: driven through the real key path rather than by calling `record_transition` directly, so it covers the wiring in `handle_toggle_status` and not just the state machine. Open to InProgress fills the slot; InProgress to Done clears it and pushes to the recently-completed tail. `tasks/tasks.md` now marks the status-bar and live-updates files complete, which they are.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The last two unchecked boxes in
tasks/tasks.status-bar-activity.md. Both weredeferred for want of a TUI integration harness. One exists now (
TestAppBuilderwith
TestEventSource), so there is no reason to keep leaning on "coveredindirectly by unit tests on
ActivityState::record_transition".Seeding
ActivityState::seed_from_dbtakes the first row fromfind_by_status(InProgress), which orders byfull_id. The fixture listszuluabovealphain the file, so row order andfull_idorder disagree andthe test fails if seeding ever stops being deterministic. Plus the empty case,
where nothing is in progress.
Toggling
Driven through the real key path (Tab to the tasks pane, then Space) rather than
by calling
record_transitiondirectly, so it covers the wiring inhandle_toggle_statusand not just the state machine. Open to InProgress fillsthe slot; InProgress to Done clears it and pushes to the recently-completed
tail.
Task file cleanup
tasks/tasks.mdmarks the status-bar and live-updates files complete, whichthey now are.